On Tue, Oct 14, 2014 at 11:00:47AM -0400, Bruce Momjian wrote:
> On Tue, Oct 14, 2014 at 05:40:06PM +0300, Emre Hasegeli wrote:
> > > I extracted Emre's diagram adjustments from the patch and applied it,
> > > and no tabs now. Emre, I assume your regression changes did not affect
> > > the diagram
On Tue, Oct 14, 2014 at 05:40:06PM +0300, Emre Hasegeli wrote:
> > I extracted Emre's diagram adjustments from the patch and applied it,
> > and no tabs now. Emre, I assume your regression changes did not affect
> > the diagram contents.
>
> Thank you for looking at it. I wanted to make the test
> I extracted Emre's diagram adjustments from the patch and applied it,
> and no tabs now. Emre, I assume your regression changes did not affect
> the diagram contents.
Thank you for looking at it. I wanted to make the tests consistent
with the diagrams. Now they look better but they still don'
On Wed, Jul 23, 2014 at 06:12:59PM -0400, Robert Haas wrote:
> On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane wrote:
> > Robert Haas writes:
> >> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote:
> >>> The first two shapes on src/test/regress/sql/polygon.sql do not make
> >>> sense to me.
> >
>
Emre Hasegeli writes:
>> Well, I think the number of tabs that makes them look best depends on
>> your tab-stop setting. At present, I find that with 8-space tabs
>> things seem to line up pretty well, whereas with your patch, 4-space
>> tabs line up well.
> 4 space tab-stop is not the project s
> Well, I think the number of tabs that makes them look best depends on
> your tab-stop setting. At present, I find that with 8-space tabs
> things seem to line up pretty well, whereas with your patch, 4-space
> tabs line up well. Either way, I have no idea what the picture is
> supposed to mean,
On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote:
>>> The first two shapes on src/test/regress/sql/polygon.sql do not make
>>> sense to me.
>
>> Well, I think the number of tabs that makes them look best depends on
>>
Robert Haas writes:
> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote:
>> The first two shapes on src/test/regress/sql/polygon.sql do not make
>> sense to me.
> Well, I think the number of tabs that makes them look best depends on
> your tab-stop setting. At present, I find that with 8-sp
On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote:
> The first two shapes on src/test/regress/sql/polygon.sql do not make
> sense to me. They look more like polygons with some more tabs,
> but still did not match the coordinates. I changed them to make
> consistent with the shapes. I believ
