Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-09 Thread Robert Haas
On Tue, Nov 8, 2016 at 4:04 AM, Fabien COELHO wrote: > > [ ... v4 ] > >> I checked. It works as expected. I have no more comments. >> If its okay with Fabien, we can mark it ready for committer. > > Patch applies, compiles (including the documentation), make check ok and >

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-08 Thread Fabien COELHO
[ ... v4 ] I checked. It works as expected. I have no more comments. If its okay with Fabien, we can mark it ready for committer. Patch applies, compiles (including the documentation), make check ok and features works for me. Code could be a little simpler, but it is okay. I've switched

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-07 Thread Beena Emerson
Hello, On Mon, Nov 7, 2016 at 8:42 PM, Masahiko Sawada wrote: > On Mon, Nov 7, 2016 at 10:52 PM, Beena Emerson > wrote: > > Hello Sawada-san, > > > > On Mon, Nov 7, 2016 at 4:47 PM, Masahiko Sawada > > wrote: > >> > >> On

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-07 Thread Masahiko Sawada
On Mon, Nov 7, 2016 at 10:52 PM, Beena Emerson wrote: > Hello Sawada-san, > > On Mon, Nov 7, 2016 at 4:47 PM, Masahiko Sawada > wrote: >> >> On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson >> wrote: >> > Hello, >> > >> > On

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-07 Thread Beena Emerson
Hello Sawada-san, On Mon, Nov 7, 2016 at 4:47 PM, Masahiko Sawada wrote: > On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson > wrote: > > Hello, > > > > On Wed, Nov 2, 2016 at 4:16 AM, Fabien COELHO > wrote: > >> > >> > >> Hello

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-07 Thread Masahiko Sawada
On Wed, Nov 2, 2016 at 3:57 PM, Beena Emerson wrote: > Hello, > > On Wed, Nov 2, 2016 at 4:16 AM, Fabien COELHO wrote: >> >> >> Hello Masahiko, >> So I would suggest to: - fix the compilation issue - leave -l/--log as it is, i.e. use

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-02 Thread Beena Emerson
Hello, On Wed, Nov 2, 2016 at 4:16 AM, Fabien COELHO wrote: > > Hello Masahiko, > > So I would suggest to: >>> - fix the compilation issue >>> - leave -l/--log as it is, i.e. use "pgbench_log" as a prefix >>> - add --log-prefix=... (long option only) for changing this

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-01 Thread Fabien COELHO
Hello Masahiko, So I would suggest to: - fix the compilation issue - leave -l/--log as it is, i.e. use "pgbench_log" as a prefix - add --log-prefix=... (long option only) for changing this prefix I agree. It's better to add the separated option to specify the prefix of log file instead of

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-01 Thread Masahiko Sawada
On Wed, Nov 2, 2016 at 1:41 AM, Fabien COELHO wrote: > >> The log file generated by pgbench -l option is fixed file name >> 'pgbench_log..'. And it's a little complicated for the >> script that runs pgbench repeatedly to identify the log file name. >> Attached patch make it

Re: [HACKERS] Specifying the log file name of pgbench -l option

2016-11-01 Thread Fabien COELHO
The log file generated by pgbench -l option is fixed file name 'pgbench_log..'. And it's a little complicated for the script that runs pgbench repeatedly to identify the log file name. Attached patch make it possible to specify the log file name. I think it's useful for the use who want to run