-Original Message-
From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-
ow...@postgresql.org] On Behalf Of Robert Haas
Sent: Friday, May 01, 2009 6:00 PM
To: Andy Lester
Cc: Dimitri Fontaine; PostgreSQL-development
Subject: Re: [HACKERS] Throw some low-level C scutwork
Hi,
OK, so, when I initially started catching up on this thread, I was
kind of feeling annoyed at Tom, and I still wish he'd say something
along the lines of I did not mean to give offense and I'm sorry if my
words came across in a way that I did not intend rather than just
explaining
Andy Lester a...@petdance.com writes:
And if you're an Emacs person, you can help figure out what the
modeline should be for Emacs, and we can get that in there, too.
If you're an Emacs person, you fix it in your ~/.emacs file so that
every .c file in the Postgres tree is automatically
On Fri, May 1, 2009 at 11:23 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Andy Lester a...@petdance.com writes:
And if you're an Emacs person, you can help figure out what the
modeline should be for Emacs, and we can get that in there, too.
If you're an Emacs person, you fix it in your ~/.emacs
Robert Haas robertmh...@gmail.com writes:
Speaking of space/tab settings, one thing I'm fuzzy on is the rule for
wrapping long lines. I understand that a line that extends past 80
characters has to be wrapped, but the amount of indentation on the
continuation line doesn't appear to follow a
David E. Wheeler wrote:
On May 1, 2009, at 8:38 AM, Robert Haas wrote:
Speaking of space/tab settings, one thing I'm fuzzy on is the rule for
wrapping long lines. I understand that a line that extends past 80
characters has to be wrapped, but the amount of indentation on the
continuation
On May 1, 2009, at 10:38 AM, Andrew Dunstan wrote:
Please, let's not have a whole host of different indentation styles.
Postgres has a well established style. Let's stick to it in both
perl and C
+1
David
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On May 1, 2009, at 8:38 AM, Robert Haas wrote:
Speaking of space/tab settings, one thing I'm fuzzy on is the rule for
wrapping long lines. I understand that a line that extends past 80
characters has to be wrapped, but the amount of indentation on the
continuation line doesn't appear to follow
On Fri, May 01, 2009 at 01:38:38PM -0400, Andrew Dunstan wrote:
David E. Wheeler wrote:
On May 1, 2009, at 8:38 AM, Robert Haas wrote:
Speaking of space/tab settings, one thing I'm fuzzy on is the rule
for wrapping long lines. I understand that a line that extends
past 80 characters has to
On May 1, 2009, at 10:54 AM, David Fetter wrote:
foreach my $element (@array) {
# clear, short, idiomatic code here
}
instead of Rube Goldberg constructs like this:
my $i;
for ($i=0; $i = $#array; ++$i)
{
# kludges up down and sideways here
}
is a good idea because it makes it easier
If you're an Emacs person, you fix it in your ~/.emacs file so that
every .c file in the Postgres tree is automatically handled with the
correct mode. Surely vi apologists can make their editor do the same.
Thanks for your remarkable response. I will refer to it often for
months to come.
On Fri, May 01, 2009 at 11:23:24AM -0400, Tom Lane wrote:
Andy Lester a...@petdance.com writes:
And if you're an Emacs person, you can help figure out what the
modeline should be for Emacs, and we can get that in there, too.
If you're an Emacs person, you fix it in your ~/.emacs file so
On Fri, 2009-05-01 at 12:09 -0700, David Fetter wrote:
I'd appreciate your making an argument, if you're going to, on the
merits of the proposal at hand, rather than stooping to personal
insult. You know better.
O.k. guys let's all take a breath here. We all have our favorite editors
and our
On Fri, May 01, 2009 at 12:37:19PM -0700, Joshua D. Drake wrote:
On Fri, 2009-05-01 at 12:09 -0700, David Fetter wrote:
I'd appreciate your making an argument, if you're going to, on the
merits of the proposal at hand, rather than stooping to personal
insult. You know better.
O.k.
On May 1, 2009, at 2:37 PM, Joshua D. Drake wrote:
Regardless, I
agree with Tom that the idea of having decorators of any kind in
source
or docs is a bad idea.
Why is it a bad idea? I don't understand the downside of a line or
two at the bottom of a source file.
That being said,
Joshua D. Drake wrote:
That being said, there is no reason why we can have a section of the
wiki that has .rc files for respective editors and environments that
conform to .Org coding conventions.
Look in src/tools/editors. Already there. For both emacs and vi.
cheers
andrew
--
Sent
Joshua D. Drake j...@commandprompt.com writes:
That being said, there is no reason why we can have a section of the
wiki that has .rc files for respective editors and environments that
conform to .Org coding conventions.
I think we already have that in the CVS tree - look in
Andy Lester wrote:
On May 1, 2009, at 2:37 PM, Joshua D. Drake wrote:
Regardless, I
agree with Tom that the idea of having decorators of any kind in source
or docs is a bad idea.
Why is it a bad idea? I don't understand the downside of a line or
two at the bottom of a source file.
David Fetter da...@fetter.org writes:
That was truly un-called-for. I don't care who you are or what you've
done because nobody gets to treat volunteers the way you did above.
Well, a volunteer whose first proposed contribution is a patch to add
modelines to every file in the tree (with the
On Fri, 2009-05-01 at 14:44 -0500, Andy Lester wrote:
On May 1, 2009, at 2:37 PM, Joshua D. Drake wrote:
Regardless, I
agree with Tom that the idea of having decorators of any kind in
source
or docs is a bad idea.
Why is it a bad idea? I don't understand the downside of a line or
Because it becomes one more maintenance task we don't need.
There should be nothing to maintain, if it's done right.
The linux kernel is a mess. There are a couple of hundred files
with inconssistent mode lines. Most have none (and there are
thousands).
So it sounds like they could
Well, a volunteer whose first proposed contribution is a patch to add
modelines to every file in the tree (with the clear subtext that we're
idiots to not have thought of it before)
No subtext at all. Perhaps the volunteer figured nobody ever bothered
with it before.
should expect a bit
Andy Lester a...@petdance.com writes:
So we're hardly alone in not doing it the way you're suggesting.
Sure, and I'm sure there are plenty of projects that do use them to
great effect, most notably Perl 5 and Parrot. Perl 5 specifically has
had the mish-mosh of tabs-vs-spaces reduced by
Hi,
Le 1 mai 09 à 22:02, Andy Lester a écrit :
Because it becomes one more maintenance task we don't need.
There should be nothing to maintain, if it's done right.
Any line in the source tree will have to get maintained, or why would
you spend any time writing it?
So it sounds like
Well, when I read both messages, I read just as much subtext in the
original message as Tom's reply. No more, no less.
To take personal offence at what Tom wrote, I think you'ld need to
take personal offence at the way the way the initial proposal (or
rather, more the it just needs to be done)
There should be nothing to maintain, if it's done right.
Any line in the source tree will have to get maintained, or why
would you spend any time writing it?
I meant by hand.
See doc/FAQ_DEV and those specific lines:
I see no such file. Perhaps it doesn't get exported into the git
On Fri, 2009-05-01 at 15:35 -0500, Andy Lester wrote:
There should be nothing to maintain, if it's done right.
Any line in the source tree will have to get maintained, or why
would you spend any time writing it?
I meant by hand.
See doc/FAQ_DEV and those specific lines:
I see
On May 1, 2009, at 3:46 PM, Joshua D. Drake wrote:
See doc/FAQ_DEV and those specific lines:
I see no such file. Perhaps it doesn't get exported into the git
mirror?
It is actually:
http://wiki.postgresql.org/wiki/Developer_FAQ
I understand that the FAQ is on the wiki. What I am
--
Greg
On 1 May 2009, at 21:09, David Fetter da...@fetter.org wrote:
On Fri, May 01, 2009 at 11:23:24AM -0400, Tom Lane wrote:
We had a similar thing for awhile with the .sgml files, and got rid
of
that because it sucked ...
I'd appreciate your making an argument, if you're
Le 1 mai 09 à 22:56, Andy Lester a écrit :
http://wiki.postgresql.org/wiki/Developer_FAQ
I understand that the FAQ is on the wiki. What I am saying is that
my git repo does not have doc/FAQ_DEV. I didn't see it scroll by in
the CVS repo that I'm rsyncing, either.
Sorry:
On Fri, 2009-05-01 at 15:56 -0500, Andy Lester wrote:
On May 1, 2009, at 3:46 PM, Joshua D. Drake wrote:
See doc/FAQ_DEV and those specific lines:
I see no such file. Perhaps it doesn't get exported into the git
mirror?
It is actually:
Andy Lester wrote:
I've got my git clone set up, a copy of GCC 4.4 (and other compilers) at
the ready, and am glad to help out on low-level scut work. Anybody need
anything done? splint? valgrind? Let me know.
If you have some time to kill, perhaps you could check the Coverity bug
list
On Fri, May 1, 2009 at 4:35 PM, Andy Lester a...@petdance.com wrote:
There should be nothing to maintain, if it's done right.
Any line in the source tree will have to get maintained, or why would you
spend any time writing it?
I meant by hand.
See doc/FAQ_DEV and those specific lines:
I
Getting our Perl into shape would be Really Good(TM). :)
I will, but right now my #1 is getting some vi modelines in place so
we can all be using the same tab/space settings.
xoxo,
Andy
--
Andy Lester = a...@petdance.com = www.theworkinggeek.com = AIM:petdance
--
Sent via
On Apr 30, 2009, at 4:39 PM, Andrew Dunstan wrote:
I will, but right now my #1 is getting some vi modelines in place
so we can all be using the same tab/space settings.
Hasn't that been discussed before and rejected? (For one thing,
plenty of us don't use vi)
For those who do use vi,
On Thu, Apr 30, 2009 at 05:39:42PM -0400, Andrew Dunstan wrote:
Andy Lester wrote:
Getting our Perl into shape would be Really Good(TM). :)
I will, but right now my #1 is getting some vi modelines in place so
we can all be using the same tab/space settings.
Hasn't that been discussed
Andy Lester wrote:
Getting our Perl into shape would be Really Good(TM). :)
I will, but right now my #1 is getting some vi modelines in place so
we can all be using the same tab/space settings.
Hasn't that been discussed before and rejected? (For one thing, plenty
of us don't use vi)
On Wed, Apr 29, 2009 at 01:34:19PM -0500, Andy Lester wrote:
I've got my git clone set up, a copy of GCC 4.4 (and other
compilers) at the ready, and am glad to help out on low-level scut
work. Anybody need anything done? splint? valgrind? Let me know.
Getting our Perl into shape would be
38 matches
Mail list logo
