Re: [HACKERS] Typo in insert.sgml

2017-08-27 Thread Peter Eisentraut 
On 6/20/17 15:03, David G. Johnston wrote:
> On Tuesday, June 20, 2017, Robert Haas  > wrote:
> 
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> > wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
> 
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
> 
> 
> Maybe
> 
> [...] that are not identity columns in tbl2. Values
> for identity columns will come from the sequence generators for
> tbl2.
> 
> Otherwise I'd drop the word "continue" altogether and just say "but will
> use the sequence counters for".

I have committed something along those lines.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread Peter Eisentraut 
On 8/2/17 08:21, Robert Haas wrote:
> On Wed, Aug 2, 2017 at 6:04 AM, 高增琦  wrote:
>> Commit: 3f88672a4e4d8e648d24ccc65937da61c7660854 add "security label on
>> domain"
>> in "gram.y", and set "objtype" to "OBJECT_TYPE".
>>
>> Is this a typo?
> 
> Looks like it.

Fix committed to master.  I don't intend to backpatch it.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] typo for using "OBJECT_TYPE" for "security label on domain" in "gram.y"

2017-08-02 Thread Robert Haas 
On Wed, Aug 2, 2017 at 6:04 AM, 高增琦  wrote:
> Commit: 3f88672a4e4d8e648d24ccc65937da61c7660854 add "security label on
> domain"
> in "gram.y", and set "objtype" to "OBJECT_TYPE".
>
> Is this a typo?

Looks like it.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in backend/storage/ipc/standby.c

2017-07-12 Thread Kyotaro HORIGUCHI 
At Wed, 12 Jul 2017 17:11:12 +0300, Heikki Linnakangas  wrote 
in 
> On 07/11/2017 10:34 AM, Kyotaro HORIGUCHI wrote:
> > I noticed that a comment above StandbyAcquireAccessExclusiveLock
> > in backend/storage/ipc/standby.c using wrong names of a variable
> > and a type.
> >
> > The attached patch fixes it. The same mistake is found in older
> > versions back to 9.0.
> >
> Applied, thanks!

Thanks!

-- 
Kyotaro Horiguchi
NTT Open Source Software Center



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in backend/storage/ipc/standby.c

2017-07-12 Thread Heikki Linnakangas 

On 07/11/2017 10:34 AM, Kyotaro HORIGUCHI wrote:

Hello.

I noticed that a comment above StandbyAcquireAccessExclusiveLock
in backend/storage/ipc/standby.c using wrong names of a variable
and a type.

The attached patch fixes it. The same mistake is found in older
versions back to 9.0.

fix_typo_of_standby_c_10_master.patch is for 10 and master and
fix_typo_of_standby_c_96_and_before.patch for 9.6 and before.


Applied, thanks!

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in xlog.c: ReadRecord

2017-07-02 Thread Amit Langote 
On 2017/07/01 3:49, Peter Eisentraut wrote:
> On 6/27/17 20:54, Amit Langote wrote:
>> Attached fixes $SUBJECT.
>>
>> s/fetch_ckpt/fetching_ckpt/g
> 
> committed

Thanks.

Regards,
Amit



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in postgres_fdw.c

2017-06-30 Thread Peter Eisentraut 
On 6/28/17 09:53, Albe Laurenz wrote:
> Attached is a fix for a small typo I found.

committed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in xlog.c: ReadRecord

2017-06-30 Thread Peter Eisentraut 
On 6/27/17 20:54, Amit Langote wrote:
> Attached fixes $SUBJECT.
> 
> s/fetch_ckpt/fetching_ckpt/g

committed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread David G. Johnston 
On Tue, Jun 20, 2017 at 1:35 PM, Tom Lane  wrote:
> Robert Haas  writes:
>> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
>>  wrote:
>>> This was not a typo, this was intentional.
>
>> To me, Julien's change seems to make it easier to understand, but
>> maybe I'm misunderstanding what it's trying to say in the first place.
>
> I think there are two subtly different things here: the sequence counters
> will continue to be attached to the identity columns, and the counters
> will continue in sequence (ie, no implied ALTER SEQUENCE RESTART).
> The existing text seems to mean the latter but Julien's change makes it
> about the former.
>
> It could use rewording for clarity, just not this rewording.

Tom, I'm not following your train of thought:

Given one sequenced IDENTITY column in each table (some rows were
delete from each already):
tbl1
4
5
6

tbl2
10
11
12

The point being made is that inserting all rows from tbl1 into tbl2
will result in tbl2 having:
10
11
12
13
14
15

and not:
10
11
12
4
5
6

That the sequence counters continue to be attached seems like it can
and should be taken for granted.  Inserting to a table likewise should
never cause an ALTER SEQUENCE RESTART to occur and so can and should
be taken for granted.

ISTM that both the existing text and Julien's variation say this, just
differently.  I think the word "continue" is part of the problem.  I
also think not being explicit about the fact that its tbl2's sequence
that supplies the new values - instead of using the values already
present in tbl1 - requires one to think harder about the scenario than
need be.

David J.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Tom Lane 
Robert Haas  writes:
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
>  wrote:
>> This was not a typo, this was intentional.

> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.

I think there are two subtly different things here: the sequence counters
will continue to be attached to the identity columns, and the counters
will continue in sequence (ie, no implied ALTER SEQUENCE RESTART).
The existing text seems to mean the latter but Julien's change makes it
about the former.

It could use rewording for clarity, just not this rewording.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread David G. Johnston 
On Tuesday, June 20, 2017, Robert Haas  wrote:

> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> > wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
>
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
>
>
Maybe

[...] that are not identity columns in tbl2. Values for
identity columns will come from the sequence generators for
tbl2.

Otherwise I'd drop the word "continue" altogether and just say "but will
use the sequence counters for".

David J.

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Julien Rouhaud 
On 20/06/2017 20:34, Peter Eisentraut wrote:
> On 6/18/17 03:16, Julien Rouhaud wrote:
>> Patch attached.
> 
> This was not a typo, this was intentional.
> 

Oh, sorry.  I'm not a native english speaker, that sounded really weird.

-- 
Julien Rouhaud
http://dalibo.com - http://dalibo.org


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Robert Haas 
On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
 wrote:
> On 6/18/17 03:16, Julien Rouhaud wrote:
>> Patch attached.
>
> This was not a typo, this was intentional.

To me, Julien's change seems to make it easier to understand, but
maybe I'm misunderstanding what it's trying to say in the first place.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in insert.sgml

2017-06-20 Thread Peter Eisentraut 
On 6/18/17 03:16, Julien Rouhaud wrote:
> Patch attached.

This was not a typo, this was intentional.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Julien Rouhaud 
On Sun, Jun 18, 2017 at 07:42:54PM +0200, Magnus Hagander wrote:
> On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud 
> wrote:
> 
> > Patch attached.
> >
> 
> Applied, thanks.
> 

Thanks.

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Magnus Hagander 
On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud 
wrote:

> Patch attached.
>

Applied, thanks.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/

Re: [HACKERS] Typo in planstats.sgml

2017-06-17 Thread Julien Rouhaud 
On 18/06/2017 01:03, Peter Eisentraut wrote:
> On 6/17/17 05:00, Julien Rouhaud wrote:
>> A "condition" is missing, patch attached.
> 
> fixed
> 

Thanks.

-- 
Julien Rouhaud
http://dalibo.com - http://dalibo.org


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in planstats.sgml

2017-06-17 Thread Peter Eisentraut 
On 6/17/17 05:00, Julien Rouhaud wrote:
> A "condition" is missing, patch attached.

fixed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in CREATE SUBSCRIPTION documentation

2017-06-17 Thread Julien Rouhaud 
On Sat, Jun 17, 2017 at 10:24:32AM -0400, Peter Eisentraut wrote:
> On 6/15/17 15:19, Julien Rouhaud wrote:
> > Hi,
> > 
> > I just found $SUBJECT, patch attached.
> 
> fixed

Thanks!

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in CREATE SUBSCRIPTION documentation

2017-06-17 Thread Peter Eisentraut 
On 6/15/17 15:19, Julien Rouhaud wrote:
> Hi,
> 
> I just found $SUBJECT, patch attached.

fixed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in ecpg datetime.c

2017-06-15 Thread Peter Eisentraut 
On 6/15/17 04:54, Daniel Gustafsson wrote:
> Spotted s/fiedls/fields/ in src/interfaces/ecpg/pgtypeslib/datetime.c per the
> attached patch.

fixed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in BRIN documentation

2017-06-13 Thread Julien Rouhaud 
On Tue, Jun 13, 2017 at 11:29:30AM -0400, Peter Eisentraut wrote:
> On 6/13/17 07:53, Julien Rouhaud wrote:
> > I just found this typo while doing french translation, patch attached.
>
> fixed
>

Thanks !

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in BRIN documentation

2017-06-13 Thread Peter Eisentraut 
On 6/13/17 07:53, Julien Rouhaud wrote:
> I just found this typo while doing french translation, patch attached.

fixed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in xlogfuncs.c [WAS Re: Incorrect mention of pg_xlog_switch() in xlogfuncs.c]

2017-06-09 Thread Peter Eisentraut 
On 5/31/17 19:59, Neha Khatri wrote:
> Simplifying  $subject. There are typos in xlogfuncs.c. So Either
> 
> s/pg_xlog_switch/pg_switch_wal

fixed

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in json.c

2017-05-18 Thread Heikki Linnakangas 

On 05/18/2017 10:17 AM, Daniel Gustafsson wrote:

Spotted while reading code, patch attached.


Applied, thanks.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in htup_details.h

2017-04-15 Thread Tom Lane 
Amit Kapila  writes:
> Attached patch to fix $SUBJECT.

Pushed, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in libpq

2017-03-31 Thread Magnus Hagander 
On Thu, Mar 30, 2017 at 3:48 PM, Daniel Gustafsson  wrote:

> There seems to be a typo in libpq as per attached, “..we will loose error
> messages” should probably be “..we will lose error messages”.
>

Applied, thanks.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in snapbuild.c

2017-03-13 Thread Magnus Hagander 
On Mon, Mar 13, 2017 at 8:33 AM, Masahiko Sawada 
wrote:

> Hi,
>
> Attached fixes comment typos in snapbuild.c file.
>

Applied, thanks.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in comment in postgres_fdw.c

2017-01-27 Thread Robert Haas 
On Thu, Jan 26, 2017 at 10:45 PM, Etsuro Fujita
 wrote:
> I ran into a typo in a comment in contrib/postgres_fdw/postgres_fdw.c.
> Attached is a small patch for fixing that.

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in hashsearch.c

2017-01-18 Thread Robert Haas 
On Fri, Jan 13, 2017 at 4:38 AM, Mithun Cy  wrote:
> There is a typo in comments of function _hash_first(); Adding a fix for same.

Thanks.  I pushed a commit including this fix and some other
improvements to that comment.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in condition_variable.c

2017-01-16 Thread Fujii Masao 
On Mon, Jan 16, 2017 at 6:34 PM, Masahiko Sawada  wrote:
> On Mon, Jan 16, 2017 at 6:27 PM, Fujii Masao  wrote:
>> On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada  
>> wrote:
>>> Hi,
>>>
>>> Attached patch fixes comment typos in condition_variable.c
>>
>> Seems the patch still has the typo. "initiailly" should be "initially"?
>>
>
> Yes, it should be "initially".

OK, pushed. Thanks!

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in condition_variable.c

2017-01-16 Thread Masahiko Sawada 
On Mon, Jan 16, 2017 at 6:27 PM, Fujii Masao  wrote:
> On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada  
> wrote:
>> Hi,
>>
>> Attached patch fixes comment typos in condition_variable.c
>
> Seems the patch still has the typo. "initiailly" should be "initially"?
>

Yes, it should be "initially".

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in condition_variable.c

2017-01-16 Thread Fujii Masao 
On Mon, Jan 16, 2017 at 5:42 PM, Masahiko Sawada  wrote:
> Hi,
>
> Attached patch fixes comment typos in condition_variable.c

Seems the patch still has the typo. "initiailly" should be "initially"?

Regards,

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in dsa.c

2017-01-11 Thread Magnus Hagander 
On Wed, Jan 11, 2017 at 8:28 AM, Masahiko Sawada 
wrote:

> Hi,
>
> Attached fixes comment typos in dsa.c.
>

Thanks, pushed!

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in doc/src/sgml/catalogs.sgml

2016-12-12 Thread Robert Haas 
On Sun, Dec 11, 2016 at 5:13 AM, Joel Jacobson  wrote:
> Hi,
>
> I found a minor typo at
> https://www.postgresql.org/docs/9.6/static/catalog-pg-am.html.
>
> pg_catalog.pg_am. amhandler is of type "oid" according to the
> documentation, but it's actually of type "regproc" in reality.
>
> Compare with e.g. pg_aggregate where the columns of type "regproc" is
> both "regproc" in the documentation and in reality.

Thanks, committed and back-patched to 9.6.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment

2016-11-25 Thread Magnus Hagander 
On Fri, Nov 25, 2016 at 4:10 AM, Thomas Munro  wrote:

> Hi
>
> Here is a tiny patch to fix a typo in execParallel.c.
>

Applied, thanks.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in comment in file analyze.c [master branch]

2016-11-23 Thread Tom Lane 
Kostiantyn Nemchenko  writes:
> I've found a typo in a comment in function do_analyze_rel() in
> file analyze.c [line 348, master branch].

No, "iff" is intentional there.  It means "if and only if".

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in event_trigger.c

2016-11-08 Thread Robert Haas 
On Tue, Nov 8, 2016 at 8:28 AM, Michael Paquier
 wrote:
> Hi all,
>
> I just bumped into the following:
> --- a/src/backend/commands/event_trigger.c
> +++ b/src/backend/commands/event_trigger.c
> @@ -742,7 +742,7 @@ EventTriggerCommonSetup(Node *parsetree,
>
> /*
>  * Filter list of event triggers by command tag, and copy them into our
> -* memory context.  Once we start running the command trigers, or indeed
> +* memory context.  Once we start running the command triggers, or indeed
>  * once we do anything at all that touches the catalogs, an invalidation
>  * might leave cachelist pointing at garbage, so we must do this before we
>  * can do much else.
>
> Thanks to David Steele for pointing out a similar typo in one of my patches :p

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in event_trigger.c

2016-11-08 Thread Michael Paquier 
On Wed, Nov 9, 2016 at 5:35 AM, Robert Haas  wrote:
> Committed.

Thanks.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-06 Thread Etsuro Fujita 

On 2016/11/04 22:04, Robert Haas wrote:

On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujita
 wrote:

I found another typo in postgres_fdw.c.  Attached is a patch for fixing
that.



OK, committed that, too.


Thanks again!

Best regards,
Etsuro Fujita




--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-04 Thread Robert Haas 
On Fri, Nov 4, 2016 at 7:20 AM, Etsuro Fujita
 wrote:
> On 2016/11/02 5:22, Robert Haas wrote:
>> On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita
>>  wrote:
>>>
>>> I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please
>>> find attached a patch.
>
>> Committed.
>
> Thanks!
>
> I found another typo in postgres_fdw.c.  Attached is a patch for fixing
> that.

OK, committed that, too.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-04 Thread Etsuro Fujita 

On 2016/11/02 5:22, Robert Haas wrote:

On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita
 wrote:

I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please
find attached a patch.



Committed.


Thanks!

I found another typo in postgres_fdw.c.  Attached is a patch for fixing 
that.


Best regards,
Etsuro Fujita
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c
index 2cfb82b..fbe6929 100644
--- a/contrib/postgres_fdw/postgres_fdw.c
+++ b/contrib/postgres_fdw/postgres_fdw.c
@@ -4156,7 +4156,7 @@ foreign_join_ok(PlannerInfo *root, RelOptInfo *joinrel, JoinType jointype,
 	 * other remote clauses. For LEFT and RIGHT OUTER join, the clauses from
 	 * the outer side are added to remote_conds since those can be evaluated
 	 * after the join is evaluated. The clauses from inner side are added to
-	 * the joinclauses, since they need to evaluated while constructing the
+	 * the joinclauses, since they need to be evaluated while constructing the
 	 * join.
 	 *
 	 * For a FULL OUTER JOIN, the other clauses from either relation can not

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in contrib/postgres_fdw/deparse.c

2016-11-01 Thread Robert Haas 
On Tue, Nov 1, 2016 at 8:20 AM, Etsuro Fujita
 wrote:
> I ran into a typo in a comment in contrib/postgres_fdw/deparse.c. Please
> find attached a patch.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in pgstat.c

2016-10-26 Thread Heikki Linnakangas 

On 10/21/2016 04:06 AM, vinayak wrote:

Attached patch fixes a typo in pgstat.c

s/addtions/additions/g


Fixed, thanks.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in pgstat.h

2016-10-26 Thread Heikki Linnakangas 

On 10/21/2016 03:55 AM, vinayak wrote:

- * st_progress_command_target, and st_progress_command[].

+ * st_progress_command_target, and st_progress_param[].


Attached patch fixed typo.


Fixed, thanks.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in foreign.h

2016-10-18 Thread Robert Haas 
On Wed, Oct 12, 2016 at 9:20 PM, Amit Langote
 wrote:
> Attached fixes a minor typo: s/Thes/These/g

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel.sqml

2016-10-13 Thread Tatsuo Ishii 
> Indeed. It looks like a bad copy-pasto of two sentences gathered together.

Thanks! I will commit/push to master and 9.6 stable branches.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel.sqml

2016-10-13 Thread Michael Paquier 
On Fri, Oct 14, 2016 at 8:41 AM, Tatsuo Ishii  wrote:
> diff --git a/doc/src/sgml/parallel.sgml b/doc/src/sgml/parallel.sgml
> index 7f8e902..02173da 100644
> --- a/doc/src/sgml/parallel.sgml
> +++ b/doc/src/sgml/parallel.sgml
> @@ -339,7 +339,7 @@ EXPLAIN SELECT * FROM pgbench_accounts WHERE filler LIKE 
> '%x%';
>
>
>  When executing a parallel plan, you can use EXPLAIN (ANALYZE,
> -VERBOSE) will display per-worker statistics for each plan node.
> +VERBOSE) to display per-worker statistics for each plan node.
>  This may be useful in determining whether the work is being evenly
>  distributed between all plan nodes and more generally in understanding 
> the
>  performance characteristics of the plan.

Indeed. It looks like a bad copy-pasto of two sentences gathered together.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in libpq-int.h

2016-09-22 Thread Heikki Linnakangas 

On 09/22/2016 04:35 PM, Daniel Gustafsson wrote:

Ran into a typo in libpq-int.h while reading/hacking:

-   char   *gsslib; /* What GSS librart to use 
("gssapi" or
+   char   *gsslib; /* What GSS library to use 
("gssapi” or

Patch attached.


Thanks, fixed.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in pgstat.h

2016-09-21 Thread Peter Eisentraut 
On 9/21/16 10:04 AM, Michael Paquier wrote:
> While going through pgstat.h I bumped into that:
> - * as 4-bytes where first byte repersents the wait event class (type of
> + * as 4-bytes where first byte represents the wait event class (type of

Fixed.  There was actually another one of the same a few lines later.

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in filename identification

2016-09-12 Thread Simon Riggs 
On 11 September 2016 at 23:56, Daniel Gustafsson  wrote:
> The IDENTIFICATION filename in src/backend/storage/ipc/dsm_impl.c is
> incorrectly labelling the file dsm.c.  Patch fixing the typo attached.
>
> cheers ./daniel

Applied, thanks.

-- 
Simon Riggshttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]

2016-08-22 Thread Robert Haas 
On Mon, Aug 22, 2016 at 9:01 AM, Dmitry Ivanov  wrote:
>> Hi hackers,
>>
>> I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c
>> :
>> 271, master branch]:
>> >> This is a functiion to check
>
> Attached a patch.

Thanks.  Committed with a bit of additional wordsmithing.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment to function LockHasWaitersRelation() [master branch]

2016-08-22 Thread Dmitry Ivanov 
> Hi hackers,
> 
> I've found a typo in a comment to function LockHasWaitersRelation() [lmgr.c
> :
> 271, master branch]:
> >> This is a functiion to check

Attached a patch.

-- 
Dmitry Ivanov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Companydiff --git a/src/backend/storage/lmgr/lmgr.c b/src/backend/storage/lmgr/lmgr.c
index 7b08555..d0fdb94 100644
--- a/src/backend/storage/lmgr/lmgr.c
+++ b/src/backend/storage/lmgr/lmgr.c
@@ -268,7 +268,7 @@ UnlockRelation(Relation relation, LOCKMODE lockmode)
 /*
  *		LockHasWaitersRelation
  *
- * This is a functiion to check if someone else is waiting on a
+ * This is a function to check if someone else is waiting on a
  * lock, we are currently holding.
  */
 bool

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo Patch

2016-07-05 Thread Alvaro Herrera 
CharSyam wrote:
> Yes, Some typos problems, It is hard to figure them out.
> But in this patch, guranteed is just misspelling of guaranteed.

I agree with Robert: the sentence as a whole makes no sense:

 * We need to check all possible distances, so reset Lpos
 * to guaranteed not yet satisfied position.

It's hard to justify changing a single character when what we should be
doing is rewriting the comment completely.

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo Patch

2016-07-05 Thread David G. Johnston 
On Tue, Jul 5, 2016 at 11:54 AM, Robert Haas  wrote:

> On Sat, Jul 2, 2016 at 12:17 PM, CharSyam  wrote:
> > I fixed typos. and attached patch for this.
> > Thanks.
> >
> > I only changed comments only in src/backend/utils/adt/tsvector_op.c
>
> Well, that's definitely a typo.  However, typo or no typo, it's hard
> for me to figure out with any certainty what that sentence actually
> means.
>
​​

Given that "curitem->qoperator.​distance" is constant.

Also, both loops go from low to high position (over the same scale)  with
the inner loop stopping as soon as it moves beyond the position of the
outer loop - namely that the left/inner item is always positioned to the
left of the right/outer operand within the document being search.

Regardless of whether there is a match at this meeting point increasing the
outer loop's position will not cause any of the previously checked (at the
lower positions) inner loop items to match where they did not before.  I
say this but I'm concerned that for sufficiently large values of
curitem->qoperator.distance a given left operand could match multiple right
operands since the distance is a maximum extent.

Thus, in the case of a match the current Lpos needs to be checked again
during the subsequent iterator of the outer loop.

The "else if (Rpos - Lpos < distance) break" block though is oddly
commented/written since distance is a maximum - shouldn't this be treated
as a match as well?

Since, for sufficiently large values of "distance", a single left operand
could cause multiple right operands to be matched when the less-than
condition matches we need to leave Lpos alone and try the next Rpos against
it.  For the greater than (default) and the equal cases we can skip
rechecking the current Lpos.

The comment in question can be removed - we're not actually resetting
anything here.  The use of LposStart is not really needed - just make sure
to leave Lpos in the correct position (i.e. optional increment on all
paths) and the inner while loop will do the correct thing.

It seems a bit odd to be keying off of the RIGHT operand and returning its
position when left-to-right languages would consider the position of the
leading word to be reported.

Code Comment Suggestion:

For each physically positioned right-side operand iterate over each
instance of the left-side operand to locate one within the specified
distance.  As soon as a match is found move onto the next right-operand and
continue searching starting with the last checked left-side operand.  Note
that for an exact distance match the current left-side operand can be
skipped over.

For some graphical imagery consider how a Slinky operates.  Hold the left
side, move the right side, release the left and let it collapse; repeat.
In this case, though, the collapsing can be stopped mid-stream since the
distance check has an inequality.

The following shouldn't be taken as an actual patch submission but rather a
codification of the above.

diff --git a/src/backend/utils/adt/tsvector_op.c
b/src/backend/utils/adt/tsvector_op.c
index 242b7e1..fefaca5 100644
--- a/src/backend/utils/adt/tsvector_op.c
+++ b/src/backend/utils/adt/tsvector_op.c
@@ -1375,7 +1375,6 @@ TS_phrase_execute(QueryItem *curitem,
  ExecPhraseData Ldata = {0, false, NULL},
  Rdata = {0, false, NULL};
  WordEntryPos *Lpos,
-   *LposStart,
*Rpos,
*pos_iter = NULL;

@@ -1423,15 +1422,17 @@ TS_phrase_execute(QueryItem *curitem,
  * ExecPhraseData->data can point to the tsvector's WordEntryPosVector
  */

+ /*
+  * For each physically positioned right-side operand iterate over each
+  * instance of the left-side operand to locate one within the specified
+  * distance.  As soon as a match is found move onto the next right-operand
+  * and continue searching starting with the last checked left-side
operand.
+  * Note that for an exact distance match the current left-side operand
+  * can be skipped over.
+  */
  Rpos = Rdata.pos;
- LposStart = Ldata.pos;
  while (Rpos < Rdata.pos + Rdata.npos)
  {
- /*
- * We need to check all possible distances, so reset Lpos
- * to guranteed not yet satisfied position.
- */
- Lpos = LposStart;
  while (Lpos < Ldata.pos + Ldata.npos)
  {
  if (WEP_GETPOS(*Rpos) - WEP_GETPOS(*Lpos) ==
@@ -1449,7 +1450,7 @@ TS_phrase_execute(QueryItem *curitem,
  * could not satisfy distance for any other right
  * position
  */
- LposStart = Lpos + 1;
+ Lpos++
  break;
  }
  else
@@ -1462,16 +1463,26 @@ TS_phrase_execute(QueryItem *curitem,
  }

  }
- else if (WEP_GETPOS(*Rpos) <= WEP_GETPOS(*Lpos) ||
- WEP_GETPOS(*Rpos) - WEP_GETPOS(*Lpos) <
+ else if (WEP_GETPOS(*Rpos) <= WEP_GETPOS(*Lpos)
+ {
+ /*
+ * No Increment - we are beyond the current right operand
+ * so its possible this left operand could match the
next right
+ * operand.
+ */
+ break;
+ }
+ else if (WEP_GETPOS(*Rpos) - WEP_GETPOS(*Lpos) <
  curitem->qoperator.distance)
  {
+ /*

Re: [HACKERS] Typo Patch

2016-07-05 Thread CharSyam 
Yes, Some typos problems, It is hard to figure them out.
But in this patch, guranteed is just misspelling of guaranteed.

Thanks.

2016-07-06 0:54 GMT+09:00 Robert Haas :

> On Sat, Jul 2, 2016 at 12:17 PM, CharSyam  wrote:
> > I fixed typos. and attached patch for this.
> > Thanks.
> >
> > I only changed comments only in src/backend/utils/adt/tsvector_op.c
>
> Well, that's definitely a typo.  However, typo or no typo, it's hard
> for me to figure out with any certainty what that sentence actually
> means.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [HACKERS] Typo Patch

2016-07-05 Thread Robert Haas 
On Sat, Jul 2, 2016 at 12:17 PM, CharSyam  wrote:
> I fixed typos. and attached patch for this.
> Thanks.
>
> I only changed comments only in src/backend/utils/adt/tsvector_op.c

Well, that's definitely a typo.  However, typo or no typo, it's hard
for me to figure out with any certainty what that sentence actually
means.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel comment of heap_delete()

2016-06-17 Thread Robert Haas 
On Thu, Jun 16, 2016 at 12:32 AM, Thomas Munro
 wrote:
> On Tue, Jun 7, 2016 at 12:00 AM, Robert Haas  wrote:
>> On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby  wrote:
>>> I'm pretty sure this is a typo...
>>
>> Sure is.  Thanks.
>
> The same typo appears in heap_update.

Commited.

> PS Far be it from me, but postgres_fdw.c seems to have a stray
> conditional form where I would expect a present subjunctive:  "...
> lest the new path *would* kick ..."
> /me ducks

Rephrased.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel comment of heap_delete()

2016-06-15 Thread Thomas Munro 
On Tue, Jun 7, 2016 at 12:00 AM, Robert Haas  wrote:
> On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby  wrote:
>> I'm pretty sure this is a typo...
>
> Sure is.  Thanks.

The same typo appears in heap_update.

PS Far be it from me, but postgres_fdw.c seems to have a stray
conditional form where I would expect a present subjunctive:  "...
lest the new path *would* kick ..."
/me ducks

-- 
Thomas Munro
http://www.enterprisedb.com


lest.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in pg_visibility

2016-06-08 Thread Robert Haas 
On Tue, Jun 7, 2016 at 8:45 PM, Amit Langote
 wrote:
> On 2016/06/08 9:38, Amit Langote wrote:
>> Attached fixes a typo:
>>
>> s/PG_ALL_VISIBLE/PD_ALL_VISIBLE/g
>
> Oops.  Made a couple of mistakes there:
>
> Subject: Typo in pg_visibility documentation
> Patch: Really attached this time.

Thanks, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in pg_visibility

2016-06-07 Thread Amit Langote 
On 2016/06/08 9:38, Amit Langote wrote:
> Attached fixes a typo:
> 
> s/PG_ALL_VISIBLE/PD_ALL_VISIBLE/g

Oops.  Made a couple of mistakes there:

Subject: Typo in pg_visibility documentation
Patch: Really attached this time.

Thanks,
Amit
diff --git a/doc/src/sgml/pgvisibility.sgml b/doc/src/sgml/pgvisibility.sgml
index cdd6a6f..48b003d 100644
--- a/doc/src/sgml/pgvisibility.sgml
+++ b/doc/src/sgml/pgvisibility.sgml
@@ -29,7 +29,7 @@
  
 
  
-  Functions which display information about PG_ALL_VISIBLE
+  Functions which display information about PD_ALL_VISIBLE
   are much more costly than those which only consult the visibility map,
   because they must read the relation's data blocks rather than only the
   (much smaller) visibility map.

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in parallel comment of heap_delete()

2016-06-06 Thread Robert Haas 
On Sun, Jun 5, 2016 at 4:39 PM, Jim Nasby  wrote:
> I'm pretty sure this is a typo...

Sure is.  Thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in nbtree.h

2016-06-02 Thread Kevin Grittner 
On Wed, Jun 1, 2016 at 4:08 PM, Thomas Munro
 wrote:

> Maybe it should be like this?
>
> --- a/src/include/access/nbtree.h
> +++ b/src/include/access/nbtree.h
> @@ -522,7 +522,7 @@ typedef struct BTScanPosData
> Buffer  buf;/* if valid, the
> buffer is pinned */
>
> XLogRecPtr  lsn;/* pos in the WAL
> stream when page was read */
> -   BlockNumber currPage;   /* page we've referencd by
> items array */
> +   BlockNumber currPage;   /* page referenced by items array */
> BlockNumber nextPage;   /* page's right link when we
> scanned it */
>
> /*

I agree.  Pushed.

Thanks!

-- 
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in 001_initdb.pl

2016-05-23 Thread Stephen Frost 
* Michael Paquier (michael.paqu...@gmail.com) wrote:
> On Mon, May 23, 2016 at 5:05 PM, Tom Lane  wrote:
> > Michael Paquier  writes:
> >> I just bumped into the following typo for $subject:
> >> -   'role names cannot being with "pg_"');
> >> +   'role names cannot begin with "pg_"');
> >
> > Pushed, thanks.
> 
> Thanks.

Thanks from me also, I had been planning to fix this, but got caught up
with something else this evening.

Stephen


signature.asc
Description: Digital signature

Re: [HACKERS] Typo in 001_initdb.pl

2016-05-23 Thread Michael Paquier 
On Mon, May 23, 2016 at 5:05 PM, Tom Lane  wrote:
> Michael Paquier  writes:
>> I just bumped into the following typo for $subject:
>> -   'role names cannot being with "pg_"');
>> +   'role names cannot begin with "pg_"');
>
> Pushed, thanks.

Thanks.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in 001_initdb.pl

2016-05-23 Thread Tom Lane 
Michael Paquier  writes:
> I just bumped into the following typo for $subject:
> -   'role names cannot being with "pg_"');
> +   'role names cannot begin with "pg_"');

Pushed, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo

2016-04-29 Thread Magnus Hagander 
On Fri, Apr 29, 2016 at 1:37 PM, Thomas Munro  wrote:

> Hi,
>
> Here is a patch to fix a typo in dsm_impl.h.
>

Applied, thanks.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in execProcnode.c documentation

2016-04-26 Thread Magnus Hagander 
On Tue, Apr 26, 2016 at 10:34 AM, Daniel Gustafsson  wrote:

> Theres a tiny typo in the EXAMPLE section of the documentation in
> execProcnode.c:
>
> - *  their work to the appopriate node support routines which may
> + *  their work to the appropriate node support routines which may
>


Applied, thanks.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in src/interfaces/libpq/fe-connect.c

2016-04-05 Thread Magnus Hagander 
On Tue, Apr 5, 2016 at 10:34 AM, Etsuro Fujita 
wrote:

> Hi,
>
> I ran into a typo in src/interfaces/libpq/fe-connect.c:
> s/PQcancelGet/PQgetCancel/  Attached is a patch to fis that typo.
>

Applied, thanks.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in comment

2016-03-28 Thread Robert Haas 
On Sat, Mar 26, 2016 at 4:21 PM, Thomas Munro
 wrote:
> Here are a couple of patches to fix a typo in a comment in latch.c:
>
> - * The memory barrier has be to be placed here to ensure that any flag
> + * The memory barrier has to be placed here to ensure that any flag

Committed, but it hardly seems worth back-patching.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in monitoring.sgml

2016-03-18 Thread Robert Haas 
On Wed, Mar 16, 2016 at 1:38 AM, Amit Langote  wrote:

> Attached fixes a minor typo as follows:
>
> s/index vacuums cycles/index vacuum cycles/g
>

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [HACKERS] Typo in logicaldecoding docs

2016-03-07 Thread Tom Lane 
David Rowley  writes:
> The attached fixes a small error in the logicaldecoding docs.

Pushed, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in psql-ref.sgml

2016-03-06 Thread Magnus Hagander 
On Sun, Mar 6, 2016 at 9:38 AM, Guillaume Lelarge 
wrote:

> Hi,
>
> While translating the 9.5 ref/psql-ref.sgml, I found this:
>
> and variables shows help about about
> psql configuration variables
>
> The word "about" is written twice. Sounds like a nice typo to me :)
>
> See attached patch (for 9.5 and HEAD).
>
>
Yeah, not only was it written twice, it was written twice twice :)

Applied! Thanks!

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Re: [HACKERS] Typo in comment

2016-03-04 Thread Robert Haas 
On Fri, Mar 4, 2016 at 2:39 PM, Thomas Munro
 wrote:
> Here is a patch to fix a typo in a comment in timestamp.c.

That looks like a typo, all right.  Committed.

(It's "commit small patches day" for me today, in case anybody hasn't
caught on to that already...)

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo fix

2016-02-29 Thread Tom Lane 
Amit Langote  writes:
> Attached fixes a typo:

Pushed, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-22 Thread Bruce Momjian 
On Sat, Feb 20, 2016 at 01:55:55PM +0530, Robert Haas wrote:
> On Fri, Feb 19, 2016 at 7:20 PM, Andres Freund  wrote:
> > On February 19, 2016 2:42:08 PM GMT+01:00, Tom Lane  
> > wrote:
> >>> I think we should fix it, but not backpatch.
> >>
> >>I don't think that's particularly good policy.  It's a clear bug, why
> >>would we not fix it?  Leaving it as-is in the back branches can have
> >>no good effect, and what it does do is create a merge hazard for other
> >>back-patchable bug fixes in the same area.
> >
> > Agreed.
> 
> +1.  I think this is clearly a back-patchable fix.

Fix applied to head and 9.5.

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Roman grave inscription +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-20 Thread Robert Haas 
On Fri, Feb 19, 2016 at 7:20 PM, Andres Freund  wrote:
> On February 19, 2016 2:42:08 PM GMT+01:00, Tom Lane  
> wrote:
>>> I think we should fix it, but not backpatch.
>>
>>I don't think that's particularly good policy.  It's a clear bug, why
>>would we not fix it?  Leaving it as-is in the back branches can have
>>no good effect, and what it does do is create a merge hazard for other
>>back-patchable bug fixes in the same area.
>
> Agreed.

+1.  I think this is clearly a back-patchable fix.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-19 Thread Andres Freund 
Hi,

Nice catch!

On February 19, 2016 2:42:08 PM GMT+01:00, Tom Lane  wrote:
>> I think we should fix it, but not backpatch.
>
>I don't think that's particularly good policy.  It's a clear bug, why
>would we not fix it?  Leaving it as-is in the back branches can have
>no good effect, and what it does do is create a merge hazard for other
>back-patchable bug fixes in the same area.

Agreed. Unless somebody beats be to it, I'll do do so in a couple hours (11h 
flight now.

Andres

--- 
Please excuse brevity and formatting - I am writing this on my mobile phone.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-19 Thread Tom Lane 
Simon Riggs  writes:
> I see the problem, but I don't buy the argument that it wastes large
> amounts of memory. Or do you have some evidence that it does?

Agreed, it seems unlikely that that hash table gets large enough for
this to be really significant.  Still ...

> I think we should fix it, but not backpatch.

I don't think that's particularly good policy.  It's a clear bug, why
would we not fix it?  Leaving it as-is in the back branches can have
no good effect, and what it does do is create a merge hazard for other
back-patchable bug fixes in the same area.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-19 Thread Takashi Horikawa 

> I see the problem, but I don't buy the argument that it wastes large amounts
> of memory. Or do you have some evidence that it does?
No. I don’t have any trouble caused by it.
I think I did not mention it wastes 'large' amount of memory but 'a few'.

> I think we should fix it, but not backpatch.
I agree that backpatch is unnecessary.
I hope it will be fixed for the current development version
at some suitable opportunity.

Best regards,
Takashi Horikawa
NEC Corporation
Knowledge Discovery Research Laboratories


> -Original Message-
> From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Simon Riggs
> Sent: Friday, February 19, 2016 6:24 PM
> To: Horikawa Takashi(堀川 隆)
> Cc: PostgreSQL Hackers
> Subject: Re: [HACKERS] Typo in bufmgr.c that result in waste of memory
> 
> On 19 February 2016 at 02:58, Takashi Horikawa <t-horik...@aj.jp.nec.com>
> wrote:
> 
> 
> 
>   I have just found a typo in the source code (not in a comment) of
> bufmgr.c
>   that result in waste of memory. It might be a 'bug' but it does
> not result
>   in any incorrect operation but just results in waste of a few memory
>   resource.
> 
>   As sizeof(PrivateRefCountArray) found in InitBufferPoolAccess()
> is 64 and
>   sizeof(PrivateRefCountEntry) which should be used here is 8, this
> typo
>   produces 56 byte of unused memory area per one PrivateRefCount entry
> in the
>   hash table. I think this result in not only the waste of memory
> but also
>   reduces the cache hit ratio.
> 
>   Xhash_ctl.entrysize = sizeof(PrivateRefCountArray);
>   Ohash_ctl.entrysize = sizeof(PrivateRefCountEntry);
> 
> 
> 
> I see the problem, but I don't buy the argument that it wastes large amounts
> of memory. Or do you have some evidence that it does?
> 
> I think we should fix it, but not backpatch.
> 
> --
> 
> Simon Riggshttp://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



smime.p7s
Description: S/MIME cryptographic signature

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-19 Thread Simon Riggs 
On 19 February 2016 at 02:58, Takashi Horikawa 
wrote:


> I have just found a typo in the source code (not in a comment) of bufmgr.c
> that result in waste of memory. It might be a 'bug' but it does not result
> in any incorrect operation but just results in waste of a few memory
> resource.
>
> As sizeof(PrivateRefCountArray) found in InitBufferPoolAccess() is 64 and
> sizeof(PrivateRefCountEntry) which should be used here is 8, this typo
> produces 56 byte of unused memory area per one PrivateRefCount entry in the
> hash table. I think this result in not only the waste of memory but also
> reduces the cache hit ratio.
>
> Xhash_ctl.entrysize = sizeof(PrivateRefCountArray);
> Ohash_ctl.entrysize = sizeof(PrivateRefCountEntry);
>

I see the problem, but I don't buy the argument that it wastes large
amounts of memory. Or do you have some evidence that it does?

I think we should fix it, but not backpatch.

-- 
Simon Riggshttp://www.2ndQuadrant.com/

PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Typo in bufmgr.c that result in waste of memory

2016-02-18 Thread Amit Kapila 
On Fri, Feb 19, 2016 at 8:28 AM, Takashi Horikawa 
wrote:
>
> Hi all,
>
> I have just found a typo in the source code (not in a comment) of bufmgr.c
> that result in waste of memory. It might be a 'bug' but it does not result
> in any incorrect operation but just results in waste of a few memory
> resource.
>
> As sizeof(PrivateRefCountArray) found in InitBufferPoolAccess() is 64 and
> sizeof(PrivateRefCountEntry) which should be used here is 8, this typo
> produces 56 byte of unused memory area per one PrivateRefCount entry in
the
> hash table. I think this result in not only the waste of memory but also
> reduces the cache hit ratio.
>
> 
> void
> InitBufferPoolAccess(void)
> {
> HASHCTL hash_ctl;
>
> memset(, 0, sizeof(PrivateRefCountArray));
>
> MemSet(_ctl, 0, sizeof(hash_ctl));
> hash_ctl.keysize = sizeof(int32);
> Xhash_ctl.entrysize = sizeof(PrivateRefCountArray);
> Ohash_ctl.entrysize = sizeof(PrivateRefCountEntry);
>
> PrivateRefCountHash = hash_create("PrivateRefCount", 100, _ctl,
>   HASH_ELEM | HASH_BLOBS);
> }
> 
>

Your proposed change seems right to me.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Re: [HACKERS] Typo in pg_rewind.sgml

2015-12-24 Thread Tom Lane 
Michael Paquier  writes:
> I just bumped into the following typo that has been introduced by e50cda7:

Pushed, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in the comment above heap_prepare_freeze_tuple()

2015-12-20 Thread Amit Langote 
On 2015/12/19 2:05, Robert Haas wrote:
> On Fri, Dec 18, 2015 at 1:25 AM, Amit Langote
>  wrote:
>> I think the following may be a typo:
>>
>>   * Caller is responsible for ensuring that no other backend can access the
>>   * storage underlying this tuple, either by holding an exclusive lock on the
>> - * buffer containing it (which is what lazy VACUUM does), or by having it by
>> + * buffer containing it (which is what lazy VACUUM does), or by having it be
>>   * in private storage (which is what CLUSTER and friends do).
>>
>> If so, attached is the patch.
> 
> Committed.

Thanks!

Regards,
Amit





-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in the comment above heap_prepare_freeze_tuple()

2015-12-18 Thread Robert Haas 
On Fri, Dec 18, 2015 at 1:25 AM, Amit Langote
 wrote:
> I think the following may be a typo:
>
>   * Caller is responsible for ensuring that no other backend can access the
>   * storage underlying this tuple, either by holding an exclusive lock on the
> - * buffer containing it (which is what lazy VACUUM does), or by having it by
> + * buffer containing it (which is what lazy VACUUM does), or by having it be
>   * in private storage (which is what CLUSTER and friends do).
>
> If so, attached is the patch.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in file header comment of replorigindesc.c

2015-11-19 Thread Robert Haas 
On Thu, Nov 19, 2015 at 5:04 AM, Amit Langote
 wrote:
> Attached fixes $SUBJECT:
>
> s/replication_origin.c/origin.c/g

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in file header comment of replorigindesc.c

2015-11-19 Thread Andres Freund 
On 2015-11-20 10:25:20 +0900, Amit Langote wrote:
> On 2015/11/20 10:24, Robert Haas wrote:
> > On Thu, Nov 19, 2015 at 5:04 AM, Amit Langote
> >  wrote:
> >> Attached fixes $SUBJECT:
> >>
> >> s/replication_origin.c/origin.c/g
> > 
> > Committed.

Thanks Robert and Amit!


I do wonder however if we shouldn't just get rid of all these comments
at some point. They primarily seem to serve as boilerplate that people
get wrong over the evolution of patches.

Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in file header comment of replorigindesc.c

2015-11-19 Thread Amit Langote 
On 2015/11/20 10:24, Robert Haas wrote:
> On Thu, Nov 19, 2015 at 5:04 AM, Amit Langote
>  wrote:
>> Attached fixes $SUBJECT:
>>
>> s/replication_origin.c/origin.c/g
> 
> Committed.

Thanks!

Amit




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in replorigin_sesssion_origin (9.5+)

2015-10-15 Thread Craig Ringer 
On 14 October 2015 at 21:24, Alvaro Herrera  wrote:
> Craig Ringer wrote:
>> Hi all
>>
>> Before 9.5 goes final, lets change replorigin_sesssion_origin and
>> replorigin_sesssion_origin_lsn to remove the extra 's'.
>
> Hmm?  I already fixed this two weeks ago in
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=aea76d128ad85f38aa0f4255fb9d46d95b835755

Hm, so you did. That's what I get for sitting on patches.

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in replorigin_sesssion_origin (9.5+)

2015-10-14 Thread Alvaro Herrera 
Craig Ringer wrote:
> Hi all
> 
> Before 9.5 goes final, lets change replorigin_sesssion_origin and
> replorigin_sesssion_origin_lsn to remove the extra 's'.

Hmm?  I already fixed this two weeks ago in
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=aea76d128ad85f38aa0f4255fb9d46d95b835755

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in /src/backend/optimizer/README

2015-10-01 Thread Tom Lane 
Etsuro Fujita  writes:
> The following is a remark added to /src/backend/optimizer/README by
> commit 8703059c6b55c427100e00a09f66534b6ccbfaa1, and IIUC, I think "LHS"
> in the last sentence "We prevent that by forcing the min LHS for the
> upper join to include B." should be "RHS".

Mmm, yeah, that's a typo.  Will fix, thanks.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in /src/backend/optimizer/README

2015-10-01 Thread Etsuro Fujita 
On 2015/10/01 22:31, Tom Lane wrote:
> Etsuro Fujita  writes:
>> The following is a remark added to /src/backend/optimizer/README by
>> commit 8703059c6b55c427100e00a09f66534b6ccbfaa1, and IIUC, I think "LHS"
>> in the last sentence "We prevent that by forcing the min LHS for the
>> upper join to include B." should be "RHS".

> Mmm, yeah, that's a typo.  Will fix, thanks.

Thanks!

Best regards,
Etsuro Fujita



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] typo in create policy doc

2015-09-12 Thread Stephen Frost 
Dmitriy,

* Dmitriy Olshevskiy (olshevski...@bk.ru) wrote:
> please check the typo "WTIH CHECK" in CREATE POLICY doc
> 
> (9.5 and devel. version).
> patch is in attachments.

Fixed.

Thanks!

Stephen


signature.asc
Description: Digital signature

Re: [HACKERS] Typo in a comment in set_foreignscan_references

2015-07-29 Thread Robert Haas 
On Tue, Jul 28, 2015 at 3:16 AM, Amit Langote
langote_amit...@lab.ntt.co.jp wrote:
 Attached fixes a minor typo:

 s/custom/foreign/g

Committed, thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in ATPrepChangePersistence

2015-07-29 Thread Heikki Linnakangas 

On 07/29/2015 05:26 AM, Amit Langote wrote:

Attached fixes a typo:

- * no permanent tables cannot reference unlogged ones.
+ * permanent tables cannot reference unlogged ones.


Thanks, fixed.

- Heikki


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in setrefs.c

2015-07-22 Thread Etsuro Fujita 

On 2015/07/21 1:38, Alvaro Herrera wrote:

Etsuro Fujita wrote:

I ran into a typo in a comment in setrefs.c.  Patch attached.


Fixed by Heikki in 7845db2aa.


Thank you for letting me know about that, Alvaro!  And thanks Heikki for 
picking this up!


Best regards,
Etsuro Fujita


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in comment in setrefs.c

2015-07-20 Thread Alvaro Herrera 
Etsuro Fujita wrote:
 I ran into a typo in a comment in setrefs.c.  Patch attached.

Fixed by Heikki in 7845db2aa.




-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training  Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo fix loged vs logged.

2015-06-10 Thread Fujii Masao 
On Wed, Jun 10, 2015 at 1:10 PM, David Rowley
david.row...@2ndquadrant.com wrote:
 The attached fixes a small typo in a comment.

Pushed. Thanks!

-- 
Fujii Masao


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo in tablecmds.c

2015-05-20 Thread Heikki Linnakangas 

On 05/20/2015 12:40 PM, Etsuro Fujita wrote:

The attached patch fixes a typo in a comment in tablecmds.c.


Fixed, along with dozens more similar typos I found with some grepping.

- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Typo patch

2015-05-20 Thread Tom Lane 
Heikki Linnakangas hlinn...@iki.fi writes:
 Thanks, committed. Except for this one:

 - * *Only* a frozen-for-read tape can be seeked.
 + * *Only* a frozen-for-read tape can be sought.

 It's true that the past tense of seek is sought, but it feels a bit 
 weird to me in this context. This is a comment on a function called 
 blah blahseek, and it's not clear to me that it should conjugate 
 like the normal seek verb.

I agree that sought is not the word to use here, but the existing
wording isn't very good English either.  Perhaps Seeking is only allowed
on frozen-for-read tapes?

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

  1   2   >