Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-10-23 Thread thready
Hi Brar, Thanks for sharing your work compiling Postgres with VS2010. I see that there's a patch file you created to fix the files that need fixing to do so, but I don't know how to apply this patch. What's the exe that runs this patch? Will it ask me where the source folder root is when I run

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-10-23 Thread Brar Piening
thready wrote: [...] I don't know how to apply this patch. What's the exe that runs this patch? Will it ask me where the source folder root is when I run it? As the archives seem to be unreachable at the moment I'm copying text from the following message which I would otherwise ask you to

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-07-03 Thread Brar Piening
schrieb Craig Ringer: I'd appreciate it if you'd post the config.pl you're building with, mainly so I can see what libraries and optional features you are or are not using with your test builds. I've already posted it here: http://archives.postgresql.org/message-id/4dcda3cd.4030...@gmx.de

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-07-03 Thread Dave Page
On Sun, Jul 3, 2011 at 8:28 AM, Brar Piening b...@gmx.de wrote: Perhaps someone who routinely does 64-bit builds could help out with a config.pl and some info from where to get the 64-bit libraries to build with. Here's what we use for the installers. # Configuration arguments for vcbuild.

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-06-06 Thread Brar Piening
On Fri, 13 May 2011 23:34:05 +0200, Brar Piening b...@gmx.de wrote: [...] I'd appreciate any reviews, tests or comments. As the current commitfest is getting more and more active recently i've rechecked my patch and updated it for code drift. No real changes. See

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-06-06 Thread Tom Lane
Brar Piening b...@gmx.de writes: On Fri, 13 May 2011 23:34:05 +0200, Brar Piening b...@gmx.de wrote: [...] I'd appreciate any reviews, tests or comments. As the current commitfest is getting more and more active recently i've rechecked my patch and updated it for code drift. No real

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-05-13 Thread Brar Piening
On Sun, 06 Feb 2011 23:06:21 +0100, Brar Piening b...@gmx.de wrote: On Sun, 30 Jan 2011 21:26:22 +0100, Magnus Hagander mag...@hagander.net wrote: it's not something we should hold up the CF / release for. I agree. At least it should get some more testing besides mine. [...] Being somewhat

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-05-13 Thread Robert Haas
On Fri, May 13, 2011 at 5:34 PM, Brar Piening b...@gmx.de wrote: After some months of being able to regularly compile current head using Visual Studio 2010 compilers and some more tests I no longer see any reason why this patch would change without external feedback. You probably want to add

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-05-13 Thread Brar Piening
On Fri, 13 May 2011 21:52:47 -0400, Robert Haas robertmh...@gmail.com wrote: You probably want to add it here, then: https://commitfest.postgresql.org/action/commitfest_view/open I's been in the last commitfest and i've recently moved it to the current one already. See

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-02-09 Thread Magnus Hagander
On Sun, Feb 6, 2011 at 23:06, Brar Piening b...@gmx.de wrote: On Sun, 30 Jan 2011 21:26:22 +0100, Magnus Hagander mag...@hagander.net wrote: it's not something we should hold up the CF / release for. I agree. At least it should get some more testing besides mine. I've set up virtual

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-02-06 Thread Brar Piening
On Sun, 30 Jan 2011 21:26:22 +0100, Magnus Hagander mag...@hagander.net wrote: it's not something we should hold up the CF / release for. I agree. At least it should get some more testing besides mine. I've set up virtual machines with VS 2003, VS 2005 Express, VS 2008 Express (+ my PC with

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-02-03 Thread Robert Haas
On Sun, Jan 30, 2011 at 3:26 PM, Magnus Hagander mag...@hagander.net wrote: Magnus, are you planning to get this committed for 9.1? I'd like to, but I'm not sure I'll have the time. Per the comment from Brar it was intended as an initial attempt not quite ready yet, so it's not something we

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-30 Thread Robert Haas
On Sat, Jan 15, 2011 at 1:42 PM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 3, 2011 at 16:45, Brar Piening b...@gmx.de wrote: On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagander mag...@hagander.net wrote: Yeah, it looks that way - it's missing the ordering of the contrib I'll run

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-30 Thread Magnus Hagander
On Sun, Jan 30, 2011 at 21:06, Robert Haas robertmh...@gmail.com wrote: On Sat, Jan 15, 2011 at 1:42 PM, Magnus Hagander mag...@hagander.net wrote: On Mon, Jan 3, 2011 at 16:45, Brar Piening b...@gmx.de wrote: On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagander mag...@hagander.net wrote:

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-17 Thread Brar Piening
Hi, I initially considered this patch as a primer to start off some basic VS2010 support and not as something to be commited within the next few commitfests. As there seems to be at least some interest in this patch I refactored the code and did some more testing (actually found some weird

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-17 Thread Brar Piening
On Tue, 18 Jan 2011 00:06:10 +0100, Brar Piening b...@gmx.de wrote: So there is now a third version of this patch at http://www.piening.info/VS2010v3.patch Forgot to run perltidy on it - fixed in http://www.piening.info/VS2010v4.patch Sorry! Brar -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-15 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 16:45, Brar Piening b...@gmx.de wrote: On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagander mag...@hagander.net wrote: Yeah, it looks that way - it's missing the ordering of the contrib I'll run it once for that now, and then please rebase your patch on top of that -

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-15 Thread Andrew Chernow
On 1/15/2011 1:42 PM, Magnus Hagander wrote: On Mon, Jan 3, 2011 at 16:45, Brar Pieningb...@gmx.de wrote: On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagandermag...@hagander.net wrote: Yeah, it looks that way - it's missing the ordering of the contrib I'll run it once for that now, and then

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-05 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 16:45, Brar Piening b...@gmx.de wrote: On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagander mag...@hagander.net wrote: Yeah, it looks that way - it's missing the ordering of the contrib I'll run it once for that now, and then please rebase your patch on top of that -

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-05 Thread Andrew Dunstan
On 01/05/2011 12:33 PM, Magnus Hagander wrote: It's actually the same patch as before with the corrupted line-endings parsed out. git diff master VS2010 ../VS2010.patch reproduceabyl generates those on my (windows) system when I use git-external-diff configured as described in

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-05 Thread Robert Haas
On Wed, Jan 5, 2011 at 12:59 PM, Andrew Dunstan and...@dunslane.net wrote: I've abandoned the use of an external diff program for git. If I need context diffs I produce them by piping normal git diff output through filterdiff --format=context. One possible disadvantage of that it strips out

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-05 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: diff --git a/src/backend/commands/alter.c b/src/backend/commands/alter.c index 6a9b21d..1c6ae02 100644 I actually haven't figured out exactly under what circumstances that I think it's for git am -3

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-03 Thread Magnus Hagander
On Mon, Jan 3, 2011 at 08:19, Brar Piening b...@gmx.de wrote: Hi, i'v created a patch enables support for building PostgreSQL with Visual Studio 2010 or Microsoft Windows SDK for Windows 7 and .NET Framework 4 (Windows SDK 7.1). You can grab it from http://www.piening.info/VS2010.patch This

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-03 Thread Brar Piening
Original-Nachricht Datum: Mon, 3 Jan 2011 10:44:19 +0100 Von: Magnus Hagander mag...@hagander.net An: Brar Piening b...@gmx.de CC: pgsql-hackers@postgresql.org Betreff: Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support This patch does not apply at all to my

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-03 Thread Andrew Dunstan
On 01/03/2011 06:26 AM, Brar Piening wrote: No that was probably all. My patch - fixed as described above - should apply to your repository once you've run perltidy. I'll rebase the patch as soon as I return from work unless you tell me otherwise. Please, this time let's backpatch the

Re: [HACKERS] Visual Studio 2010/Windows SDK 7.1 support

2011-01-03 Thread Brar Piening
On Mon, 3 Jan 2011 10:44:19 +0100, Magnus Hagander mag...@hagander.net wrote: Yeah, it looks that way - it's missing the ordering of the contrib I'll run it once for that now, and then please rebase your patch on top of that - makes it easier to review it. The rebased patch can be grabbed from