Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-04 Thread Michael Paquier
On Sat, Apr 4, 2015 at 6:21 AM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Peter Eisentraut pete...@gmx.net writes: These warnings also happen with older versions of clang. Now idea how to fix yet. I'm thinking that clang should be fixed, because these warnings are stupid. Yeah, they're

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-04 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Sat, Apr 4, 2015 at 6:21 AM, Tom Lane t...@sss.pgh.pa.us wrote: It occurred to me that maybe we could just turn off this class of warning, and after some experimentation I found out that -Wno-unused-command-line-argument does that, at least

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-03 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 4/3/15 4:02 PM, John Gorman wrote: I am getting compile warnings on OSX 10.10 from clang 6.0: clang: warning: argument unused during compilation: '-pthread' The 5 warnings are where we are making a -dynamiclib and the -pthread argument is not

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-03 Thread Tom Lane
I wrote: Peter Eisentraut pete...@gmx.net writes: These warnings also happen with older versions of clang. Now idea how to fix yet. I'm thinking that clang should be fixed, because these warnings are stupid. Yeah, they're utterly stupid; whoever put them in obviously doesn't have a clue

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-03 Thread Peter Eisentraut
On 4/3/15 4:02 PM, John Gorman wrote: I am getting compile warnings on OSX 10.10 from clang 6.0: clang: warning: argument unused during compilation: '-pthread' The 5 warnings are where we are making a -dynamiclib and the -pthread argument is not necessary: ./src/interfaces/libpq/

Re: [HACKERS] Compile warnings on OSX 10.10 clang 6.0

2015-04-03 Thread John Gorman
I have confirmed that -Wno-unused-command-line-argument suppresses the -pthread warning for clang 6.0 and does not trigger a warning in gcc 4.9. Works for me! John On Fri, Apr 3, 2015 at 5:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: Peter Eisentraut pete...@gmx.net writes: These

Re: [HACKERS] compile warnings in HEAD

2004-08-28 Thread Bruce Momjian
Patch applied. Thanks. --- Philip Warner wrote: At 12:57 AM 27/08/2004, Bruce Momjian wrote: Has this been fixed? In my local files, yes. I've been waiting on the 'set magic_tablespace' code, but patch to fix the

Re: [HACKERS] compile warnings in HEAD

2004-08-26 Thread Bruce Momjian
Has this been fixed? --- Neil Conway wrote: I get the following warnings compiling current sources: /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function `_isIdentChar':

Re: [HACKERS] compile warnings in HEAD

2004-08-26 Thread Philip Warner
At 12:57 AM 27/08/2004, Bruce Momjian wrote: Has this been fixed? In my local files, yes. I've been waiting on the 'set magic_tablespace' code, but patch to fix the warnings only is attached. Philip Warner|

Re: [HACKERS] compile warnings in HEAD

2004-08-23 Thread Philip Warner
At 12:11 PM 24/08/2004, Neil Conway wrote: I get the following warnings compiling current sources: My fault; I'll fix it in the next patch to pg_dump etc. I compare a char to the range \200 through \377. It must always be = \200...at least I assume that's the problem.

Re: [HACKERS] compile warnings

2004-08-03 Thread Joe Conway
Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: In addition to the ecpg warnings mentioned by Tom, I'm also seeing compile warnings wrt plpython: make[3]: Entering directory `/opt/src/pgsql-cvs/pgsql-7.5/src/pl/plpython' gcc -O2 -fno-strict-aliasing -g -Wall -Wmissing-prototypes

Re: [HACKERS] compile warnings

2004-07-01 Thread Joe Conway
Tom Lane wrote: Joe Conway [EMAIL PROTECTED] writes: In file included from /usr/include/python2.3/Python.h:8, from plpython.c:58: /usr/include/python2.3/pyconfig.h:847:1: warning: _POSIX_C_SOURCE redefined In file included from /usr/include/stdio.h:28, from

Re: [HACKERS] compile warnings

2004-07-01 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: In addition to the ecpg warnings mentioned by Tom, I'm also seeing compile warnings wrt plpython: make[3]: Entering directory `/opt/src/pgsql-cvs/pgsql-7.5/src/pl/plpython' gcc -O2 -fno-strict-aliasing -g -Wall -Wmissing-prototypes

Re: [HACKERS] compile warnings on cygwin - make check fails

2003-10-10 Thread Jason Tishler
Andrew, On Fri, Oct 10, 2003 at 12:25:01AM -0400, Andrew Dunstan wrote: WinXP/cygwin/gcc version 3.3.1 (cygming special) XP Home or Pro? What version of Cygwin? gives these tablecmds.c:3528: warning: dereferencing type-punned pointer will break strict-aliasing rules [snip] FWIW, I saw

Re: [HACKERS] compile warnings on cygwin - make check fails

2003-10-10 Thread Andrew Dunstan
Jason Tishler wrote: Andrew, On Fri, Oct 10, 2003 at 12:25:01AM -0400, Andrew Dunstan wrote: WinXP/cygwin/gcc version 3.3.1 (cygming special) XP Home or Pro? What version of Cygwin? XP-HE. I ran a cygwin upgrade last night (to pick up the latest bison and get cygutils - it picked up

Re: [HACKERS] compile warnings on cygwin - make check fails

2003-10-10 Thread Jason Tishler
Andrew, On Fri, Oct 10, 2003 at 08:56:51AM -0400, Andrew Dunstan wrote: Jason Tishler wrote: Are you getting hangs or connection refused errors. The Cygwin PostgreSQL README documents the following issue: [snip] hangs - I have to kill the psql process to continue. This could mean it will

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Neil Conway
On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: tablecmds.c: In function `validateForeignKeyConstraint': tablecmds.c:3546: warning: dereferencing type-punned pointer will break strict-aliasing rules So, what should we do with this? The recommended way to deal with is to put them into a

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Peter Eisentraut
Neil Conway writes: On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: tablecmds.c: In function `validateForeignKeyConstraint': tablecmds.c:3546: warning: dereferencing type-punned pointer will break strict-aliasing rules So, what should we do with this? Rumor has it that many of

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Kurt Roeckx
On Mon, Sep 15, 2003 at 08:09:22PM +0200, Peter Eisentraut wrote: Neil Conway writes: On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: tablecmds.c: In function `validateForeignKeyConstraint': tablecmds.c:3546: warning: dereferencing type-punned pointer will break strict-aliasing

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-15 Thread Patrick Welche
On Mon, Sep 15, 2003 at 08:09:22PM +0200, Peter Eisentraut wrote: Neil Conway writes: On Thu, 2003-09-04 at 13:14, Kurt Roeckx wrote: tablecmds.c: In function `validateForeignKeyConstraint': tablecmds.c:3546: warning: dereferencing type-punned pointer will break strict-aliasing

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-04 Thread Kurt Roeckx
On Wed, Sep 03, 2003 at 10:30:05PM -0400, Tom Lane wrote: tablecmds.c: In function `validateForeignKeyConstraint': tablecmds.c:3546: warning: dereferencing type-punned pointer will break strict-aliasing rules Hm. Got any idea what these are really complaining about? I see no such

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-03 Thread Peter Eisentraut
Neil Conway writes: lex.Int_yy.c:1832: warning: no previous prototype for `Int_yyget_lineno' These are caused by the new flex. Ignore them. tablecmds.c: In function `validateForeignKeyConstraint': tablecmds.c:3546: warning: dereferencing type-punned pointer will break strict-a

Re: [HACKERS] compile warnings in CVS HEAD?

2003-09-03 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: I'm seeing the following with the current CVS code on my Linux dev box: In file included from bootparse.y:340: lex.Int_yy.c:1832: warning: no previous prototype for `Int_yyget_lineno' lex.Int_yy.c:1841: warning: no previous prototype for `Int_yyget_in'

Re: [HACKERS] compile warnings

2003-06-25 Thread Tom Lane
Joe Conway [EMAIL PROTECTED] writes: Other than these 4 warnings, I get a clean compile on Red Hat 9 and 8.0 systems. I see a couple other warnings when building on HPUX, but all are in ecpg: gcc -O1 -Wall -Wmissing-prototypes -Wmissing-declarations -g -fpic

Re: [HACKERS] compile warnings

2003-06-25 Thread Michael Meskes
On Wed, Jun 25, 2003 at 11:22:58AM -0400, Tom Lane wrote: I see a couple other warnings when building on HPUX, but all are in ecpg: The problem is that I do not have access to HP-UX. All my development and testing is done on Linux right now. And on my Debian system I get no warning at all. gcc

Re: [HACKERS] compile warnings

2003-06-25 Thread Tom Lane
Michael Meskes [EMAIL PROTECTED] writes: This is strange. According to my man page snprintf is declared in stdio.h which indeed is included. Where does HP-UX declare snprintf? It doesn't. Were you including our standard config headers, you'd get our standard workarounds for missing

Re: [HACKERS] compile warnings

2003-06-24 Thread Bruce Momjian
Joe Conway wrote: Since we're getting close to a freeze, I thought I'd point out these warnings again: make[4]: Entering directory `/opt/src/pgsql/src/interfaces/ecpg/pgtypeslib' [...] i386-redhat-linux-gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations -fpic

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Neil Conway
Neil Conway [EMAIL PROTECTED] writes: I get the following compiling the current CVS code with gcc 3.1: I also get 4 regression test failures, due to Gavin's improvements to the parser error messages. AFAICT no actual problems, the expected error message strings just needed to be updated.

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Tom Lane
Neil Conway [EMAIL PROTECTED] writes: pg_controldata.c: In function `main': pg_controldata.c:91: warning: `%c' yields only last 2 digits of year in some locales pg_controldata.c:93: warning: `%c' yields only last 2 digits of year in some locales Yeah. I was willing to ignore that while

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Bruce Momjian
OK, I have fixed the first two with the following patch. The second pair Tom has commented on. --- Neil Conway wrote: I get the following compiling the current CVS code with gcc 3.1: ... fe-connect.c: In function

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Bruce Momjian
Yes, very nanny-ish. Not sure how to turn it off. --- Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: pg_controldata.c: In function `main': pg_controldata.c:91: warning: `%c' yields only last 2 digits of year

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Bruce Momjian
I have applied patches to the regression test to fix this. Thanks. --- Neil Conway wrote: Neil Conway [EMAIL PROTECTED] writes: I get the following compiling the current CVS code with gcc 3.1: I also get 4

Re: [HACKERS] compile warnings in CVS

2002-08-17 Thread Tom Lane
I said: Another alternative is char *fmt = %c; ... strftime(..., fmt, ...); which I think will probably defeat gcc's check (haven't tried it though). I tried this, and it did shut up the warning in my local copy of gcc. So I committed it. Does anyone want to argue that