Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-29 Thread Jeevan Ladhe
On Mon, May 29, 2017 at 11:55 PM, Tom Lane wrote: > Jeevan Ladhe writes: > > I have rebased the patch on recent commit. > > Pushed with some further tweaking. > Thanks Tom for taking care of this. Regards, Jeevan Ladhe

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-29 Thread Tom Lane
Jeevan Ladhe writes: > I have rebased the patch on recent commit. Pushed with some further tweaking. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-h

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-29 Thread Jeevan Ladhe
Hi, I have rebased the patch on recent commit. With recent commits, some of the hunks in the v2 patch related to castNode, are not needed. PFA. Regards, Jeevan Ladhe On Sat, May 27, 2017 at 1:16 AM, Jeevan Ladhe wrote: > Hi Ashutosh, > > Thanks for catching this. For now this isn't a problem

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-26 Thread Jeevan Ladhe
Hi Ashutosh, Thanks for catching this. For now this isn't a problem since > generate_partition_qual() is crafting PartitionBoundInfo which it > doesn't use anywhere else. But if the function gets used where the > PartitionBoundSpec is being used somewhere else as well. Yes, this behavior current

Re: [HACKERS] fix side-effect in get_qual_for_list()

2017-05-26 Thread Ashutosh Bapat
On Thu, May 25, 2017 at 3:12 PM, Jeevan Ladhe wrote: > Hi, > > While working on one of the crash reported on default partition for list > partitioning table[1] I found some strange behavior in get_qual_for_list() > while > I tried to call it from the new code I wrote for default partition. > > Aft