Re: [HACKERS] force_not_null option support for file_fdw

2011-09-16 Thread Tom Lane
Shigeru Hanada shigeru.han...@gmail.com writes: (2011/09/09 0:47), Kohei Kaigai wrote: makeString() does not copy the supplied string itself, so it is not preferable to reference NameStr(attr-attname) across ReleaseSysCache(). Oops, fixed. [ I should check some of my projects for this

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-09 Thread Kohei Kaigai
To: Kohei Kaigai Cc: Kohei KaiGai; PostgreSQL-development Subject: Re: [HACKERS] force_not_null option support for file_fdw Thanks for the review, Kaigai-san. (2011/09/09 0:47), Kohei Kaigai wrote: I found one other point to be fixed: On get_force_not_null(), it makes a list of attribute

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-08 Thread Kohei Kaigai
. September 2011 06:19 To: Kohei Kaigai Cc: Kohei KaiGai; PostgreSQL-development Subject: Re: [HACKERS] force_not_null option support for file_fdw (2011/09/05 22:05), Kohei Kaigai wrote: In my usual environment that test passed, but finally I've reproduced the failure with setting $LC_COLLATE

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-08 Thread Shigeru Hanada
Thanks for the review, Kaigai-san. (2011/09/09 0:47), Kohei Kaigai wrote: I found one other point to be fixed: On get_force_not_null(), it makes a list of attribute names with force_not_null option. + foreach (cell, options) + { + DefElem*def = (DefElem *)

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-07 Thread Shigeru Hanada
(2011/09/05 22:05), Kohei Kaigai wrote: In my usual environment that test passed, but finally I've reproduced the failure with setting $LC_COLLATE to es_ES.UTF-8. Do you have set any $LC_COLLATE in your test environment? It is not set in my environment. I checked the behavior of ORDER

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-05 Thread Kohei Kaigai
: [HACKERS] force_not_null option support for file_fdw Thanks for the review. (2011/09/05 3:55), Kohei KaiGai wrote: I tried to review this patch. It seems to me its implementation is reasonable and enough simple. All the works of this patch is pick-up force_not_null option from

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-04 Thread Kohei KaiGai
I tried to review this patch. It seems to me its implementation is reasonable and enough simple. All the works of this patch is pick-up force_not_null option from pg_attribute.attfdwoptions and transform its data structure into suitable form to the existing BeginCopyFrom(). So, I'd almost like to

Re: [HACKERS] force_not_null option support for file_fdw

2011-09-04 Thread Shigeru Hanada
Thanks for the review. (2011/09/05 3:55), Kohei KaiGai wrote: I tried to review this patch. It seems to me its implementation is reasonable and enough simple. All the works of this patch is pick-up force_not_null option from pg_attribute.attfdwoptions and transform its data structure into