Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2014-01-08 Thread taskov
Hello, could you tell me where I can find the latest version of the MERGE PATCH file? I need to use it on PostgreSQL 9.3. I couldn't find it anywhere in git. Regards, Nikolay -- View this message in context:

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-17 Thread Simon Riggs
On Fri, 2010-07-16 at 08:26 +0800, Boxuan Zhai wrote: The merge actions are transformed into lower level queries. I create a Query node for each of them and append them in a newly create List field mergeActQry. The action queries have different command type and specific target list and qual

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-16 Thread Heikki Linnakangas
On 16/07/10 03:26, Boxuan Zhai wrote: PS: Heikki asked me about what the EXPLAIN MERGE ... command will do. Well, I have not test it, but it may through an error or just explain the top plan, since I put the action plans in a new field, which cannot be recognized by old functions. I meant what

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-16 Thread Boxuan Zhai
Hi, For the EXPLAIN MERGE command, I expect it to return a result similar to that of a SELECT command. I think the EXPLAIN command is to show how the tables in a query is scaned and joined. In my design, the merge command will generate a top-level query (and plan) as the main query. It is in

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-16 Thread Heikki Linnakangas
On 16/07/10 12:26, Boxuan Zhai wrote: For the EXPLAIN MERGE command, I expect it to return a result similar to that of a SELECT command. I think the EXPLAIN command is to show how the tables in a query is scaned and joined. In my design, the merge command will generate a top-level query (and

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-15 Thread Boxuan Zhai
Dear Hackers I considered my situation. And I found that I didn't communicate well with you, as makes you have little confidence on my project. Most of the time I just work by myself and not report to you frequently. I always want to finish a solid stage progress before do a submission. This may

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Greg Smith
Boxuan Zhai wrote: I found that people have problems on running my codes, which probably comes from my nonstandard submission format. I can compile, install and initialize postgres in my own machine. The system accepts MERGE command and will throw an error when it runs into the executor, which

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Peter Eisentraut
On mån, 2010-07-12 at 10:04 -0400, Greg Smith wrote: Wasting the time of everyone in the community by sharing code that doesn't mean any of the project guidelines is a very bad idea; please don't do that again. I think it's better to share code that doesn't mean project guidelines and

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Joshua D. Drake
On Mon, 2010-07-12 at 23:28 +0300, Peter Eisentraut wrote: On mån, 2010-07-12 at 10:04 -0400, Greg Smith wrote: Wasting the time of everyone in the community by sharing code that doesn't mean any of the project guidelines is a very bad idea; please don't do that again. I think it's

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Greg Smith
Peter Eisentraut wrote: I think it's better to share code that doesn't mean project guidelines and solicit advice rather than not to share anything. I feel the assumption that code is so valuable that it should be shared regardless of whether it meets conventions is a flawed one for this

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Tom Lane
Greg Smith g...@2ndquadrant.com writes: There is a brief get to know the community period at the beginning of the summer schedule. I think that next year this project would be well served to give each student a small patch to review during that time, as a formal intro to the community

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Robert Haas
On Jul 12, 2010, at 4:16 PM, Greg Smith g...@2ndquadrant.com wrote: I feel the assumption that code is so valuable that it should be shared regardless of whether it meets conventions is a flawed one for this project. There are already dozens, if not hundreds, of useful patch submissions that

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Greg Smith
Tom Lane wrote: Is there a specific period when that's supposed to happen for GSoC students? Can we arrange for a commitfest to be running then The GSoC Community bonding period is described at http://googlesummerofcode.blogspot.com/2007/04/so-what-is-this-community-bonding-all.html and

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-12 Thread Tom Lane
Greg Smith g...@2ndquadrant.com writes: Tom Lane wrote: Is there a specific period when that's supposed to happen for GSoC students? Can we arrange for a commitfest to be running then The GSoC Community bonding period is described at

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-11 Thread Boxuan Zhai
Hi, Thanks for all these feedback. I found that people have problems on running my codes, which probably comes from my nonstandard submission format. I can compile, install and initialize postgres in my own machine. The system accepts MERGE command and will throw an error when it runs into the

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Andres Freund
On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge command in postgres. There is a more detailed instruction in readme. I

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote: On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
David Fetter da...@fetter.org writes: Please find enclosed a patch against git master as of 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but fails on make check. There seem to be about four different comment styles used in this patch, none of which match the project

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Robert Haas
On Jul 10, 2010, at 11:45 AM, Tom Lane t...@sss.pgh.pa.us wrote: David Fetter da...@fetter.org writes: Please find enclosed a patch against git master as of 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but fails on make check. There seem to be about four different comment

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 09:26:38AM -0700, David Fetter wrote: On Sat, Jul 10, 2010 at 11:52:31AM +0200, Andres Freund wrote: On Fri, Jul 09, 2010 at 11:33:04PM -0400, Robert Haas wrote: On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it is that it hasn't touched the interesting part, ie, what happens at execution time. I haven't seen a design for that, which means

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it is that it hasn't touched the interesting part, ie, what happens

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 10:39:02AM -0700, David Fetter wrote: On Sat, Jul 10, 2010 at 01:18:49PM -0400, Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: Though, if the worst problem with this patch is the formatting, we're doing *quite* well. Well, the worst problem with it

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
David Fetter da...@fetter.org writes: By the way, make check fails here with attached initdb.log: creating system views ... FATAL: unrecognized token: false Hm, I'd suspect something fouled up in keyword recognition. Did you do a make clean and rebuild? BTW, this patch is still a few bricks

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Peter Eisentraut
On lör, 2010-07-10 at 09:26 -0700, David Fetter wrote: Please find enclosed a patch against git master as of 7b2668159bb4d0f5177a23d05bf7c2ab00bc0d75. It works up to make, but fails on make check. It looks like this implementation reaches about the same level of parser support as the stuff

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread David Fetter
On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote: David Fetter da...@fetter.org writes: By the way, make check fails here with attached initdb.log: creating system views ... FATAL: unrecognized token: false Hm, I'd suspect something fouled up in keyword recognition. Did you do

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
David Fetter da...@fetter.org writes: On Sat, Jul 10, 2010 at 01:53:53PM -0400, Tom Lane wrote: BTW, this patch is still a few bricks shy of a load, since there's no kwlist.h change and so the new MERGE keyword couldn't possibly be recognized. More generally, I'm wondering why the original

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Andrew Dunstan
Tom Lane wrote: BTW, I notice that that page fails to mention anything about preferred window width. I believe the project standard is to make things readable in an 80-column window --- anyone have an objection to stating that explicitly? No, on the contrary, I'm in favor of stating

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Peter Eisentraut
On lör, 2010-07-10 at 12:45 -0400, Tom Lane wrote: I believe the project standard is to make things readable in an 80-column window --- anyone have an objection to stating that explicitly? Is that what pgindent reformats it to? -- Sent via pgsql-hackers mailing list

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-10 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On lör, 2010-07-10 at 12:45 -0400, Tom Lane wrote: I believe the project standard is to make things readable in an 80-column window --- anyone have an objection to stating that explicitly? Is that what pgindent reformats it to? pgindent tries to

Re: [HACKERS] gSoC - ADD MERGE COMMAND - code patch submission

2010-07-09 Thread Robert Haas
On Fri, Jul 9, 2010 at 10:25 PM, Boxuan Zhai bxzhai2...@gmail.com wrote: Dear All, This is ZHAI BOXUAN, a student of gSoC 2010. My project is to add merge command in postgres. This is the first submission of our codes, which has finished the parser, analyzer and rewriter parts. If you are