Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-09-28 Thread Peter Eisentraut
On 9/25/16 8:06 AM, Ashutosh Sharma wrote: > Hi Peter, > >> I just wanted to update you, I have taken this commit fest entry patch >> to review because I think it will be addresses as part of "Exclude >> additional directories in pg_basebackup", which I'm also reviewing. >> Therefore, I'm not

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-09-25 Thread Ashutosh Sharma
Hi Peter, > I just wanted to update you, I have taken this commit fest entry patch > to review because I think it will be addresses as part of "Exclude > additional directories in pg_basebackup", which I'm also reviewing. > Therefore, I'm not actually planning on discussing this patch further. >

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-09-23 Thread David Steele
On 9/23/16 2:12 PM, Peter Eisentraut wrote: > On 4/26/16 5:02 AM, Ashutosh Sharma wrote: >> Knowing that pg_basebackup always creates an empty directory for >> pg_stat_tmp and pg_replslot in backup location, even i think it would be >> better to handle these directories in such a way that

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-09-23 Thread Peter Eisentraut
On 4/26/16 5:02 AM, Ashutosh Sharma wrote: > Knowing that pg_basebackup always creates an empty directory for > pg_stat_tmp and pg_replslot in backup location, even i think it would be > better to handle these directories in such a way that pg_basebackup > generates an empty directory for

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-26 Thread Ashutosh Sharma
Hi, Knowing that pg_basebackup always creates an empty directory for pg_stat_tmp and pg_replslot in backup location, even i think it would be better to handle these directories in such a way that pg_basebackup generates an empty directory for pg_replslot and pg_stat_tmp if they are symbolic link.

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread David Steele
On 4/14/16 3:01 PM, Andres Freund wrote: > On 2016-04-14 14:55:37 -0400, Robert Haas wrote: >> On Thu, Apr 14, 2016 at 11:12 AM, Andres Freund wrote: >>> On 2016-04-14 13:43:34 +0530, Ashutosh Sharma wrote: I tried performing pg_basebackup after creating a symbolic link

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread David Steele
On 4/14/16 2:55 PM, Robert Haas wrote: > On Thu, Apr 14, 2016 at 11:12 AM, Andres Freund wrote: >> On 2016-04-14 13:43:34 +0530, Ashutosh Sharma wrote: >>> I tried performing pg_basebackup after creating a symbolic link for >>> pg_replslot, pg_stat_tmp, pg_log and pg_clog in

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Andres Freund
On 2016-04-14 14:55:37 -0400, Robert Haas wrote: > On Thu, Apr 14, 2016 at 11:12 AM, Andres Freund wrote: > > On 2016-04-14 13:43:34 +0530, Ashutosh Sharma wrote: > >> I tried performing pg_basebackup after creating a symbolic link for > >> pg_replslot, pg_stat_tmp, pg_log and

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Robert Haas
On Thu, Apr 14, 2016 at 11:12 AM, Andres Freund wrote: > On 2016-04-14 13:43:34 +0530, Ashutosh Sharma wrote: >> I tried performing pg_basebackup after creating a symbolic link for >> pg_replslot, pg_stat_tmp, pg_log and pg_clog in the source directory > > That's not

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Magnus Hagander
On Thu, Apr 14, 2016 at 8:44 PM, Alvaro Herrera wrote: > Magnus Hagander wrote: > > On Thu, Apr 14, 2016 at 8:20 PM, Ashutosh Sharma > > wrote: > > > > > I was just curious to know how would "*pg_basebackup*" behave if we do > > > create a

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Alvaro Herrera
Magnus Hagander wrote: > On Thu, Apr 14, 2016 at 8:20 PM, Ashutosh Sharma > wrote: > > > I was just curious to know how would "*pg_basebackup*" behave if we do > > create a symbolic link for directories other than pg_xlog/pg_tblspc. > > However it is clearly mentioned in

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Magnus Hagander
On Thu, Apr 14, 2016 at 8:20 PM, Ashutosh Sharma wrote: > Hi, > > I was just curious to know how would "*pg_basebackup*" behave if we do > create a symbolic link for directories other than pg_xlog/pg_tblspc. > However it is clearly mentioned in the documentation of

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Ashutosh Sharma
Hi, I was just curious to know how would "*pg_basebackup*" behave if we do create a symbolic link for directories other than pg_xlog/pg_tblspc. However it is clearly mentioned in the documentation of pg_basebackup that if a Symbolic link for the directories other than pg_tblspc and pg_xlog is

Re: [HACKERS] pg_basebackup creates a corrupt file for pg_stat_tmp and pg_replslot on a backup location

2016-04-14 Thread Andres Freund
Hi, On 2016-04-14 13:43:34 +0530, Ashutosh Sharma wrote: > I tried performing pg_basebackup after creating a symbolic link for > pg_replslot, pg_stat_tmp, pg_log and pg_clog in the source directory That's not supported, and I strongly suspect that you're goint to hit more than just this issue.