On Wed, Nov 12, 2014 at 7:05 AM, Jeff Janes wrote:
> On Sat, Nov 1, 2014 at 7:52 AM, Marko Tiikkaja wrote:
>>
>> Hi,
>>
>> I discovered a problem with the lack of MDC handling in the signature info
>> extraction code, so I've fixed that and added a test message. v9 here.
>>
>>
>>
>
> Hi Marko,
>
On Sat, Nov 1, 2014 at 7:52 AM, Marko Tiikkaja wrote:
> Hi,
>
> I discovered a problem with the lack of MDC handling in the signature info
> extraction code, so I've fixed that and added a test message. v9 here.
>
>
>
>
Hi Marko,
I get a segfault when the length of the message is exactly 16308
On Mon, Oct 20, 2014 at 3:32 PM, Marko Tiikkaja wrote:
> Hi,
>
> Here's the rebased patch -- as promised -- in a v7.
>
>
>
Hi Marko,
Using the same script as for the memory leak, I am getting seg faults using
this patch.
24425 2014-10-27 15:42:11.819 PDT LOG: server process (PID 24452) was
t
On Mon, Oct 20, 2014 at 6:27 AM, Marko Tiikkaja wrote:
> I'm guessing there's no need to bump the pgcrypto version to 1.3, since
> there hasn't been a release with the 1.2 version?
>
Yep. One version bump by major release is fine for a contrib module.
--
Michael
Hi,
On 10/17/14, 9:56 PM, Jeff Janes wrote:
This patch needs a rebase now that the armor header patch has been
committed.
Thanks. Will fix that shortly.
I'm guessing there's no need to bump the pgcrypto version to 1.3, since
there hasn't been a release with the 1.2 version?
.marko
--
S
On Mon, Sep 15, 2014 at 4:37 AM, Marko Tiikkaja wrote:
>
> I've changed the patch back to ignore signatures when not using the
> decrypt_verify() functions in the attached.
Hi Marko,
This patch needs a rebase now that the armor header patch has been
committed.
Thanks,
Jeff
On 10/2/14 1:47 PM, Heikki Linnakangas wrote:
I looked at this briefly, and was surprised that there is no support for
signing a message without encrypting it. Is that intentional? Instead of
adding a function to encrypt and sign a message, I would have expected
this to just add a new function fo
I looked at this briefly, and was surprised that there is no support for
signing a message without encrypting it. Is that intentional? Instead of
adding a function to encrypt and sign a message, I would have expected
this to just add a new function for signing, and you could then pass it
an alr
At 2014-09-15 13:37:48 +0200, ma...@joh.to wrote:
>
> I'm not sure we're talking about the same thing.
No, we weren't. I was under the impression that the signatures
could be validated. Sorry for the noise.
-- Abhijit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To mak
On Fri, Sep 12, 2014 at 8:50 AM, Alvaro Herrera
wrote:
> Marko Tiikkaja wrote:
>
> > On 9/8/14 7:30 PM, Jeff Janes wrote:
>
> > >If i understand the sequence here: The current git HEAD is that
> > >pgp_pub_decrypt would throw an error if given a signed and encrypted
> > >message, and earlier vers
(I have't read the patch, or even earlier correspondence in this
thread, so I apologise for just jumping in.)
At 2014-09-12 12:50:45 -0300, alvhe...@2ndquadrant.com wrote:
>
> +1 for ignoring sigs. If somebody want to check sigs, that's a
> separate step.
For what it's worth, although it seems
Marko Tiikkaja wrote:
> On 9/8/14 7:30 PM, Jeff Janes wrote:
> >If i understand the sequence here: The current git HEAD is that
> >pgp_pub_decrypt would throw an error if given a signed and encrypted
> >message, and earlier version of your patch changed that to decrypt the
> >message and ignore t
On 2014-09-08 7:30 PM, Jeff Janes wrote:
On Fri, Sep 5, 2014 at 4:38 AM, Marko Tiikkaja wrote:
I've also changed the behaviour when passing a message with a signature to
the decrypt functions which don't verify signatures. They now report
"ERROR: Wrong key or corrupt data" instead of decrypti
On Fri, Sep 5, 2014 at 4:38 AM, Marko Tiikkaja wrote:
> Hi all,
>
> I've updated the patch with a number of changes:
> 1) I've documented the current limitations of signatures
> 2) I've expanded section F.25.3 to add information about signatures
> (though I'm not sure why this part is in the
On Sun, Sep 7, 2014 at 10:36 AM, Marko Tiikkaja wrote:
> On 2014-09-07 19:28, Jeff Janes wrote:
>
>>
>> select pgp_sym_decrypt(dearmor('-BEGIN PGP MESSAGE-
>> Version: GnuPG v2.0.14 (GNU/Linux)
>> Password: foobar
>>
>> jA0EBwMCqywsAv/hXJ7D0j8BWsD+9H7DY4KhrIIw2oV/6tBueVQ28+VDjBw9rGiy
>> 3
On 2014-09-07 19:28, Jeff Janes wrote:
On Wed, Sep 3, 2014 at 2:13 PM, Marko Tiikkaja wrote:
To sign without encrypting?
To verify signatures of things that are not encrypted. I'm not really
interested in storing private keys in PostgreSQL, just things that can be
done with public keys. (B
On Wed, Sep 3, 2014 at 2:13 PM, Marko Tiikkaja wrote:
> On 2014-09-03 10:33 PM, Jeff Janes wrote:
>
>> On Wed, Sep 3, 2014 at 12:43 PM, Marko Tiikkaja wrote:
>>
>>> Right. This patch only adds support for signing data when encrypting it
>>> at the same time. There's no support for detached sig
On 2014-09-05 1:38 PM, I wrote:
3) I've changed the code to use ntohl() and pg_time_t as per Thomas'
comments.
sig->creation_time = ntohl(*((uint32_t *) creation_time));
This is probably a horrible idea due to strict aliasing rules and
alignment, though. I think I'll just hide the bit
Marko, et al,
This is a review of the pgcrypto PGP signatures patch:
http://www.postgresql.org/message-id/53edbcf0.9070...@joh.to
There hasn't been any discussion, at least that I've been able to find.
Contents & Purpose
==
This patch add functions to create, verify and extract i
On 2014-09-03 10:33 PM, Jeff Janes wrote:
On Wed, Sep 3, 2014 at 12:43 PM, Marko Tiikkaja wrote:
Right. This patch only adds support for signing data when encrypting it
at the same time. There's no support for detached signatures, nor is there
support for anything other than signatures of enc
On Wed, Sep 3, 2014 at 12:43 PM, Marko Tiikkaja wrote:
> On 2014-09-03 9:36 PM, Jeff Janes wrote:
>
>> I wanted to start simple so I have a file which is signed, but not
>> encrypted. I can't figure out what to do with it. All of the functions
>> seem to require that it also be encrypted. I tr
On 2014-09-03 9:36 PM, Jeff Janes wrote:
I wanted to start simple so I have a file which is signed, but not
encrypted. I can't figure out what to do with it. All of the functions
seem to require that it also be encrypted. I tried providing an empty
password for pgp_sym_signatures but it didn'
On Fri, Aug 15, 2014 at 12:55 AM, Marko Tiikkaja wrote:
> Hi,
>
>
> On 8/7/14 12:15 PM, I wrote:
>
>> Here's v2 of the patch. I've changed the info-extracting code to not
>> look for signatures beyond the data, which also meant that it had to
>> parse one-pass signatures (which it didn't do befo
On 09/03/2014 02:51 PM, Joel Jacobson wrote:
On Wed, Aug 6, 2014 at 2:46 PM, Marko Tiikkaja wrote:
Hi hackers,
Attached is a patch to add support for PGP signatures in encrypted messages
into pgcrypto.
I noticed Heikki wanted to check if there is any interested for the
patches in the current
On Wed, Aug 6, 2014 at 2:46 PM, Marko Tiikkaja wrote:
> Hi hackers,
>
> Attached is a patch to add support for PGP signatures in encrypted messages
> into pgcrypto.
I noticed Heikki wanted to check if there is any interested for the
patches in the current commitfest.
Yes, our company Trustly are
On Thu, 2014-08-07 at 12:15 +0200, Marko Tiikkaja wrote:
> On 8/6/14 2:46 PM, I wrote:
> > Attached is a patch to add support for PGP signatures in encrypted
> > messages into pgcrypto.
>
> Here's v2 of the patch. I've changed the info-extracting code to not
> look for signatures beyond the data
On 8/22/14, 2:57 AM, Thomas Munro wrote:
I took a quick look at your patch at
http://www.postgresql.org/message-id/53edbcf0.9070...@joh.to (sorry I
didn't reply directly as I didn't have the message). It applies
cleanly, builds, and the tests pass. I will hopefully have more to
say after I've p
Hi Marko,
I took a quick look at your patch at
http://www.postgresql.org/message-id/53edbcf0.9070...@joh.to (sorry I
didn't reply directly as I didn't have the message). It applies
cleanly, builds, and the tests pass. I will hopefully have more to
say after I've poked at it and understood it bet
28 matches
Mail list logo
