Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-22 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > true, sorry, I have a different wording in first design > > fixed Pushed, thanks! Stephen signature.asc Description: Digital signature

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-18 Thread Pavel Stehule
2014-09-18 12:51 GMT+02:00 Andres Freund : > On 2014-09-18 12:47:25 +0200, Pavel Stehule wrote: > > - output = PageOutput(81, pager); > > + output = PageOutput(87, pager); > > > > fprintf(output, _("List of specially treated variables.\n")); > > > > @@ -364,6 +364,10 @@ helpVariables

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-18 Thread Andres Freund
On 2014-09-18 12:47:25 +0200, Pavel Stehule wrote: > - output = PageOutput(81, pager); > + output = PageOutput(87, pager); > > fprintf(output, _("List of specially treated variables.\n")); > > @@ -364,6 +364,10 @@ helpVariables(unsigned short int pager) >

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-18 Thread Pavel Stehule
Hi Stephen I forgot to fix new enhanced pset help fix attached Regards Pavel 2014-09-12 18:15 GMT+02:00 Pavel Stehule : > > > 2014-09-12 18:09 GMT+02:00 Stephen Frost : > >> * Stephen Frost (sfr...@snowman.net) wrote: >> > * Pavel Stehule (pavel.steh...@gmail.com) wrote: >> > > I though abo

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-12 Thread Pavel Stehule
2014-09-12 18:09 GMT+02:00 Stephen Frost : > * Stephen Frost (sfr...@snowman.net) wrote: > > * Pavel Stehule (pavel.steh...@gmail.com) wrote: > > > I though about it, and we cannot to drop it now. These symbols are > > > necessary, because we don't support line between rows. > > > > > > I am think

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-12 Thread Stephen Frost
* Stephen Frost (sfr...@snowman.net) wrote: > * Pavel Stehule (pavel.steh...@gmail.com) wrote: > > I though about it, and we cannot to drop it now. These symbols are > > necessary, because we don't support line between rows. > > > > I am thinking so 05 patch should be final > > Ok. I'm going to

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-12 Thread Stephen Frost
* Pavel Stehule (pavel.steh...@gmail.com) wrote: > I though about it, and we cannot to drop it now. These symbols are > necessary, because we don't support line between rows. > > I am thinking so 05 patch should be final Ok. I'm going to play with it a bit more but barring issues, should get it

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-12 Thread Pavel Stehule
2014-09-12 8:19 GMT+02:00 Pavel Stehule : > > > 2014-09-12 5:14 GMT+02:00 Stephen Frost : > >> Pavel, >> >> * Pavel Stehule (pavel.steh...@gmail.com) wrote: >> > Any idea, tip how to it? >> >> Attached is what I had been thinking. >> >> Thoughts? >> > > yes, it is better. I didn't understand befor

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-11 Thread Pavel Stehule
2014-09-12 5:14 GMT+02:00 Stephen Frost : > Pavel, > > * Pavel Stehule (pavel.steh...@gmail.com) wrote: > > Any idea, tip how to it? > > Attached is what I had been thinking. > > Thoughts? > yes, it is better. I didn't understand before. I though about it because it allows to design multiline en

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-11 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > Any idea, tip how to it? Attached is what I had been thinking. Thoughts? Thanks! Stephen diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml index aa71674..1d59dce 100644 --- a/doc/src/sg

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-11 Thread Stephen Frost
* Pavel Stehule (pavel.steh...@gmail.com) wrote: > 2014-09-11 16:42 GMT+02:00 Stephen Frost : > > I don't particularly like this (having these fields set in > > refresh_utf8format to hard-coded strings in the function), why not have > > those handled the same as the rest, where the strings themselv

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-11 Thread Pavel Stehule
Hi 2014-09-11 16:42 GMT+02:00 Stephen Frost : > Pavel, > > * Pavel Stehule (pavel.steh...@gmail.com) wrote: > > I removed dynamic allocation and reduced patch size. > > This is certainly better, imv, though there are a couple of minor > issues (extra semi-colons, extraneous whitespace, get_line_

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-11 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > I removed dynamic allocation and reduced patch size. This is certainly better, imv, though there are a couple of minor issues (extra semi-colons, extraneous whitespace, get_line_style was still changed to non-const, even though it doesn't

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-08 Thread Pavel Stehule
Hi I removed dynamic allocation and reduced patch size. What I tested a old unicode style is same as new unicode style. There nothing was changed .. some fields are specified in refresh_utf8format function Regards Pavel 2014-09-08 4:44 GMT+02:00 Stephen Frost : > Pavel, > > * Pavel Stehul

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-09-07 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > 2014-07-23 8:38 GMT+02:00 Tomas Vondra : > > OK, thanks. The new version seems OK to me. > > Thank you I've started looking over the patch and went back through the previous thread about it. For my part, I'm in favor of adding this capab

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-07-23 Thread Pavel Stehule
2014-07-23 8:38 GMT+02:00 Tomas Vondra : > On 23 Červenec 2014, 7:36, Pavel Stehule wrote: > > > > updated version is in attachment > > OK, thanks. The new version seems OK to me. > Thank you Pavel > > Tomas > >

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-07-22 Thread Tomas Vondra
On 23 Červenec 2014, 7:36, Pavel Stehule wrote: > > updated version is in attachment OK, thanks. The new version seems OK to me. Tomas -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-07-22 Thread Pavel Stehule
Hi Tomas 2014-07-22 23:20 GMT+02:00 Tomas Vondra : > On 28.6.2014 21:29, Pavel Stehule wrote: > > Hello > > > > rebase for 9.5 > > > > test: > > \pset linestyle unicode \pset border 2 > > \pset unicode_header_linestyle double > > > > \l > > > > Regards > > > > Pavel > > I did a quick review of th

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-07-22 Thread Tomas Vondra
On 28.6.2014 21:29, Pavel Stehule wrote: > Hello > > rebase for 9.5 > > test: > \pset linestyle unicode \pset border 2 > \pset unicode_header_linestyle double > > \l > > Regards > > Pavel I did a quick review of the patch today: * it applies cleanly to current HEAD (no failures, small offset

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-06-28 Thread Pavel Stehule
Hello rebase for 9.5 test: \pset linestyle unicode \pset border 2 \pset unicode_header_linestyle double \l Regards Pavel 2014-03-11 21:17 GMT+01:00 Pavel Stehule : > Hello > > I had to reduce allowed line style to single or double, because unicode > allows only combination single,double o

Re: [HACKERS] proposal (9.5) : psql unicode border line styles

2014-03-11 Thread Pavel Stehule
Hello I had to reduce allowed line style to single or double, because unicode allows only combination single,double or single,thick postgres=# \l List of databases Name| Owner | Encoding | Collate |Ctype| Access privileges ---+