Re: adt Makefile, was Re: [HACKERS] jsonb and nested hstore
On Fri, Feb 7, 2014 at 1:18 AM, Andrew Dunstan wrote: > > On 02/01/2014 05:20 PM, Andres Freund wrote: >>> >>> diff --git a/src/backend/utils/adt/Makefile >>> b/src/backend/utils/adt/Makefile >>> >index 1ae9fa0..fd93d9b 100644 >>> >--- a/src/backend/utils/adt/Makefile >>> >+++ b/src/backend/utils/adt/Makefile >>> >@@ -32,7 +32,8 @@ OBJS = acl.o arrayfuncs.o array_selfuncs.o >>> > array_typanalyze.o \ >>> > tsquery_op.o tsquery_rewrite.o tsquery_util.o tsrank.o \ >>> > tsvector.o tsvector_op.o tsvector_parser.o \ >>> > txid.o uuid.o windowfuncs.o xml.o rangetypes_spgist.o \ >>> >- rangetypes_typanalyze.o rangetypes_selfuncs.o >>> >+ rangetypes_typanalyze.o rangetypes_selfuncs.o \ >>> >+ jsonb.o jsonb_support.o >> >> Odd, most OBJS lines are kept in alphabetical order, but that doesn't >> seem to be the case here. > > > > This whole list is a mess, and we don't even have all the range_types files > following each other. > > Worth cleaning up? +1. Yes please. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: adt Makefile, was Re: [HACKERS] jsonb and nested hstore
On 02/06/2014 11:38 AM, Alvaro Herrera wrote: Andrew Dunstan wrote: This whole list is a mess, and we don't even have all the range_types files following each other. Worth cleaning up? I'm actually wondering if it might be worth having some subgroups of object files and then combining them into $OBJS. Doesn't the MSVC build stuff parse OBJS definitions? Good point. At least in some cases it does. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: adt Makefile, was Re: [HACKERS] jsonb and nested hstore
Andrew Dunstan wrote: > This whole list is a mess, and we don't even have all the > range_types files following each other. > > Worth cleaning up? > > I'm actually wondering if it might be worth having some subgroups of > object files and then combining them into $OBJS. Doesn't the MSVC build stuff parse OBJS definitions? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: adt Makefile, was Re: [HACKERS] jsonb and nested hstore
Andrew Dunstan writes: > On 02/01/2014 05:20 PM, Andres Freund wrote: >> Odd, most OBJS lines are kept in alphabetical order, but that doesn't >> seem to be the case here. > This whole list is a mess, and we don't even have all the range_types > files following each other. > Worth cleaning up? +1. It's just neatnik-ism, but isn't compulsive neatnik-ism pretty much a job requirement for programmers? It's hard enough dealing with necessary complexities without having to wonder if some seemingly arbitrary choice has hidden meanings. > I'm actually wondering if it might be worth having some subgroups of > object files and then combining them into $OBJS. Nah, let's just alphabetize them and be done. The Makefile has no reason to care about subgroups of those files. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
