Re: [JDBC] driver source code indentation

2001-09-05 Thread Anders Bengtsson
On Tue, 4 Sep 2001, Bruce Momjian wrote: Can people tak a look at that and see if they like it? I will work on astyle to find a format that matches the main code indenting. If you like it, I will indent just after we go beta. Looks great! I only noticed two things that I sort of disliked.

Re: [JDBC] JAVA vs PERL : PERL wins to postgreSQL

2001-09-03 Thread Anders Bengtsson
On Mon, 3 Sep 2001, andy wrote: Hi, I ran a few bench marks on JAVA writing to a postgreSQL table using and found that for the same number of records added to the table as a similar PERL routine the following results : PERL 39 seconds : JAVA 45 Seconds. How did you start the tests?

Re: [JDBC] Status of JDBC test suite?

2001-08-29 Thread Anders Bengtsson
On Wed, 29 Aug 2001, Liam Stewart wrote: Would a brief How-to help? Yes! :) I assume that you're wondering about the JDBC 2 test suite from Sun. I've attached a note that has some detailed instructions on getting the suite to work with PostgreSQL. Rene, do you want to post this on

Re: [JDBC] Status of JDBC test suite?

2001-08-26 Thread Anders Bengtsson
On Sun, 26 Aug 2001, Rene Pijlman wrote: This is probably true, but once you have your environment setup (including a test database, password etc.) its just a matter of typing make check. Would a brief How-to help? Yes! :) Ideally we should be able to extract parts of the test suite that

Re: [JDBC] What needs to be done?

2001-08-01 Thread Anders Bengtsson
On Wed, 1 Aug 2001, Rene Pijlman wrote: Hello, I read in comp.lang.java.databases that help is needed with development of the JDBC driver. Can someone please provide some pointers to what needs to be done? What are the open issues? Is it JDBC 2.0 compliance? PostgreSQL 7.1 support?

Re: [PATCHES] Re: [JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-21 Thread Anders Bengtsson
On Sat, 21 Jul 2001, Bruce Momjian wrote: OK, patch applied. I put the new java files in /core and /test as indicated in the java package header in the source code. Patch applied too. Almost right. :-) EncodingTest.java should go in org/postgresql/test/jdbc2/, not in org/postgresql/test/.

Re: [PATCHES] Re: [JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-19 Thread Anders Bengtsson
On Sun, 15 Jul 2001, Bruce Momjian wrote: I am having trouble applying this patch to the current CVS tree. The majority of changes fail to apply. Can you give me a patch against current CVS or can someone manually merge the changes into CVS and send me a patch? Thanks. Here's a patch

Re: [JDBC] [PATCH] Cleanup of JDBC character encoding

2001-07-13 Thread Anders Bengtsson
On Thu, 12 Jul 2001, Bruce Momjian wrote: Your patch has been added to the PostgreSQL unapplied patches list at: Here is a new version of that patch, with improvements from some feedback I got from Barry Lind. More of the encoding-related logic is moved into the Encoding class and I've added

[JDBC] Re: [PATCH] Cleanup of JDBC character encoding

2001-07-10 Thread Anders Bengtsson
On Mon, 9 Jul 2001, Barry Lind wrote: Anders, I have some issues with this patch. 1) Please don't require the driver to perform yet another round trip to the server to get the database encoding. You changed the following code which accessed the server once at connection creation: [snip]

[JDBC] Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding

2001-07-10 Thread Anders Bengtsson
I have some issues with this patch. 1) Please don't require the driver to perform yet another round trip to the server to get the database encoding. You changed the following code which accessed the server once at connection creation: [snip] 2) I don't like having test specific