Re: [JDBC] Fix DatabaseMetaDataTest in JDBC test suite
Patch applied. Thanks. > Attached is a patch that fixes DatabaseMetaDataTest in the JDBC > driver's test suite. With previous patches applied, this reduces > the number of failures of the test suite from 6 to 4. The patch > fixes the test case itself, rather than the driver. > > Details: > > 1) The driver correctly provided DatabaseMetaData about the sort > order of NULLs. This was confirmed by Peter Eisentraut on > pgsql-hackers. I fixed the test to accept/require the current > behaviour, and made it dependent on the backend version. See > nullsAreSortedAtStart(), nullsAreSortedAtEnd(), > nullsAreSortedHigh() and nullsAreSortedLow(). > > 2) DatabaseMetaData.supportsOrderByUnrelated() correctly > returned true (an ORDER BY clause can contain columns that are > not in the SELECT clause), but the test case required false. > Fixed that. > > 3) Replaced deprecated assert() of junit.framework.TestCase by > assertEquals(), assertTrue() and assertNotNull(). This is > because assert will be a new keyword in Java 1.4. > > 4) Replaced assert(message,false) by the more elegant > fail(message). > > Regards, > Ren? Pijlman <[EMAIL PROTECTED]> [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that your > message can get through to the mailing list cleanly -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://www.postgresql.org/search.mpl
Re: [JDBC] Fix DatabaseMetaDataTest in JDBC test suite
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. > Attached is a patch that fixes DatabaseMetaDataTest in the JDBC > driver's test suite. With previous patches applied, this reduces > the number of failures of the test suite from 6 to 4. The patch > fixes the test case itself, rather than the driver. > > Details: > > 1) The driver correctly provided DatabaseMetaData about the sort > order of NULLs. This was confirmed by Peter Eisentraut on > pgsql-hackers. I fixed the test to accept/require the current > behaviour, and made it dependent on the backend version. See > nullsAreSortedAtStart(), nullsAreSortedAtEnd(), > nullsAreSortedHigh() and nullsAreSortedLow(). > > 2) DatabaseMetaData.supportsOrderByUnrelated() correctly > returned true (an ORDER BY clause can contain columns that are > not in the SELECT clause), but the test case required false. > Fixed that. > > 3) Replaced deprecated assert() of junit.framework.TestCase by > assertEquals(), assertTrue() and assertNotNull(). This is > because assert will be a new keyword in Java 1.4. > > 4) Replaced assert(message,false) by the more elegant > fail(message). > > Regards, > Ren? Pijlman <[EMAIL PROTECTED]> [ Attachment, skipping... ] > > ---(end of broadcast)--- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to [EMAIL PROTECTED] so that your > message can get through to the mailing list cleanly -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup.| Drexel Hill, Pennsylvania 19026 ---(end of broadcast)--- TIP 2: you can get off all lists at once with the unregister command (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])