[PATCHES] YA Cygwin DLLIMPORT patch

2003-11-21 Thread Jason Tishler
The attached patch enables contrib/cube to build cleanly under Cygwin (again). Please consider this patch for the 7.4.1 branch (if there will be one) too. Thanks, Jason -- PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers Fingerprint: 7A73 1405 7F2B E669 C19D 8784 1AFD E4CC

Re: [PATCHES] COMMENT ON mega patch

2003-11-21 Thread Christopher Kings-Lynne
* You were using a bare C string as the amname argument in COMMENT ON OPERATOR CLASS. This won't do because the parse tree is not a valid Node structure; copyObject will fail on it. I inserted makeString() and strVal() calls to fix it. BTW, a simple test to detect uncopiable-parsetree problems

Re: [PATCHES] COMMENT ON mega patch

2003-11-21 Thread Christopher Kings-Lynne
Out of interest, I notice you didn't commit my inv_api.c change to delete comments on LOBs - where did you put it instead? Doh - just answered my own question - elsewhere in the same file. Chris ---(end of broadcast)--- TIP 1: subscribe and

[PATCHES] PATCH: Uninitialized variable usage in contrib/pg_autovacuum

2003-11-21 Thread Craig Boston
Sorry about the cross-post -- I'm not 100% sure which list this should be sent to. I noticed in the 7.4 release that in contrib/pg_autovacuum, args-logfile is not initialized if a log file is not specified on the command line. This causes an immediate segfault on systems that fill allocated