Re: [PATCHES] Initial eventlog support on win32

2004-03-23 Thread Magnus Hagander
Magnus Hagander wrote: The patch mimcs the syslog handling in most cases. It also hijacks the syslog guc variable. I'm less happy about this. In fact the 0 | 1 | 2 for syslog is very hokey anyway. What is more, it is not inconceivable that someone would run syslogd on a Windows

Re: [PATCHES] [pgsql-hackers-win32] win32 open patch for held unlink

2004-03-23 Thread Claudio Natoli
Revised patch, for application to HEAD [open.c destined for src/port] --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see a href=http://www.memetrics.com/emailpolicy.html;http://www.memetrics.com/em

[PATCHES] dollar quoting and pg_dump

2004-03-23 Thread Andrew Dunstan
Here's my attempt, as discussed earlier today. As always, comments welcome. I did provide (and use) a fallback mechanism after all, for the case of a function with a non-empty probin. A few examples from a dump of the regression db: -- -- Name: tg_hub_adjustslots(character, integer,

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Magnus Hagander
Here's a patch implementing the thread method to workaround the bug with socket calls in signal handlers. See details in mail to pgsql-hackers-win32 a couple of minutes ago. Looks ok, but wouldn't it be better placed in pgstat.c? Actually, I don't think so. I considered it,

Re: [PATCHES] Fix for dumoing WITH/WITHOUT oids

2004-03-23 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: /* + * Become the owner of the the given TOC entry object. If + * changes in ownership are not allowed, this doesn't do anything. + */ + static void + _setWithOids(ArchiveHandle *AH, TocEntry *te) Cutting and pasting our comments, are we?

Re: [PATCHES] Fix for dumoing WITH/WITHOUT oids

2004-03-23 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: /* + * Become the owner of the the given TOC entry object. If + * changes in ownership are not allowed, this doesn't do anything. + */ + static void + _setWithOids(ArchiveHandle *AH, TocEntry *te) Cutting and pasting our

Re: [PATCHES] dollar quoting and pg_dump

2004-03-23 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Here's my attempt, as discussed earlier today. As always, comments welcome. I did provide (and use) a fallback mechanism after all, for the case of a function with a non-empty probin. Applied with light editorializing (fallback seemed a weird

Re: [PATCHES] dollar quoting and pg_dump

2004-03-23 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Here's my attempt, as discussed earlier today. As always, comments welcome. I did provide (and use) a fallback mechanism after all, for the case of a function with a non-empty probin. Applied with light

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Claudio Natoli
What I am wondering about now, is where else we need to change? AFAICS, there is (at least?) one signal handler that performs sockets ops, namely Async_NotifyHandler. Actually, I don't think we need to do anything about that one. This signal handler is used in the backend (not

Re: [PATCHES] Updated logging config (was: Initial eventlog support on win32 )

2004-03-23 Thread Neil Conway
On 23-Mar-04, at 4:57 PM, Magnus Hagander wrote: Something about like this? Looks good. One trivial gripe: you need to update psql/tab-complete.c BTW, integrating PostgreSQL with WMI (Windows Management Instrumentation) would be neat, I think:

Re: [PATCHES] default psql to localhost on platforms without unix domain

2004-03-23 Thread Bruce Momjian
Patch applied, with comment added. Thanks. --- Andrew Dunstan wrote: Bruce Momjian wrote: Andrew Dunstan wrote: Also, what is the default connection mode of psql? It should probably be equivalent to -h

Re: [PATCHES] [pgsql-hackers-win32] win32 open patch for held unlink

2004-03-23 Thread Bruce Momjian
Allow unlink/rename of files open by another process on Win32, using a special Win32 open flag FILE_SHARE_DELETE. Patch applied. Thanks. --- Claudio Natoli wrote: Revised patch, for application to HEAD [open.c destined

Re: [PATCHES] Patch for select and APC on win32

2004-03-23 Thread Bruce Momjian
Patch applied. Thanks. I added #ifdef WIN32 around your new postmaster function. --- Magnus Hagander wrote: Hi! Here's a patch implementing the thread method to workaround the bug with socket calls in signal

Re: [PATCHES] listening addresses

2004-03-23 Thread Bruce Momjian
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Second attempt attached. The fatal message now reads no configured listening socket available, but I am not wedded to the wording. I also was not sure how to mark up * in the docs. Reviewed and committed. I found a bunch more