Re: [PATCHES] Run-as-admin warning for win32

2004-05-03 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> Why? If we refuse to run as root on Unix, I do not see an argument for >> being more forgiving on Windows. > I am not sure it is as easy to run as non-admin on Win32 as it is to run > as non-root on Unix. Is it? Ease of use has noth

Re: [PATCHES] ceiling() and power() (SQL2003)

2004-05-03 Thread Christopher Kings-Lynne
Doesn't your patch cause problems with the PostgreSQL ODBC driver which adds ... Well, the odbc driver will be able to drop those functions. Also, Neil's functions will appear in pg_catalog while the odbc ones will be in public, so there won't be a conflict as such. Chris -

Re: [PATCHES] Run-as-admin warning for win32

2004-05-03 Thread Bruce Momjian
Tom Lane wrote: > "Magnus Hagander" <[EMAIL PROTECTED]> writes: > > Previously, postgresql has exited out on Unix when running as root - > > this is a similar check, with the following differences: > > > * We do a ereport(WARNING) instead of exitting out. > > Why? If we refuse to run as root on

Re: [PATCHES] ceiling() and power() (SQL2003)

2004-05-03 Thread Hans-Jürgen Schönig
Neil, Doesn't your patch cause problems with the PostgreSQL ODBC driver which adds ... -- CEILING(num) CREATE OR REPLACE FUNCTION ceiling(numeric) RETURNS numeric AS ' SELECT ceil($1); ' LANGUAGE SQL; -- POWER(num, num) CREATE OR REPLACE FUNCTION power(double precision, double precision) RE

Re: [PATCHES] Run-as-admin warning for win32

2004-05-03 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: > Previously, postgresql has exited out on Unix when running as root - > this is a similar check, with the following differences: > * We do a ereport(WARNING) instead of exitting out. Why? If we refuse to run as root on Unix, I do not see an argument

Re: [PATCHES] smgr cleanup

2004-05-03 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > This patch removes a couple of no-ops. I object to this change. The fact that these modules don't currently need to do anything at commit/abort doesn't mean that they never again will need to. In particular I do not like putting in a blanket assumptio

[PATCHES] Run-as-admin warning for win32

2004-05-03 Thread Magnus Hagander
For review, comments and possible application to HEAD. This code implements a warning when the postmaster is started as a high-privilege account on win32 (administrator or power users). Previously, postgresql has exited out on Unix when running as root - this is a similar check, with the following

Re: [PATCHES] win32 service proposal

2004-05-03 Thread Darko Prenosil
I played a bit with that code. According to Microsoft samples for service managers, errors and events should be logged to eventlog. so I added a function (almost copy of sample service code), it's a messy, but it was enough to see what is happening with the service. After testing it, I have noticed

[PATCHES] smgr cleanup

2004-05-03 Thread Alvaro Herrera
Hackers, This patch removes a couple of no-ops. I'm trying to get rid of unused code that is in the transaction processing path. Unrelated: it also adds an index term to the performance tips chapter. The smgrcommit and smgrabort functions no longer do anything useful so I removed them. We coul

Re: [PATCHES] Run-as-admin warning for win32

2004-05-03 Thread Shachar Shemesh
1. You forgot to check "localsystem", as well as "domain admins". These two have even higher permissions than the ones you test for, and one of them is the default if Postgre ever makes it to become a service. 2. Are you sure "Powerusers" is such a good idea? It's the default for all non-admin u

Re: [PATCHES] mingw regression test fixes

2004-05-03 Thread Bruce Momjian
Peter Eisentraut wrote: > Claudio Natoli wrote: > > Peter, did you mean $host_platform by any chance... as originally > > submitted? I see no use of $build_platform anywhere, and as committed > > this plain fails. > > I meant that $build_platform would be better than `uname`, not that my > word i

Re: [PATCHES] win32 service proposal

2004-05-03 Thread Magnus Hagander
> Spoke about this off-list with Magnus; he's strongly for > stand-alone; I'm fence-sitting. We see that clearly there are > some niceties to having this in the postmaster (one less exe > to build/configure; same install set for win/*nix; etc), but > the downsides include minor impact on the co

[PATCHES] win32 service proposal

2004-05-03 Thread Claudio Natoli
[For review only. Not for committing.] Decided to take a crack at this in the interests of knocking over the remaining TODO win32 items asap. Would appreciate any comments on the code, particularly from win32 people. An obvious missing feature is allowing the service to be registered under a use

Re: [PATCHES] win32: whitespace in dir names, shmem bug

2004-05-03 Thread Magnus Hagander
> > Great to see you caught that. That's one more off my list > of things to > > dig into. > > Are there any not listed here: > http://momjian.postgresql.org/main/writings/pgsql/win32.html > > If so, they probably should be put up. I don't think so. It's mostly sub-issues under the known loca

Re: [PATCHES] win32: whitespace in dir names, shmem bug

2004-05-03 Thread Claudio Natoli
> Great to see you caught that. That's one more off my list of things to > dig into. Are there any not listed here: http://momjian.postgresql.org/main/writings/pgsql/win32.html If so, they probably should be put up. Cheers, Claudio --- Certain disclaimers and policies apply to all email sen

Re: [PATCHES] win32: whitespace in dir names, shmem bug

2004-05-03 Thread Magnus Hagander
> For application to HEAD, following community review. > > sysv_shmem.c patch is to correct a bug that prevents the > postmaster recovering from an unexpected backend termination. Great to see you caught that. That's one more off my list of things to dig into. I expected it was something that ea