Re: [PATCHES] [HACKERS] pg_dump --comment?

2004-06-04 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> What happens in a pg_dump -Fc / pg_restore scenario? > > > So, in non-ascii format, I need to dump a comment record and read it > > back on restore? Yuck. Anyone want to tackle that? > > Yes. Hacking the outpu

Re: [PATCHES] Compiling libpq with VisualC

2004-06-04 Thread Andreas Pflug
The appended patch implements ENABLE_THREAD_SAFETY for win32 compiled with Visual C. Two additional files will supply the needed pthread stuff. There's no SIGPIPE for native win32, so there are some #IFNDEF WIN32 to skip installing a signal handler for this. I'm not sure if this is going to sho

Re: [PATCHES] [HACKERS] pg_dump --comment?

2004-06-04 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> What happens in a pg_dump -Fc / pg_restore scenario? > So, in non-ascii format, I need to dump a comment record and read it > back on restore? Yuck. Anyone want to tackle that? Yes. Hacking the output routines alone is almost never

Re: [PATCHES] Compiling libpq with VisualC

2004-06-04 Thread Bruce Momjian
Patch applied. I didn't realize that file was for win32 _client_ compiles, and I didn't realize it had no pg_config_paths.h. --- Andreas Pflug wrote: > Bruce Momjian wrote: > > >Andreas Pflug wrote: > > > > > >>Bruce Mom

Re: [PATCHES] [HACKERS] pg_dump --comment?

2004-06-04 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > The following patch adds start/stop times for pg_dump and pg_dumpall > > What happens in a pg_dump -Fc / pg_restore scenario? Uh, do those markers not appear in that dump type? I thought they did. I just tried pg_restore -v and whi

Re: [PATCHES] Compiling libpq with VisualC

2004-06-04 Thread Andreas Pflug
Andreas Pflug wrote: The attached patch will create a dummy pg_config_paths.h. Additionally, ENABLE_THREAD_SAFETY is supported by the makefile (but not by the sources, which need some rework) Now including the patch... Regards, Andreas Index: win32.mak ===

Re: [PATCHES] Compiling libpq with VisualC

2004-06-04 Thread Andreas Pflug
Bruce Momjian wrote: Andreas Pflug wrote: Bruce Momjian wrote: fe-connect.c: - pg_config_paths.h isn't available. SYSCONFDIR is already defined so fe-connect.c doesn't need to include that. patch appended This shouldn't be needed anymore. Where is SYSCONFDIR comin