Re: [PATCHES] Tablespace patch review

2004-06-17 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > OK, I have reviewed the patch. I think Tom is doing the same, but I > want to report the things I found. I just came up for air after about two solid days of working on this patch ... had not seen your message before committing it. The good news is tha

Re: [PATCHES] Tablespace patch review

2004-06-17 Thread Christopher Kings-Lynne
I wrote the pg_dump bits, so I guess I can answer these... And about restore, particularly to another machine, what do we do if the tablespace can't be created in the location specified in the dump? The tablespace creation fails, and all objects specified in that tablespace also fail? Seems bad,

Re: [PATCHES] Tablespace patch review

2004-06-17 Thread Bruce Momjian
Bruce Momjian wrote: > Gavin Sherry wrote: > > Attached is an updated patch, fixing a compile error which my compiler > > didn't seem to detect/suffer from and incorporating fixes to problems > > raised by Neil. > > > > Thanks, > > > > Gavin > > OK, I have reviewed the patch. I think Tom is doi

Re: [PATCHES] Nested transactions

2004-06-17 Thread Bruce Momjian
> The problem I see with moving towards supporting savepoints with the > current proposal is with how commit works: > > Consider: > > begin; > insert into foo values (1); > savepoint dammit; > insert into foo values (2); > select foo; > insert into foo values (3); >

Re: [PATCHES] Nested transactions

2004-06-17 Thread Simon Riggs
On Thu, 2004-06-17 at 02:44, Alvaro Herrera wrote: > I don't know what Oracle or other DBMSs expect in this area. Anyone > care to give me a few pointers? If I'm missing something, I want to > know as soon as possible. Without ignoring your other responses, I remain massively impressed SAVE

Re: [PATCHES] Nested transactions

2004-06-17 Thread Barry Lind
Alvaro Herrera wrote: With this in place, implementing SAVEPOINTs the way SQL expects them to work appears to be a very trivial exercise. You may not see it, but a savepoint is just the start of a nested transaction in disguise. Consider: begin; insert into foo values (1); savepoi

[PATCHES] Tablespace patch review

2004-06-17 Thread Bruce Momjian
Gavin Sherry wrote: > Attached is an updated patch, fixing a compile error which my compiler > didn't seem to detect/suffer from and incorporating fixes to problems > raised by Neil. > > Thanks, > > Gavin OK, I have reviewed the patch. I think Tom is doing the same, but I want to report the thi

Re: [PATCHES] Some index entries

2004-06-17 Thread Bruce Momjian
Alvaro Herrera wrote: > On Thu, Jun 17, 2004 at 08:41:14AM -0400, Bruce Momjian wrote: > > > > Patch applied. Thanks. Your documentation changes can be viewed in > > five minutes using links at the bottom of the developer's page, > > http://developer.postgresql.org/index.php. > > Huh, the index

Re: [PATCHES] Some index entries

2004-06-17 Thread Alvaro Herrera
On Thu, Jun 17, 2004 at 08:41:14AM -0400, Bruce Momjian wrote: > > Patch applied. Thanks. Your documentation changes can be viewed in > five minutes using links at the bottom of the developer's page, > http://developer.postgresql.org/index.php. Huh, the index came out empty! And it's not calle

Re: [PATCHES] Some index entries

2004-06-17 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links at the bottom of the developer's page, http://developer.postgresql.org/index.php. --- Alvaro Herrera wrote: > The attached patch

Re: [PATCHES] pg_ctl service integration for WIN32

2004-06-17 Thread Dave Page
> -Original Message- > From: Claudio Natoli [mailto:[EMAIL PROTECTED] > Sent: 17 June 2004 02:00 > To: Dave Page; Claudio Natoli; [EMAIL PROTECTED] > Subject: RE: [PATCHES] pg_ctl service integration for WIN32 > > > Dave Page writes: > > Looks OK to me at a quick glance. One thought t