Re: [PATCHES] [COMMITTERS] pgsql-server: Have \dn+ show permissions and description

2004-07-14 Thread Bruce Momjian
Christopher Kings-Lynne wrote: > > With \dp having a schema column, how would we display permissions there? > > > >Access privileges for database "test" > > Schema | Name | Type | Access privileges > > +--+---+--- > > public | test | table | >

Re: [PATCHES] Better fixes for pg_dump bugs

2004-07-14 Thread Christopher Kings-Lynne
Hehe - actually, don't commit this either, I keep finding more and more bugs in pg_dump... Chris Christopher Kings-Lynne wrote: OK, This dump is a proper fix for the three bugs mentioned in the first email. It now just outputs an ALTER USER command for the cluster owner and has nothing to do with

Re: [PATCHES] add missing options to pg_dumpall

2004-07-14 Thread Christopher Kings-Lynne
Hmmm, and I need to resurrect the -X use-set-session-authorization flag for pg_dumpall as well...patch coming soon... Chris Stefan Kaltenbrunner wrote: Bruce Momjian wrote: Patch applied. Thanks. thanks - that's wonderful news :-) However the patch as it went in has a minor cosmetic issues with

[PATCHES] Patch for pg_dump: Multiple -t options and new -T option

2004-07-14 Thread David F. Skoll
Attached is a patch against pg_dump version 7.4.3 that permits multiple "-t" switches so that you can select more than one table (but less than all) to dump. It also adds a "-T" switch (long name "--exclude-table") that says *not* to dump a specific table. So: pg_dump -t table1 -t table2

Re: [PATCHES] [subxacts] Savepoint syntax

2004-07-14 Thread Simon Riggs
On Wed, 2004-07-14 at 20:03, Alvaro Herrera wrote: > So I have dropped the idea of the propietary syntax. This patch > implements proper savepoint syntax. Includes regression tests but no > documentation is provided yet. Excellent. Thank you very much for your efforts. Many thanks, Simon Riggs

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-14 Thread Simon Riggs
On Wed, 2004-07-14 at 16:00, Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I think it's really important to get this right the first time, both for > >> reliability's sake and because we are expecting people to write their > >> own archiving scripts. If we ch

[PATCHES] plperl win32

2004-07-14 Thread Magnus Hagander
Here is a patch required to build plperl with win32. The issues were: * perl_useshrplib gets set to "yes" and not to "true". I assume it's set to "true" on unix, so I left both. * Need to translate backslashes into slashes * The linker config coming out of perl was for MSVC and not for mingw Som

Re: [PATCHES] serverlog rotation/functions

2004-07-14 Thread Andreas Pflug
Bruce Momjian wrote: Also there are no documenttion changes. Here are the missing docs, freshly created against cvs. Regards, Andreas Index: func.sgml === RCS file: /projects/cvsroot/pgsql-server/doc/src/sgml/func.sgml,v retrieving rev

Re: [PATCHES] add missing options to pg_dumpall

2004-07-14 Thread Stefan Kaltenbrunner
Bruce Momjian wrote: Patch applied. Thanks. thanks - that's wonderful news :-) However the patch as it went in has a minor cosmetic issues with the display of the --help output. Maybe something like the attached patch should be applied to restore the alphabetical option ordering and make the out

Re: [PATCHES] build infrastructure for extensions v3

2004-07-14 Thread Peter Eisentraut
Fabien COELHO wrote: > Dear patchers, > > Please find attached version number 3 for a patch to enable > extensions such as contribs or external add-ons to be installed > simply with an already installed postgresql. OK, I think we're getting somewhere. I am still opposed to adding more targets of

Re: [PATCHES] serverlog rotation/functions

2004-07-14 Thread Andreas Pflug
Tom Lane wrote: That struck me as not only useless but the deliberately hard way to do it. To use that in the real world, you'd have to set up a cron job to trigger the rotation, Still on my radar... which means a lot of infrastructure and privilege; whereas ISTM the point of this feature was to

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-14 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I think it's really important to get this right the first time, both for >> reliability's sake and because we are expecting people to write their >> own archiving scripts. If we change the xlog segment naming convention >> later on, th

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I think that judgment is exactly backward. *Not* having timelines is > >> what will cause serious and possibly fatal mistakes during restore: > >> people will hand the wrong xlog files to restore and the software

Re: [PATCHES] serverlog rotation/functions

2004-07-14 Thread Bruce Momjian
We could make the same adjustments when opening a new log file rather than pipe, no? --- Tom Lane wrote: > I wrote: > > close(2); > > d = dup(p[0]); > > Assert(d == 2); > > Having re-read the pipe(2) man page, o

[PATCHES] Better fixes for pg_dump bugs

2004-07-14 Thread Christopher Kings-Lynne
OK, This dump is a proper fix for the three bugs mentioned in the first email. It now just outputs an ALTER USER command for the cluster owner and has nothing to do with the '-S' switch. It also fixes the other two issues. Chris pg_dump_fixes2.txt.gz Description: application/gunzip -

Re: [PATCHES] serverlog rotation/functions

2004-07-14 Thread Tom Lane
I wrote: > close(2); > d = dup(p[0]); > Assert(d == 2); Having re-read the pipe(2) man page, of course that should be d = dup(p[1]); since it's the writing end of the pipe you want to plug stderr into. BTW, if it wasn't clear: I'd do the same pushup for stdout too, just

Re: [PATCHES] serverlog rotation/functions

2004-07-14 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: >> You'd need the postmaster to create the pipe and then >> re-point its own stdout and stderr at it, but that's doable >> on Unixen at least (I'm less sure about Windows). > Given the issues we've had with stdout/stderr on mingw, I'm not > convinced

Re: [PATCHES] [HACKERS] Is "trust" really a good default?

2004-07-14 Thread Oliver Elphick
On Wed, 2004-07-14 at 05:08, Tom Lane wrote: > Oliver Elphick <[EMAIL PROTECTED]> writes: > > ... > > The point of this explanation is that as Debian maintainer I would have > > to disable any procedures that attempt to edit these conffiles, or at > > least ensure that their operation is under pack

Re: [PATCHES] serverlog rotation/functions

2004-07-14 Thread Magnus Hagander
> > Probably the big thing this program was trying to solve was for the > > server to know the output file name, even with log file > rotation, and > > I don't see a pipe and 'rotatelogs' process really addressing this. > > It could be done. Given the infrastructure we have now, it's > possib

Re: [PATCHES] PITR Archive Recovery plus WIP PITR

2004-07-14 Thread Simon Riggs
On Wed, 2004-07-14 at 05:45, Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I think that judgment is exactly backward. *Not* having timelines is > >> what will cause serious and possibly fatal mistakes during restore: > >> people will hand the wrong xlog files

Re: [PATCHES] Fixes for 3 bugs in pg_dump

2004-07-14 Thread Christopher Kings-Lynne
Actually, i'm not sure that making it respect -S is the right way to go. What we really need is an option that specifies the cluster owner on the new installation. I will revert that part of this patch and resubmit shortly... Chris Christopher Kings-Lynne wrote: This patch fixes the following b