Re: [PATCHES] [pgsql-hackers-win32] win32 random number generator

2005-08-23 Thread Merlin Moncure
Merlin Moncure [EMAIL PROTECTED] writes: Looks like this in lrand48(void): _rand48_seed[1] 1); _rand48_seed[1] 1); ^^ The problem is the shift operator :). Anyways I double checked the results and it works as expected now so here's a patch. I also removed the

Re: [PATCHES] PL/Perl embedding string common elements

2005-08-23 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Do you expect turning it on to affect only future compilations? Or should we recompile every function already compiled in the present backend? I can see arguments either way. Yeah, me too. I would definitely expect a change

Re: [PATCHES] [pgsql-hackers-win32] win32 random number generator

2005-08-23 Thread Tom Lane
Merlin Moncure [EMAIL PROTECTED] writes: Merlin Moncure [EMAIL PROTECTED] writes: Looks like this in lrand48(void): _rand48_seed[1] 1); _rand48_seed[1] 1); ^^ The problem is the shift operator :). Ah, missed that completely in looking at the casts. Will fix.

Re: [PATCHES] Win32 unicode vs ICU

2005-08-23 Thread Tom Lane
I looked over the proposed patch a bit and found some problems --- in particular, if I read M$'s documentation about MultiByteToWideChar correctly, they chose an API that fails for zero-length input, and so you gotta program around that. Also, varstr_cmp() cannot assume it gets null-terminated

Re: [PATCHES] Win32 Thread Safety

2005-08-23 Thread Bruce Momjian
Patch applied and file renamed, configure run. Thanks. --- Dave Page wrote: The attached patch updates the thread test program to run stand-alone on Windows. The test itself is bypassed in configure as discussed, and

Re: [PATCHES] enable/disable trigger (Re: Fwd: [HACKERS] Open items)

2005-08-23 Thread Bruce Momjian
Thanks, modified patch applied by Tom, with the addition of a USER triggers only mode. --- Satoshi Nagayasu wrote: The message format for elog() report is cleaned up. -- NAGAYASU Satoshi [EMAIL PROTECTED] diff -cr

[PATCHES] plperl strict mode and associated fixes

2005-08-23 Thread Andrew Dunstan
The attached patch completes (I hope) the work begun by Michael Fuhr in an earlier unapplied patch, and makes strict mode work as recently discussed. I moved the embedded strings out of the calling functions into global macros to try to make the code a little more readable. Unfortunately we

Re: [PATCHES] PL/Perl regression tests with use_strict

2005-08-23 Thread Michael Fuhr
On Sat, Aug 20, 2005 at 01:52:42PM -0600, Michael Fuhr wrote: The attached patch allows the PL/Perl regression tests to pass when use_strict is enabled. I've also attached a variant of plperl_elog.out to account for an elog() message that shows a different line number when run under

Re: [PATCHES] plperl strict mode and associated fixes

2005-08-23 Thread Michael Fuhr
On Tue, Aug 23, 2005 at 09:12:10PM -0400, Andrew Dunstan wrote: The attached patch completes (I hope) the work begun by Michael Fuhr in an earlier unapplied patch, and makes strict mode work as recently discussed. I moved the embedded strings out of the calling functions into global macros

[PATCHES] Work-in-progress referential action trigger timing patch

2005-08-23 Thread Stephan Szabo
Here's my current work in progress for 8.1 devel related to fixing the timing issues with referential actions having their checks run on intermediate states. I've only put in a simple test that failed against 8.0 in the regression patch and regression still passes for me. There's still an

Re: [PATCHES] PL/Perl regression tests with use_strict

2005-08-23 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: Here's an updated version of the PL/Perl regression test patch that works with Andrew Dunstan's strict mode patch, both when use_strict is enabled and when it's disabled. The variant of plperl_elog.out is no longer needed. Actually, the main reason I

Re: [PATCHES] plperl strict mode and associated fixes

2005-08-23 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: Hmmm...even if the plperl custom variable class isn't defined in postgresql.conf, plperl.use_strict springs into existence when the interpreter is initialized: Yes, this is per spec. The custom class concept is only intended to allow you to put things

Re: [PATCHES] PL/Perl regression tests with use_strict

2005-08-23 Thread Michael Fuhr
On Tue, Aug 23, 2005 at 11:58:25PM -0400, Tom Lane wrote: Michael Fuhr [EMAIL PROTECTED] writes: Here's an updated version of the PL/Perl regression test patch that works with Andrew Dunstan's strict mode patch, both when use_strict is enabled and when it's disabled. The variant of

Re: [PATCHES] PL/Perl regression tests with use_strict

2005-08-23 Thread Michael Fuhr
On Tue, Aug 23, 2005 at 10:30:51PM -0600, Michael Fuhr wrote: Global symbol $x requires explicit package name at (eval 3) line 1. If I'm reading the Perl source code correctly (pp_ctl.c), the number following eval comes from a variable named PL_evalseq that's incremented each time it appears