Re: [PATCHES] operator

2006-03-03 Thread Tom Lane
Qingqing Zhou [EMAIL PROTECTED] writes: There might be another usage of tid or . Consider a heap with one middle page is broken, I could save most of my data by doing INSERT INTO aa SELECT * FROM a WHERE ctid '(1000, 1)'; INSERT INTO aa SELECT * FROM a WHERE ctid '(1001, 0)'; Well, not

Re: [PATCHES] INS/UPD/DEL RETURNING for 8.2

2006-03-03 Thread Jonah H. Harris
On 3/2/06, Jonah H. Harris [EMAIL PROTECTED] wrote: On 3/2/06, Tom Lane [EMAIL PROTECTED] wrote: Jonah H. Harris [EMAIL PROTECTED] writes: INSERT/UPDATE/DELETE seem to work fine in normal operation but there is an error with DELETE RETURNING when used through PL/pgSQL. Probably other places

Re: [PATCHES] drop if exists remainder

2006-03-03 Thread Andrew Dunstan
Bruce Momjian wrote: Christopher Kings-Lynne wrote: Here's a first draft patch for DROP ... IF EXISTS for the remaining cases, namely: LANGUAGE, TABLESPACE, TRIGGER OPERATOR CLASS, FUNCTION, AGGREGATE, OPERATOR, CAST and RULE. At what point does this stop being useful and

Re: [PATCHES] tuple count and v3 functions in psql for COPY

2006-03-03 Thread Bruce Momjian
Applied by Tom Lane. Thanks. --- Volkan YAZICI wrote: On Feb 11 11:24, Bruce Momjian wrote: I have updated the patch to match CVS (attached), but am seeing the following regression differences where the COPY error

Re: [PATCHES] drop if exists remainder

2006-03-03 Thread Bruce Momjian
Andrew Dunstan wrote: Chris KL said it should be done for all on the grounds of consistency. But I will happily stop right now if that's not the general view - I'm only doing this to complete something I started. Well, my use-case was to be able to wrap pg_dump -c output in

Re: [PATCHES] [HACKERS] ipcclean in 8.1 broken?

2006-03-03 Thread Bruce Momjian
pgman wrote: Christopher Kings-Lynne wrote: if [ $USER = 'root' -o $LOGNAME = 'root' ] Always fails because even tho $USER is set to 'pgsql' when su'ed, $LOGNAME is still root. This is on FreeBSD 4.9 It seems to work on Linux; apparently there are different behaviors of

Re: [PATCHES] [HACKERS] [DOCS] Online backup vs Continuous backup

2006-03-03 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: Peter Eisentraut wrote: Bruce Momjian wrote: I used your suggestion and renamed online backup to incremental backup, and added a mention that many database vendors call it

Re: [PATCHES] Native-win32 patch

2006-03-03 Thread Bruce Momjian
Patch applied. Thanks. --- Hiroshi Saito wrote: Hi Bruce-san. Some of these progress of me is glad.:-) Please apply it. Thanks. Regards, Hiroshi Saito [ Attachment, skipping... ]

Re: [PATCHES] [PATCH] Prompt for password on Windows platforms

2006-03-03 Thread Bruce Momjian
Updated patch applied. I found a use of /dev/tty in psql for command history that I changed to stderr for Win32. Thanks for the legwork in finding the cause of this bug. Backpatched to 8.1.X and 8.0.X. --- Robert Kinberg

Re: [PATCHES] constant too large in port/gettimeofday

2006-03-03 Thread Bruce Momjian
Patch applied. Thanks. I am a little worried that some of our platforms do not support LL designations, so I applied it only to CVS HEAD. --- Kris Jurka wrote: This patch fixes this warning. gettimeofday.c:35:

Re: [PATCHES] OS X shared memory documentation

2006-03-03 Thread Chris Campbell
On Mar 2, 2006, at 15:32, Bruce Momjian wrote: It seems you are saying that shmmax and shmall must be multiples of 4k, and I added that to the docs. It previously only mentioned shmmax in that regard. That was a typo in my comment before the code (the nutshell descriptions after the code

Re: [PATCHES] constant too large in port/gettimeofday

2006-03-03 Thread Kris Jurka
On Fri, 3 Mar 2006, Bruce Momjian wrote: I am a little worried that some of our platforms do not support LL designations, so I applied it only to CVS HEAD. Yes, this one is probably better. Kris Jurka? src/port/.deps ? src/port/pg_config_paths.h Index: src/port/gettimeofday.c

Re: [PATCHES] [SQL] Interval subtracting

2006-03-03 Thread Mark Dilger
Attached is the new patch. To summarize: - new function justify_interval(interval) - modified function justify_hours(interval) - modified function justify_days(interval) These functions are defined to meet the requirements as discussed in this thread. Specifically: - justify_hours

Re: [PATCHES] [HACKERS] ACCESS EXCLUSIVE LOCK

2006-03-03 Thread Jim C. Nasby
On Fri, Mar 03, 2006 at 08:00:19PM -0700, Michael Fuhr wrote: On Fri, Mar 03, 2006 at 08:47:41PM -0600, Jim C. Nasby wrote: You have a URL for where in the docs it says that? Sounds like it needs to be updated to include TRUNCATE.

Re: [PATCHES] OS X shared memory documentation

2006-03-03 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Chris Campbell wrote: On Mar 2, 2006, at 15:32,

[PATCHES] Fix for /dev/tty on Win32

2006-03-03 Thread Bruce Momjian
I found a better solution to the /dev/tty on Win32. I used 'con' which works fine on Win32 except using the Msys 1.0.10 console, but it is probably the best solution. Can someone test if newer Msys consoles work with this? Added DEVTTY macro for simplicity. Applied to 8.0.X, 8.1.X, and HEAD.

Re: [PATCHES] [HACKERS] ACCESS EXCLUSIVE LOCK

2006-03-03 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Jim C. Nasby wrote: On Fri, Mar 03, 2006 at

Re: [PATCHES] constant too large in port/gettimeofday

2006-03-03 Thread Bruce Momjian
Patch applied. Thanks. --- Kris Jurka wrote: On Fri, 3 Mar 2006, Bruce Momjian wrote: I am a little worried that some of our platforms do not support LL designations, so I applied it only to CVS HEAD. Yes,