Re: [PATCHES] fori stmt with by keyword was:(Re: [HACKERS] for statement,

2006-06-07 Thread Jaime Casanova
On 5/30/06, Bruce Momjian pgman@candle.pha.pa.us wrote: I went to test this patch and got the attached regression failures. Please repair and resubmit. Thanks. did it. sorry for the delay, i was busy this week. -- Atentamente, Jaime Casanova Programming today is a race between software

Re: [PATCHES] [HACKERS] Win32 sysconfig - pg_service.conf

2006-06-07 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: Bruce Momjian said: On Win32, patch applied to return path if GetShortPathName() fails (no short name, path does not exist), rather than returning nothing. What made you choose this rather than GetFullPathName? Sure, we

Re: [PATCHES] [HACKERS] Win32 sysconfig - pg_service.conf

2006-06-07 Thread Bruce Momjian
Andrew Dunstan wrote: What made you choose this rather than GetFullPathName? Sure, we can do that. Does GetFullPathName() work if the path does not exist? yes. see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/fileio/fs/getfullpathname.asp How is it

Re: [PATCHES] [HACKERS] Win32 sysconfig - pg_service.conf

2006-06-07 Thread Andrew Dunstan
Bruce Momjian wrote: How is it different from the path we pass to it? Aren't all those paths full already? If they are then it probably doesn't matter. The reason I don't want to use GetFullPathName() is because on Unix, we just return the specified path, not the full path, so I

Re: [PATCHES] Re [HACKERS]: Still not happy with psql's multiline history behavior

2006-06-07 Thread Bruce Momjian
Conditional history length test removed. --- Bruce Momjian wrote: Also, in this line from psql/mainloop.c: 312 if (scan_result == PSCAN_BACKSLASH history_buf-len != 0) Is the history_buf-len != 0 test

Re: [PATCHES] remove lock protection on HeapTupleSatisfiesVacuum

2006-06-07 Thread Jim C. Nasby
On Wed, Jun 07, 2006 at 09:34:47AM +0800, Qingqing Zhou wrote: Qingqing Zhou [EMAIL PROTECTED] wrote The overall performance improvement might be marginal but why not if it is right. What I cares is the correctness. As I understand, the orginal code puts a shared lock (1) to prevent the

[PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Greg Stark
As described on -hackers this is my work so far adding ADD/DROP INHERITS. It implements the controversial ALTER TABLE table ADD/DROP INHERITS parent syntax that requires making INHERITS a reserved keyword. I haven't seen a clear consensus yet on what the best syntax to use here would be. Also,

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Andrew Dunstan
Greg Stark wrote: As described on -hackers this is my work so far adding ADD/DROP INHERITS. It implements the controversial ALTER TABLE table ADD/DROP INHERITS parent syntax that requires making INHERITS a reserved keyword. I haven't seen a clear consensus yet on what the best syntax to use here

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: We should try very hard to avoid adding new reserved words, IMNSHO. *Especially* ones not sanctioned by the SQL spec. Reserving a word that is not listed as reserved in the standard is really a spec violation, because it means that spec-conforming SQL

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: Andrew Dunstan [EMAIL PROTECTED] writes: We should try very hard to avoid adding new reserved words, IMNSHO. *Especially* ones not sanctioned by the SQL spec. Reserving a word that is not listed as reserved in the standard is really a spec violation,

Re: [PATCHES] ALTER TABLE ADD/DROP INHERITS

2006-06-07 Thread Tom Lane
Greg Stark [EMAIL PROTECTED] writes: I expected that but I haven't seen any agreement on a replacement syntax. The only other one proposed was: ALTER TABLE foo ALTER INHERITS ADD|DROP bar and it received no comments. Should I just assume that's the direction to go if nobody objects? I

Re: [PATCHES] fix minor spelling issues in FAQ

2006-06-07 Thread Bruce Momjian
Robert Treat wrote: Attached patch fixes a couple of spelling mistakes in the FAQ Thanks, applied. -- Bruce Momjian http://candle.pha.pa.us EnterpriseDBhttp://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. + ---(end of

Re: [PATCHES] TODO-Item: full timezone names

2006-06-07 Thread Bruce Momjian
Patch applied. Thanks. --- Joachim Wieland wrote: On Thu, Jun 01, 2006 at 12:35:44PM -0400, Tom Lane wrote: Joachim Wieland [EMAIL PROTECTED] writes: I'm talking about the timetz type that does not carry a date. So

Re: [PATCHES] drop if exists remainder

2006-06-07 Thread Robert Treat
On Saturday 04 March 2006 22:24, David Fetter wrote: On Fri, Mar 03, 2006 at 03:35:24PM -0500, Andrew Dunstan wrote: Bruce Momjian wrote: Christopher Kings-Lynne wrote: What's the consensus on this? Nobody else has chimed in, so I'm inclined to do no more on the gounds of insufficient

Re: [HACKERS] [PATCHES] drop if exists remainder

2006-06-07 Thread Josh Berkus
Tom, What's the consensus on this? Nobody else has chimed in, so I'm inclined to do no more on the gounds of insufficient demand. Let's decide before too much bitrot occurs, though. +1 :) +1 We were talking about this on IRC, and I feel that if we're going to do IF EXISTS for any

Re: [PATCHES] remove lock protection on HeapTupleSatisfiesVacuum

2006-06-07 Thread Qingqing Zhou
Jim C. Nasby [EMAIL PROTECTED] wrote Maybe a comment patch would be in order to prevent future confusion? Not really needed because the buffer/README access rule#1 has already said that ... Regards, Qingqing ---(end of broadcast)--- TIP 5:

[PATCHES] update link / fix spelling error

2006-06-07 Thread Robert Treat
Updates the link for the sql 2003 spec, also fixes a spelling error. -- Robert Treat Build A Brighter Lamp :: Linux Apache {middleware} PostgreSQL Index: FAQ_DEV.html === RCS file: /projects/cvsroot/pgsql/doc/src/FAQ/FAQ_DEV.html,v