Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

2006-07-01 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> So this patch was by no stretch of the imagination ready to apply, >> but you did it anyway. > Right. What is your next question? Perhaps "why is the buildfarm failing" would be appropriate. regards, tom lane

Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

2006-07-01 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I ran pgindent on the tablecmds.c block of code, and cleaned up some > > boolean assignments. There are a few XXX comments still in the code so > > someone should look at those questions and either modify the code or > > remove the co

Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

2006-07-01 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I ran pgindent on the tablecmds.c block of code, and cleaned up some > boolean assignments. There are a few XXX comments still in the code so > someone should look at those questions and either modify the code or > remove the comments. So this patch was

Re: [PATCHES] table/index fillfactor control, try 3

2006-07-01 Thread Bruce Momjian
Patch applied. Thanks. Catalog version updated. --- ITAGAKI Takahiro wrote: > This is the 3rd revised fillfactor patch. > Now, AM specific options are stored in pg_class.reloptions as text[]. > Also, some bugs are fixed.

Re: [PATCHES] ADD/DROPS INHERIT (actually INHERIT / NO INHERIT)

2006-07-01 Thread Bruce Momjian
Patch applied. Thanks. I ran pgindent on the tablecmds.c block of code, and cleaned up some boolean assignments. There are a few XXX comments still in the code so someone should look at those questions and either modify the code or remove the comments. -