Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-20 Thread Tom Lane
"Guillaume Smet" <[EMAIL PROTECTED]> writes: > On Mon, Apr 21, 2008 at 2:28 AM, Tom Lane <[EMAIL PROTECTED]> wrote: >> Applied with revisions --- mostly, supporting configure-time control >> over whether pass-by-value is used. > Do we need buildfarm coverage of these options? Wouldn't hurt, I gue

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-20 Thread Guillaume Smet
On Mon, Apr 21, 2008 at 2:28 AM, Tom Lane <[EMAIL PROTECTED]> wrote: > Applied with revisions --- mostly, supporting configure-time control > over whether pass-by-value is used. Do we need buildfarm coverage of these options? -- Guillaume -- Sent via pgsql-patches mailing list (pgsql-patches

Re: [PATCHES] int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

2008-04-20 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > 4) Your problems with tsearch and timestamp etc raise an interesting problem. >We don't need to mark this in pg_control because it's a purely a run-time >issue and doesn't affect on-disk storage. Just for the record, that's wrong. It's true that

Re: [PATCHES] float4/float8/int64 passed by value with tsearch fixup

2008-04-20 Thread Tom Lane
Zoltan Boszormenyi <[EMAIL PROTECTED]> writes: > I tried to split the previous patch up to see where the tsearch regression > comes from. So, it turned out that: > - float4 conversion is risk free (patch #1) > - float8 conversion is okay, too, if coupled with time[stamp[tz]] conversion > (patc

Re: [PATCHES] Coding standards

2008-04-20 Thread Peter Eisentraut
Alvaro Herrera wrote: > The developer's FAQ is supposed to contain this kind of thing, but I > think it's rather thin on actual details.  (Some time ago it was > proposed to create a "style guide", but people here thought it was a > waste of time and "it will not cover what's really important", so

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > So are you killing V0 for non-integral types? Because if not we should keep > some sacrificial module to the regression tests to use to test for this > problem. Well, we could potentially continue to have, say, the oldstyle geo_distance function used whe

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Zoltan Boszormenyi
Gregory Stark írta: "Tom Lane" <[EMAIL PROTECTED]> writes: BTW, I trolled the contrib files for other v0 functions taking or returning float4 or float8. I found seg_size (fixed it) and a whole bunch of functions in earthdistance. Those use float8 not float4, so they are not broken by this

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > BTW, I trolled the contrib files for other v0 functions taking or > returning float4 or float8. I found seg_size (fixed it) and a whole > bunch of functions in earthdistance. Those use float8 not float4, > so they are not broken by this patch, but that mo

Re: [PATCHES] float4/float8/int64 passed by value with tsearchfixup

2008-04-20 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >>> Tom Lane wrote: Specifically, I think what you missed is that on some platforms C functions pass or return float values differently from similar-sized integer or pointer values (typically, the flo

Re: [PATCHES] Proposed patch - psql wraps at window width

2008-04-20 Thread Bryce Nesbitt
1) "\pset columns XX" should make it clear that's for file output only. 2) There's an extra space, which breaks \pset border 2 717c717 < fputc(' ', fout);; --- > fputc(' ', fout); 842c842 <