[PATCHES] [FIX] Fix for pgxs on darwin and other platforms...

2004-12-16 Thread Sean Chittenden
pgxs on darwin is currently broken. The behavior before was to use -bundle_loader with a bogus directory that didn't exist. It should be using $(DESTDIR)$(bindir) instead of something based off of $(topdir), which appears to not be set correctly either (but that's a different problem). gcc

Re: [PATCHES] [FIX] Fix for pgxs on darwin and other platforms...

2004-12-16 Thread Tom Lane
Sean Chittenden [EMAIL PROTECTED] writes: Which is correct. Can someone please get this into the 8.X release that way pgxs is usable for folks on the darwin platform? It doesn't look like this is broken on other major OSes, but some of the oddball platforms (BeOS, cygwin, and win32) don't

Re: [PATCHES] [FIX] Fix for pgxs on darwin and other platforms...

2004-12-16 Thread Sean Chittenden
Which is correct. Can someone please get this into the 8.X release that way pgxs is usable for folks on the darwin platform? It doesn't look like this is broken on other major OSes, but some of the oddball platforms (BeOS, cygwin, and win32) don't seem to be correct either. I've included a fixes

Re: [PATCHES] [FIX] Fix for pgxs on darwin and other platforms...

2004-12-16 Thread Tom Lane
Sean Chittenden [EMAIL PROTECTED] writes: I don't think so :-(. Didn't you just break building things on a machine where Postgres isn't already installed? Wait, are you suggesting that pgxs is used pre-install? I sure hope not. It isn't, but your patch changes make variables (to wit,

Re: [PATCHES] [FIX] Fix for pgxs on darwin and other platforms...

2004-12-16 Thread Tom Lane
Sean Chittenden [EMAIL PROTECTED] writes: I don't have a patch yet for this yet, but if you'd like, I can fix this problem globally and correctly. The solution is as follows: *) contrib/ should *not* use pgxs and instead should depend on the global makefiles Nope. If we can't use

Re: [PATCHES] [FIX] Fix for pgxs on darwin and other platforms...

2004-12-16 Thread Tom Lane
Sean Chittenden [EMAIL PROTECTED] writes: Attached is the easiest and least intrusive fix. This fixes all scenarios as far as I can tell. -sc Ok, that looks more promising. Patch applied. regards, tom lane ---(end of