Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I hadn't gotten around to reviewing the revised version. > Is it just me or is this happening a lot lately? That security stuff took up a *lot* of time behind the scenes :-( Normality is returning, slowly.

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Andrew Dunstan
Tom Lane wrote: Bruce Momjian writes: Patch applied. Thanks. I hadn't gotten around to reviewing the revised version. Is it just me or is this happening a lot lately? cheers andrew ---(end of broadcast)--- TIP 1: if posting/readin

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Tom Lane
Bruce Momjian writes: > Patch applied. Thanks. I hadn't gotten around to reviewing the revised version. Just to let you know, I'm going to remove the separate header file pgmagic.h and put the macro into fmgr.h as I'd suggested originally. The reason is that the separate file turns the problem

Re: [PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-30 Thread Bruce Momjian
Patch applied. Thanks. --- Martijn van Oosterhout wrote: -- Start of PGP signed section. > Per feedback, here is an updated version. As was pointed out, the prior > version was checking stuff that either changed too often

[PATCHES] [PATCH] Round 2: Magic block for modules

2006-05-08 Thread Martijn van Oosterhout
Per feedback, here is an updated version. As was pointed out, the prior version was checking stuff that either changed too often to be useful or was never going to change at all. The error reporting is cleaned up too, it now releases the module before throwing the error. It now only checks four thi