FAST PostgreSQL wrote:
On Wed, 4 Apr 2007 02:26, Andrew Dunstan wrote:
I am currently doing the following modifications to the patch as per the
review comments.
1. Changing all references to 'sqllog' or 'sql' to 'csvlog' and 'csv'
respectively.
2. Escaping the username and databasename
3. C
On Wed, 4 Apr 2007 02:26, Andrew Dunstan wrote:
I am currently doing the following modifications to the patch as per the
review comments.
1. Changing all references to 'sqllog' or 'sql' to 'csvlog' and 'csv'
respectively.
2. Escaping the username and databasename
3. Constructing the csvlog file
FAST PostgreSQL wrote:
Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
Attached is the completed patch for the COPY-able sql log outputs.
Could you please remove random whitespace changes from this patch?
Done and attached.
Brief review of the CSV aspect only:
a.
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
FA
On Mon, Apr 02, 2007 at 04:27:33PM +, FAST PostgreSQL wrote:
> On Sat, 31 Mar 2007 14:09, you wrote:
> > FAST PostgreSQL wrote:
> > >> Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
> > >>> Attached is the completed patch for the COPY-able sql log outputs.
> > >>
> > >> Could you ple
On Sat, 31 Mar 2007 14:09, you wrote:
> FAST PostgreSQL wrote:
> >> Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
> >>> Attached is the completed patch for the COPY-able sql log outputs.
> >>
> >> Could you please remove random whitespace changes from this patch?
> >
> > Done and attach
Surely your system time is wrong with email dated:
Date: Wed, 4 Apr 2007 18:24:54 +
---
FAST PostgreSQL wrote:
> > Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
> > > Attached is the completed patch
Tom Lane wrote:
> Magnus Hagander <[EMAIL PROTECTED]> writes:
>> Then, it may be just me, but I find code like this:
>> !sqllogFile = fopen(strcat(filename, ".sql"), "a");
>> very hard to read.
>
> Such coding should be rejected out of hand anyway --- can you say
> "buffer overrun"?
I
Magnus Hagander <[EMAIL PROTECTED]> writes:
> Then, it may be just me, but I find code like this:
> ! sqllogFile = fopen(strcat(filename, ".sql"), "a");
> very hard to read.
Such coding should be rejected out of hand anyway --- can you say
"buffer overrun"?
reg
FAST PostgreSQL wrote:
>> Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
>>> Attached is the completed patch for the COPY-able sql log outputs.
>> Could you please remove random whitespace changes from this patch?
>
> Done and attached.
A couple of comments.
First one that's not at al
FAST PostgreSQL wrote:
I have attempted to do a quick review of the code in this patch, I've
not installed or compiled it. However I do have a couple of comments.
Hi,
Attached is the completed patch for the COPY-able sql log outputs. I have
modified my previous WIP patch, incorporating all t
Am Dienstag, 3. April 2007 20:33 schrieb FAST PostgreSQL:
> Attached is the completed patch for the COPY-able sql log outputs.
Could you please remove random whitespace changes from this patch?
--
Peter Eisentraut
http://developer.postgresql.org/~petere/
---(end of broad
12 matches
Mail list logo
