Magnus Hagander [EMAIL PROTECTED] wrote:
So actually an equality test against INT_MAX would be correct. But making
that clear in the comment would probably not be a bad idea :-)
I have applied a fix for this, because it obviously needed fixing
regardless of if it fixes the original issue
So actually an equality test against INT_MAX would be correct. But making
that clear in the comment would probably not be a bad idea :-)
I have applied a fix for this, because it obviously needed fixing
regardless of if it fixes the original issue all the way. Still looking
for
Magnus Hagander wrote:
On Wed, May 02, 2007 at 05:25:39PM -0400, Tom Lane wrote:
Magnus Hagander [EMAIL PROTECTED] writes:
Given this, perhaps the proper approach should instead be to just check
the return value, and go from there? Should be a simple enough patch,
something like the attached.
On Wed, May 02, 2007 at 05:25:39PM -0400, Tom Lane wrote:
Magnus Hagander [EMAIL PROTECTED] writes:
Given this, perhaps the proper approach should instead be to just check
the return value, and go from there? Should be a simple enough patch,
something like the attached.
Tom, can you
ITAGAKI Takahiro wrote:
The attached patch clears up the usage of strxfrm() on Windows. If the
server encoding is UTF-8 and the locale is not C, we should use wcsxfrm()
instead of strxfrm() because UTF-8 locale are not supported on Windows.
We've already have a special version of strcoll() for
Magnus Hagander [EMAIL PROTECTED] writes:
Given this, perhaps the proper approach should instead be to just check
the return value, and go from there? Should be a simple enough patch,
something like the attached.
Tom, can you comment?
Testing against INT_MAX seems like a type pun, or
The attached patch clears up the usage of strxfrm() on Windows. If the
server encoding is UTF-8 and the locale is not C, we should use wcsxfrm()
instead of strxfrm() because UTF-8 locale are not supported on Windows.
We've already have a special version of strcoll() for Windows, but the
usage of
From: ITAGAKI Takahiro [EMAIL PROTECTED]
The attached patch clears up the usage of strxfrm() on Windows. If the
server encoding is UTF-8 and the locale is not C, we should use wcsxfrm()
instead of strxfrm() because UTF-8 locale are not supported on Windows.
We've already have a special version
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
