Re: [PATCHES] Code-Cleanup: char* -> const char*

2007-03-20 Thread Bruce Momjian
Neil Conway wrote: > BTW, the preferred format for patches is context diffs, not unified diffs. FYI, for the type of diff he is supplying unified diffs are better because it is single-line changes, and you see the old/new lines next to each other; the developer's FAQ mentions this. -- Bruce M

Re: [PATCHES] Code-Cleanup: char* -> const char*

2007-03-18 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I also don't see the value in modifying the regexp code, as that is just > an import of Henry Spencer's regexp package. The same objection applies to most of the proposed changes in /src/port/ since those are generally imports from BSD libc code. I don't

Re: [PATCHES] Code-Cleanup: char* -> const char*

2007-03-17 Thread Neil Conway
Stefan Huehner wrote: attached patches marks several char* variables as const where they are initialized with constant strings. I really wonder how much value there is in using the "const" modifier very widely. "const" for function parameters is valuable (because it adds information about

[PATCHES] Code-Cleanup: char* -> const char*

2007-03-14 Thread Stefan Huehner
Hi, attached patches marks several char* variables as const where they are initialized with constant strings. Regards, Stefan Index: src/backend/regex/regc_locale.c === RCS file: /projects/cvsroot/pgsql/src/backend/regex/regc_locale