Re: [PATCHES] Doc for ltrim and rtrim

2004-03-04 Thread Bruce Momjian
Neil Conway wrote: > Bruce Momjian wrote: > > No problem. See the developers page for 5-minute build so you can check > > your commit. > > I think it's best if people always check that they don't break the > docs before committing changes. "make check" should be sufficient, and > that is much f

Re: [PATCHES] Doc for ltrim and rtrim

2004-03-04 Thread Tom Lane
Dennis Bjorklund <[EMAIL PROTECTED]> writes: > The doc for the trim functions does not say that the second argument can > be omitted. This patch fixes it. It also fixes that the type text was not > wrapped as text. It would perhaps be clearer to show the single-argument forms as separate entries

Re: [PATCHES] Doc for ltrim and rtrim

2004-03-04 Thread Neil Conway
Bruce Momjian wrote: No problem. See the developers page for 5-minute build so you can check your commit. I think it's best if people always check that they don't break the docs before committing changes. "make check" should be sufficient, and that is much faster than building the docs completel

Re: [PATCHES] Doc for ltrim and rtrim

2004-03-04 Thread Bruce Momjian
Dennis Bjorklund wrote: > The doc for the trim functions does not say that the second argument can > be omitted. This patch fixes it. It also fixes that the type text was not > wrapped as text. Good. > I can not build the docs myself, but i'm pretty sure it's correct. No problem. See the deve

[PATCHES] Doc for ltrim and rtrim

2004-03-04 Thread Dennis Bjorklund
The doc for the trim functions does not say that the second argument can be omitted. This patch fixes it. It also fixes that the type text was not wrapped as text. I can not build the docs myself, but i'm pretty sure it's correct. Is it okay to commit this? Should I do it on the 7.4 branch also