Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Simon Riggs
On Tue, 2007-03-06 at 09:33 +0530, Pavan Deolasee wrote: Simon Riggs wrote: I'll happily code it as functions or system cols or any other way, as long as we can see everything there is to see. With HOT, other useful information is about the line pointers. Done It would be cool to be

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Gregory Stark
Simon Riggs [EMAIL PROTECTED] writes: I'll return the infomasks directly, for you to manipulate. Not happy with that, but open to suggestions. Well the alternative would be a long list of boolean columns which would make the output kind of long. Perhaps a function pg_decode_infomask(varbit)

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-06 Thread Tom Lane
Gregory Stark [EMAIL PROTECTED] writes: Simon Riggs [EMAIL PROTECTED] writes: I'll return the infomasks directly, for you to manipulate. Not happy with that, but open to suggestions. Well the alternative would be a long list of boolean columns which would make the output kind of long.

[PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Simon Riggs
WIP patch for diagnostic/test functions for heap pages. (Linked to discussion thread on -hackers HOT - Whats Next?) Specifically designed to allow test cases to be written that prove that HOT works, as well as allowing diagnosis of general heap page content errors. Patch, plus additional file:

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: WIP patch for diagnostic/test functions for heap pages. (Linked to discussion thread on -hackers HOT - Whats Next?) --- no security checks; surely these must be superuser-only. --- relation_open will succeed on things that don't have storage; better use

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Simon Riggs
On Mon, 2007-03-05 at 14:31 -0500, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: WIP patch for diagnostic/test functions for heap pages. (Linked to discussion thread on -hackers HOT - Whats Next?) --- no security checks; surely these must be superuser-only. OK thanks ---

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: On Mon, 2007-03-05 at 14:31 -0500, Tom Lane wrote: Exactly what will these allow that you can't do with inspection of ctid etc? (I suspect your answer will be can't see infomask, but I'd rather expose that as a new system column than invent functions like

Re: [PATCHES] Heap page diagnostic/test functions (WIP)

2007-03-05 Thread Pavan Deolasee
Simon Riggs wrote: I'll happily code it as functions or system cols or any other way, as long as we can see everything there is to see. With HOT, other useful information is about the line pointers. It would be cool to be able to print the redirection info, details about LP_DELETEd line