Magnus Hagander wrote:
This doesn't look like our normal coding standards, and should probably
be changed:
+ if (0 != stat(BACKUP_LABEL_FILE, stat_buf))
(there's a number of similar places)
Lacking guidelines, I now tried to copy how stat(2) is used in other parts
of the code.
Yours,
Simon Riggs wrote:
Patch applies, and works as described. Looks good for final apply.
Few minor thoughts:
* Text in pg_ctl should be WARNING, not Warning.
* CancelBackup() API looks strange, not sure why
* Need to mention that CancelBackup() is not the right way to end a
backup, so that
Albe Laurenz wrote:
Simon Riggs wrote:
Patch applies, and works as described. Looks good for final apply.
Few minor thoughts:
* Text in pg_ctl should be WARNING, not Warning.
* CancelBackup() API looks strange, not sure why
* Need to mention that CancelBackup() is not the right
