Re: [PATCHES] MinGW patch

2003-09-07 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > As Tom mentioned, it doesn't find things like sys/socket.h, which we > > have added to src/include/port/win32/. This was done to elimintate > > #ifdef of the include files that are Win32-specific. > > OK, then you can reference the top source

Re: [PATCHES] MinGW patch

2003-09-07 Thread Peter Eisentraut
Bruce Momjian writes: > As Tom mentioned, it doesn't find things like sys/socket.h, which we > have added to src/include/port/win32/. This was done to elimintate > #ifdef of the include files that are Win32-specific. OK, then you can reference the top source directory as $srcdir in configure. -

Re: [PATCHES] MinGW patch

2003-09-07 Thread Peter Eisentraut
Bruce Momjian writes: > The problem is that mbvalidate() has this code: > > if (GetVariableBool(pset.vars, "WIN32_CONSOLE")) > CharToOem(pwcs, pwcs); > > That's why I needed the #ifdef so it only tests from psql. This code > was just broken without that test, and because no on

Re: [PATCHES] MinGW patch

2003-09-07 Thread Bruce Momjian
Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > Why does configure need to see those files? Surely you don't need > > configure to test the capabilities of our own source tree? > > Looking at the contents of src/include/port/win32, I would imagine the > problem is configure wil

Re: [PATCHES] MinGW patch

2003-09-07 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > In mbprint.c: > > + #ifndef PGSCRIPTS > + #include "settings.h" > + #endif > > Why is this needed, considering that the rest of the code was not changed > to make use of any setting? The print modules in psql should not make use > of psql-spec

Re: [PATCHES] MinGW patch

2003-09-07 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > Oh. Any ideas on how to handle that? The other reference uses: > > > > override CPPFLAGS+="-I$(top_srcdir)/src/include/port/win32" > > > > but top_srcdir isn't defined at this point. > > If you put this in the port makefile, then it shou

Re: [PATCHES] MinGW patch

2003-09-07 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Why does configure need to see those files? Surely you don't need > configure to test the capabilities of our own source tree? Looking at the contents of src/include/port/win32, I would imagine the problem is configure will decide we don't HAVE_SYS_S

Re: [PATCHES] MinGW patch

2003-09-07 Thread Peter Eisentraut
Bruce Momjian writes: In mbprint.c: + #ifndef PGSCRIPTS + #include "settings.h" + #endif Why is this needed, considering that the rest of the code was not changed to make use of any setting? The print modules in psql should not make use of psql-specific settings. That's why there are extensive

Re: [PATCHES] MinGW patch

2003-09-07 Thread Peter Eisentraut
Bruce Momjian writes: > Oh. Any ideas on how to handle that? The other reference uses: > > override CPPFLAGS+="-I$(top_srcdir)/src/include/port/win32" > > but top_srcdir isn't defined at this point. If you put this in the port makefile, then it should work. > This is there only so 'confi

Re: [PATCHES] MinGW patch

2003-09-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > but top_srcdir isn't defined at this point. Perhaps $srcdir? Peter would probably know what to use. regards, tom lane ---(end of broadcast)--- TIP 3: if posting/reading through Us

Re: [PATCHES] MinGW patch

2003-09-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > + # We already have this in Makefile.win32, but configure needs it too > > + if test "$PORTNAME" = "win32" > > + then > > + CPPFLAGS="$CPPFLAGS -Isrc/include/port/win32" > > + fi > > This seems unlikely to work when building ou

Re: [PATCHES] MinGW patch

2003-09-06 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > + # We already have this in Makefile.win32, but configure needs it too > + if test "$PORTNAME" = "win32" > + then > + CPPFLAGS="$CPPFLAGS -Isrc/include/port/win32" > + fi This seems unlikely to work when building outside the source tree.

[PATCHES] MinGW patch

2003-09-06 Thread Bruce Momjian
I have applied the following patch to allow MinGW to again work on CVS. THe patch makes the following changes: o allow configure to see include/port/win32 include files o add matching Win32 accept() prototype o allow pg_id to compile with native Win32 API o fix inv