Re: [PATCHES] Python setof patch

2005-07-05 Thread Michael Fuhr
On Mon, Jul 04, 2005 at 03:04:51PM -0400, Bruce Momjian wrote: Patch applied. Thanks. Gerrit van Dyk wrote: This patch allows the PL/Python module to do (SRF) functions. Does this patch work? The test_setof() function in sql/plpython_setof.sql gives me the following: SELECT * FROM

Re: [PATCHES] Python setof patch

2005-07-05 Thread Michael Fuhr
On Tue, Jul 05, 2005 at 04:23:42PM +0200, Gerrit van Dyk wrote: Ok, I just looked at the code again and the results I am getting, is what you expect. 2 rows every time returning 1 and 2. What version of postgres are you running, I am running 8.0.3 I'm running HEAD (8.1devel), which is

Re: [PATCHES] Python setof patch

2005-07-05 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: I'm running HEAD (8.1devel), which is where the patch was committed. Could somebody else test HEAD and see what they get? Same as you --- ie, this patch is utterly broken. I don't see the setof functionality in the regression tests, presumably because

Re: [PATCHES] Python setof patch

2005-07-05 Thread Tom Lane
Michael Fuhr [EMAIL PROTECTED] writes: This patch allows the PL/Python module to do (SRF) functions. Does this patch work? Aside from minor problems like being broken and undocumented, there is a more serious question here: is this even the functionality we want? The proposed test case is:

Re: [PATCHES] Python setof patch

2005-07-05 Thread Michael Fuhr
On Tue, Jul 05, 2005 at 01:14:25PM -0400, Tom Lane wrote: Aside from minor problems like being broken and undocumented, there is a more serious question here: is this even the functionality we want? I'd rather see something akin to PL/pgSQL's RETURN NEXT or PL/Perl's return_next. -- Michael

Re: [PATCHES] Python setof patch

2005-07-05 Thread Bruce Momjian
OK, patch backed out, new and regression file removed. --- Andrew Dunstan wrote: Michael Fuhr wrote: On Tue, Jul 05, 2005 at 01:14:25PM -0400, Tom Lane wrote: Aside from minor problems like being broken and

Re: [PATCHES] Python setof patch

2005-07-04 Thread Bruce Momjian
Patch applied. Thanks. --- Gerrit van Dyk wrote: Hi, This patch allows the PL/Python module to do (SRF) functions. The patch was taken from the CVS version. I have modified the plpython.c file and have added a

Re: [PATCHES] Python setof patch

2005-06-19 Thread Michael Fuhr
On Wed, Jun 15, 2005 at 03:03:46PM +0200, Gerrit van Dyk wrote: My next project I am working in is to get the PL/Python module to return records (ie. structured data) Hmmm...if you're interested in working on PL/Python, then you might mosey over to pgsql-hackers and see the process crash

[PATCHES] Python setof patch

2005-06-18 Thread Gerrit van Dyk
Hi, This patch allows the PL/Python module to do (SRF) functions. The patch was taken from the CVS version. I have modified the plpython.c file and have added a test sql script for testing the functionality. It was actually the script that was in the 8.0.3 version but have since been