Re: [PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2008-03-09 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > Here is a revised patch to reduce memory usage during VACUUM, > using FSMPageData (6 byte) instead of PageFreeSpaceInfo (8 or 16 bytes). Applied, thanks. > The keepable pages with freespace will extended to 21GB from 8GB with > 16MB of default mainte

Re: [PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2007-09-13 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- ITAGAKI Takahiro wrote: > I wrote: > > > I'll rewrite my patch to use > > FSMPageData in both places so that users c

Re: [PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2007-08-12 Thread ITAGAKI Takahiro
I wrote: > I'll rewrite my patch to use > FSMPageData in both places so that users can always estimate the memory > to 6 bytes per page. Here is a revised patch to reduce memory usage during VACUUM, using FSMPageData (6 byte) instead of PageFreeSpaceInfo (8 or 16 bytes). The keepable pages with f

Re: [PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2007-08-12 Thread ITAGAKI Takahiro
Decibel! <[EMAIL PROTECTED]> wrote: > > The sizeof(PageFreeSpaceInfo) is 16 bytes > So... does that mean that the comment in the config file about 6 bytes > per page is incorrect? There are no comments the usage of maintenance_work_mem in the config file nor the documentation. Memory consumed b

Re: [PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2007-08-10 Thread Decibel!
On Fri, Aug 10, 2007 at 10:32:35AM +0900, ITAGAKI Takahiro wrote: > Here is a patch to reduce the size of PageFreeSpaceInfo on 64bit platform. > We will utilize maintenance_work_mem twice with the patch. > > The sizeof(PageFreeSpaceInfo) is 16 bytes there because the type of 'avail' > is 'Size', t

Re: [PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2007-08-09 Thread Tom Lane
ITAGAKI Takahiro <[EMAIL PROTECTED]> writes: > - Sizeavail; /* space available on this page > */ > + uint32 avail; /* space available on this page > */ This declaration ties into a boatload of others, eg, just about every use of Size

[PATCHES] Reduce the size of PageFreeSpaceInfo on 64bit platform

2007-08-09 Thread ITAGAKI Takahiro
Here is a patch to reduce the size of PageFreeSpaceInfo on 64bit platform. We will utilize maintenance_work_mem twice with the patch. The sizeof(PageFreeSpaceInfo) is 16 bytes there because the type of 'avail' is 'Size', that is typically 8 bytes and needs to be aligned in 8-byte bounds. I changed