Re: [PATCHES] WIP list rewrite

2004-05-23 Thread Neil Conway
Tom Lane wrote: A couple hours' poking at the patch yielded the attached two diffs Thanks Tom! and the realization that list_difference_private cannot work, because its first call to list_append_auto will crash due to new_list being NIL. Yeah, I noticed an analogous problem in list_union(), I'd bee

Re: [PATCHES] WIP list rewrite

2004-05-23 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > BTW, should I take your lack of comment on linitial() as "no objection"? Make it "no better idea" ;-) A couple hours' poking at the patch yielded the attached two diffs and the realization that list_difference_private cannot work, because its first call t

Re: [PATCHES] WIP list rewrite

2004-05-23 Thread Neil Conway
Tom Lane wrote: I'm surprised you did that much work and did not fix things to distinguish ListCell * from List * ... we're gonna have to make another pass over all these places to do that. That would mean changing _every_ usage of foreach(), and a bunch of other places besides; plus, once one cha

Re: [PATCHES] WIP list rewrite

2004-05-23 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I've attached the latest list rewrite patch (gzip'ed, against current > sources). Unfortunately, the compatibility API we defined earlier wasn't > that effective: it was more efficient for me to look at more or less > every lfirst() call site in the back