Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Mark Kirkwood
Sorry Bruce - I meant your 'fix for win32 pgport and pg_dumpall' patch. Mark Bruce Momjian wrote: [EMAIL PROTECTED] wrote: It was, next update got it! Of course I found the src/utils issue then However, with the patch for that applied I can confirm a successful build! What patch is that

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
Andreas Pflug wrote: > [EMAIL PROTECTED] wrote: > > Interesting, > > > > After repeating 'make distclean;./configure --without-zlib' I have a > > pg_config.h *with* HAVE_SYMLINK=1. > > > > Sorry, mea culpa. I did a simple clean, not a distclean. Works ok. Perfect! I didn't think distclean wou

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Andreas Pflug
[EMAIL PROTECTED] wrote: Interesting, After repeating 'make distclean;./configure --without-zlib' I have a pg_config.h *with* HAVE_SYMLINK=1. Sorry, mea culpa. I did a simple clean, not a distclean. Works ok. Regards, Andreas ---(end of broadcast)---

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
Andreas Pflug wrote: > [EMAIL PROTECTED] wrote: > > > > (create/drop tablespace works too) > > I can *not* confirm this; after configure; make clean; make; make > install I got "tablespace not supported". pg_config.h lacks HAVE_SYMLINK=1. I am confused. We have something in configure that forc

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
[EMAIL PROTECTED] wrote: > It was, next update got it! Of course I found the src/utils issue then > > However, with the patch for that applied I can confirm a successful build! What patch is that? -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED]

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Bruce Momjian
[EMAIL PROTECTED] wrote: > Interesting, > > After repeating 'make distclean;./configure --without-zlib' I have a > pg_config.h *with* HAVE_SYMLINK=1. Right, symlinks are supported in Win32 now. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED]

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread markir
Interesting, After repeating 'make distclean;./configure --without-zlib' I have a pg_config.h *with* HAVE_SYMLINK=1. (To cover all the bases, adding in zlib support still results in HAVE_SYMLINK=1 for me) At this point, sleeping seems quite attractive... regards Mark Quoting Andreas Pflug <[E

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread Andreas Pflug
[EMAIL PROTECTED] wrote: (create/drop tablespace works too) I can *not* confirm this; after configure; make clean; make; make install I got "tablespace not supported". pg_config.h lacks HAVE_SYMLINK=1. Regards, Andreas ---(end of broadcast)--- TIP 8

Re: [PATCHES] Win32 tablespace

2004-08-08 Thread markir
It was, next update got it! Of course I found the src/utils issue then However, with the patch for that applied I can confirm a successful build! (create/drop tablespace works too) regards Mark Quoting Bruce Momjian <[EMAIL PROTECTED]>: > > Nope, you need Makefile 1.15. Must be a lag. >

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread Bruce Momjian
Nope, you need Makefile 1.15. Must be a lag. --- [EMAIL PROTECTED] wrote: > Hmmm...updated and tried to rebuild - I get the same error! > > It looks like I have the latest src/timezone/Makefile (1.14) > > The only thing I

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread markir
Hmmm...updated and tried to rebuild - I get the same error! It looks like I have the latest src/timezone/Makefile (1.14) The only thing I am doing that is a bit different perhaps is : - on Freebsd performing cvs update -d -P - followed by ./configure;make dist - copy the archive to win2000 and

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread Bruce Momjian
I just committed the final fix for zic and Claudio has compiled it so please grab cvs head and give it a try. --- [EMAIL PROTECTED] wrote: > Unfortunately I am still seeing the same error - I can "fix" it by with this: > >

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread markir
Unfortunately I am still seeing the same error - I can "fix" it by with this: *** dirmod.c.orig Sun Aug 8 17:14:48 2004 --- dirmod.cSun Aug 8 17:14:59 2004 *** *** 15,20 --- 15,21 *- */

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread Bruce Momjian
OK, I have just applied a patch to src/timezone/Makefile which will fix this by compiling dirmod.c specially like we do in other Makefiles. Patch attached. --- [EMAIL PROTECTED] wrote: > I get a build failure (win 2000 pro)

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread markir
I get a build failure (win 2000 pro): gcc -O2 -fno-strict-aliasing -Wall -Wmissing-prototypes -Wmissing-declarations zic.o ialloc.o scheck.o localtime.o -L../../src/port -lpgport -lwsock32 -lm -lws2_32 -o zic.exe ../../src/port/libpgport.a(dirmod.o)(.text+0xc6):dirmod.c: undefined reference to

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread Bruce Momjian
OK, got them all. Thanks. Patch attached. Would someone retest on Win32? --- Andreas Pflug wrote: > Bruce Momjian wrote: > > OK, applied. I moved the funciton into port/dirmod.c and cleaned up the > > interface for Win32

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread Andreas Pflug
Bruce Momjian wrote: OK, applied. I moved the funciton into port/dirmod.c and cleaned up the interface for Win32. Would someone test this on Win32 in case I broke something? Yes, something's broken, see patch. Second, HAVE_SYMLINK must be defined somewhere (configure?). Third, a junction is a dir

Re: [PATCHES] Win32 tablespace

2004-08-07 Thread Bruce Momjian
OK, applied. I moved the funciton into port/dirmod.c and cleaned up the interface for Win32. Would someone test this on Win32 in case I broke something? Patch attached. --- Andreas Pflug wrote: > The attached patch implem

Re: [PATCHES] Win32 tablespace

2004-08-06 Thread Dave Page
> -Original Message- > From: Andreas Pflug [mailto:[EMAIL PROTECTED] > Sent: 06 August 2004 11:07 > To: Dave Page > Cc: Bruce Momjian; PostgreSQL Patches > Subject: Re: [PATCHES] Win32 tablespace > > Since NT4 isn't supported by M$ for quite some time n

Re: [PATCHES] Win32 tablespace

2004-08-06 Thread Andreas Pflug
Dave Page wrote: This is obviously win2k+ only though - There's a chance it might work on NT4 with >=SP4, because AFAIR the updated NTFS driver already understands the W2K format. until now we've tried to support NT4 as well, although it seems that we can't get initdb to work as we'd like in the

Re: [PATCHES] Win32 tablespace

2004-08-06 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Andreas Pflug > Sent: 05 August 2004 20:23 > To: Bruce Momjian > Cc: PostgreSQL Patches > Subject: Re: [PATCHES] Win32 tablespace > > Bruce Momjian wrote: > >

Re: [PATCHES] Win32 tablespace

2004-08-05 Thread Andreas Pflug
Bruce Momjian wrote: Andreas Pflug wrote: The attached patch implements a symlink for win32 using junctions, and uses that for win32 tablespaces. Wow, that's, uh, amazing! http://www.codeproject.com/w2k/junctionpoints.asp has a good description of the obfuscated REPARSE_DATA_BUFFER which is incl

Re: [PATCHES] Win32 tablespace

2004-08-05 Thread Bruce Momjian
Andreas Pflug wrote: > The attached patch implements a symlink for win32 using junctions, and > uses that for win32 tablespaces. Wow, that's, uh, amazing! -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life i

[PATCHES] Win32 tablespace

2004-08-05 Thread Andreas Pflug
The attached patch implements a symlink for win32 using junctions, and uses that for win32 tablespaces. Regards, Andreas Index: tablespace.c === RCS file: /projects/cvsroot/pgsql-server/src/backend/commands/tablespace.c,v retrieving