Re: [PATCHES] aclchk.c refactor

2005-12-01 Thread Alvaro Herrera
Alvaro Herrera wrote: > I intend to apply later today the attached patch in order to reduce some > code duplication in aclchk.c and clean a bit the API I just introduced > in the previous patch. This reduces aclchk.c from 2377 lines to 2206. I applied this patch yesterday, but I did not receive t

Re: [PATCHES] aclchk.c refactor

2005-11-21 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Now I noticed that there are multiple functions pg_class_aclmask, > pg_database_aclmask, pg_language_aclmask, etc. Is there any objection > to making the exported routine expose the object type as an AclKind > parameter instead of having one function fo

Re: [PATCHES] aclchk.c refactor

2005-11-21 Thread Alvaro Herrera
Alvaro Herrera wrote: > I intend to apply later today the attached patch in order to reduce some > code duplication in aclchk.c and clean a bit the API I just introduced > in the previous patch. This reduces aclchk.c from 2377 lines to 2206. Of course, it would be much better if the proposed patc

[PATCHES] aclchk.c refactor

2005-11-21 Thread Alvaro Herrera
I intend to apply later today the attached patch in order to reduce some code duplication in aclchk.c and clean a bit the API I just introduced in the previous patch. This reduces aclchk.c from 2377 lines to 2206. -- Alvaro Herrerahttp://www.CommandPrompt.com/ The