Re: [PATCHES] contrib/spi makefile inconsistency

2007-03-23 Thread Magnus Hagander
On Thu, Mar 22, 2007 at 12:33:30PM -0400, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > contrib/spi has a Makefile that uses $(addsuffix) makefile rules for > > DATA_built and DOCS. It's the only Makefile in contrib that does it. > > I would like to change that to actually listi

Re: [PATCHES] contrib/spi makefile inconsistency

2007-03-22 Thread Peter Eisentraut
Magnus Hagander wrote: > I would like to change that to actually listing the modules instead. > The reason for that is that parsing the Makefile for the msvc build > will be a *lot* easier if I don't have to parse $addsuffix rules. Let's not open that can of worms. Even if you think it's only a s

Re: [PATCHES] contrib/spi makefile inconsistency

2007-03-22 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > contrib/spi has a Makefile that uses $(addsuffix) makefile rules for > DATA_built and DOCS. It's the only Makefile in contrib that does it. > I would like to change that to actually listing the modules instead. This seems like a definite regression in

[PATCHES] contrib/spi makefile inconsistency

2007-03-22 Thread Magnus Hagander
Hi! contrib/spi has a Makefile that uses $(addsuffix) makefile rules for DATA_built and DOCS. It's the only Makefile in contrib that does it. I would like to change that to actually listing the modules instead. The reason for that is that parsing the Makefile for the msvc build will be a *lot* ea