Re: [PATCHES] contrib/xml2 function name change and minor bitrot

2004-03-13 Thread Bruce Momjian
Tom Lane wrote: Neil Conway [EMAIL PROTECTED] writes: A few comments on the module: - can you include some licensing information? Distributed under the same terms as PostgreSQL, Copyright ... should be sufficient unless you'd prefer another license Actually, it had better be same

Re: [PATCHES] contrib/xml2 function name change and minor bitrot fix

2004-03-08 Thread Bruce Momjian
Patch applied by Neil (thanks). Thanks. --- John Gray wrote: Hi, I've done a bit of testing now and it seems that both sets of XML functions will coexist in the same database (they both load OK and I can use

[PATCHES] contrib/xml2 function name change and minor bitrot fix

2004-03-07 Thread John Gray
Hi, I've done a bit of testing now and it seems that both sets of XML functions will coexist in the same database (they both load OK and I can use functions from both without any apparent problem). I have changed the name of the new parse function to xml_valid and fixed a reference to SortMem

Re: [PATCHES] contrib/xml2 function name change and minor bitrot

2004-03-07 Thread Neil Conway
John Gray wrote: I have changed the name of the new parse function to xml_valid and fixed a reference to SortMem which meant that the code as supplied would work against 7.3 and 7.4 but wouldn't work in CVS. Oops! Patch is attached. Looks good -- I'll apply the patch by this evening. -Neil