Bruce Momjian [EMAIL PROTECTED] writes:
I have fixed all these items and the updated patch is at:
ftp://momjian.us/pub/postgresql/mypatches/lc_time
Applied with further fixes --- mostly, ensure that it doesn't leave a
crash-inducing corrupted cache if strdup() returns NULL, and make the
I have reviewed this patch. I like the method you used, but I did find
a few things I had to change.
First, I found the abbreviated variable names confusing so I used longer
ones, like:
extern char *localized_abbrev_days[7];
extern char *localized_full_days[7];
Bruce Momjian wrote:
I have reviewed this patch. I like the method you used, but I did find
a few things I had to change.
Good catch. I tested here and it seems ok. Thanks for your review.
--
Euler Taveira de Oliveira
http://www.timbira.com/
--
Sent via pgsql-patches mailing list
Euler Taveira de Oliveira wrote:
Here is an updated patch. It follows the Oracle behaviour and uses a
cache mechanism to avoid calling setlocale() all the time. I unified the
localized_* and str_* functions. I didn't test it on Windows. I would
appreciate some feedback.
Added to May
Bruce Momjian wrote:
Euler, have you updated this patch yet?
Here is an updated patch. It follows the Oracle behaviour and uses a
cache mechanism to avoid calling setlocale() all the time. I unified the
localized_* and str_* functions. I didn't test it on Windows. I would
appreciate some
Euler Taveira de Oliveira wrote:
Tom Lane wrote:
But as Peter remarks nearby, this discussion is wasted anyway, because
there is only one correct answer: whatever Oracle does with these
cases is what to_char() should do.
My patch does exactly what Oracle does besides one thing: my
Bruce Momjian wrote:
Euler, have you updated this patch yet?
I'm in a process to submit another patch but I want to test on Windows
first.
--
Euler Taveira de Oliveira
http://www.timbira.com/
--
Sent via pgsql-patches mailing list (pgsql-patches@postgresql.org)
To make changes to your
Peter Eisentraut napsal(a):
Am Dienstag, 26. Februar 2008 schrieb Zdenek Kotala:
But how you handle situation when you have multi language application
which needs correct output for all languages? You cannot use any of the
pattern because it will be wrong for some group of languages.
Euler Taveira de Oliveira napsal(a):
Zdenek Kotala wrote:
Please, Day names does not have capitalized first letter in Czech
language. We have pondeli as a Monday. If locale does not do that it
is probably intention :-).
Hmmm... I don't know about that. I do it that way 'cause I'm concerned
] lc_time and localized dates
Hi,
Attached is a patch that replaces the lc_messages with
lc_time when using to_char in translation mode (TM) [1]. It
doesn't change the output behaviour. Per discussion [2], it's
using some cache mechanism so we don't need to call
setlocale() all the time
Gevik Babakhani wrote:
Have you tested this patch on MSVC and MinGW (Windows) builds?
changing LC_MESSAGES/LC_TIME will most probably break the Windows behavior.
No. [Looking at the code...] I think it only affects the LC_MESSAGES
'cause setlocale(LC_MESSAGES) don't work on Windows.
AFAIK,
Zdenek Kotala wrote:
Yes it is. Only if it is a first word in a sentence or name you should
use Ú. Also name of day is 'pondělí' (Monday) with small p
But we're not talking about *sentence*, we need to consider just the
*word*. So I think TMMonth should be Xxxx, TMMONTH should be
No. [Looking at the code...] I think it only affects the
LC_MESSAGES 'cause setlocale(LC_MESSAGES) don't work on Windows.
In order to make setlocale(LC_MESSAGES) affect on windows some additional
steps must be taken. I don't go deep in that now. I have a fix with
description etc. etc.
Is it
Euler Taveira de Oliveira napsal(a):
Zdenek Kotala wrote:
Yes it is. Only if it is a first word in a sentence or name you should
use Ú. Also name of day is 'pondělí' (Monday) with small p
But we're not talking about *sentence*, we need to consider just the
*word*. So I think TMMonth should
Am Dienstag, 26. Februar 2008 schrieb Zdenek Kotala:
But how you handle situation when you have multi language application
which needs correct output for all languages? You cannot use any of the
pattern because it will be wrong for some group of languages.
This is what you get when you copy a
Zdenek Kotala wrote:
But how you handle situation when you have multi language application
which needs correct output for all languages? You cannot use any of the
pattern because it will be wrong for some group of languages.
FYI, strftime() [1] doesn't say anything about capitalization. I
This is what you get when you copy a proprietary, poorly
specified interface.
The to_char functions are supposed to be Oracle-compatible,
so we need to check what Oracle does. Whether that is useful
in practice is a bit secondary.
I'm beginning to think, if you want formatting
But as Peter remarks nearby, this discussion is wasted
anyway, because there is only one correct answer: whatever
Oracle does with these cases is what to_char() should do.
++1
---(end of broadcast)---
TIP 7: You can help support the
Euler Taveira de Oliveira [EMAIL PROTECTED] writes:
FYI, strftime() [1] doesn't say anything about capitalization. I don't
know if some translators are aware of it and even if they are, how would
they know that a day or month is the first word of a sentence? IMHO we
should provide X,
Tom Lane wrote:
But as Peter remarks nearby, this discussion is wasted anyway, because
there is only one correct answer: whatever Oracle does with these
cases is what to_char() should do.
My patch does exactly what Oracle does besides one thing: my code does
not contain a real capitalization
Hi,
Attached is a patch that replaces the lc_messages with lc_time when
using to_char in translation mode (TM) [1]. It doesn't change the output
behaviour. Per discussion [2], it's using some cache mechanism so we
don't need to call setlocale() all the time.
Some issues:
(i) some locales
Euler Taveira de Oliveira napsal(a):
Hi,
Hi
Some issues:
(i) some locales don't capitalize the first letter. I'm using
pg_toupper() to do the job but I'm afraid it's not appropriated. I'm
using it 'cause i'm too lazy to move localized_str_toupper(). Any
suggestions?
Please, Day names
Zdenek Kotala wrote:
Please, Day names does not have capitalized first letter in Czech
language. We have pondeli as a Monday. If locale does not do that it
is probably intention :-).
Hmmm... I don't know about that. I do it that way 'cause I'm concerned
about some locales that don't
23 matches
Mail list logo
