Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket

2006-05-09 Thread Peter Brant
Yep, the pipe.c patch is unnecessary now. Pete >>> Bruce Momjian 05/07/06 3:44 am >>> Now that we know the cause of the Win32 failure (FRONTEND), we don't need the Win32 part of this patch anymore right? ---(end of broadcast)--- TIP 5: don't forge

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket error fix

2006-05-06 Thread Bruce Momjian
Now that we know the cause of the Win32 failure (FRONTEND), we don't need the Win32 part of this patch anymore right? (The stats display part was already applied.) --- Peter Brant wrote: > Hi all, > > Attached are two patc

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket

2006-04-06 Thread Peter Brant
Also, do we want to move the retry loop to pgwin32_recv? That seems like a good idea. I'm not sure users of recv should ever have to deal with WSAEWOULDBLOCK as it's not really an error. Pete >>> "Magnus Hagander" <[EMAIL PROTECTED]> 04/06/06 9:58 pm >>> > > Attached are two patches which in co

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket error fix

2006-04-06 Thread Magnus Hagander
> > Attached are two patches which in combination make pg_stat_activity > > work reliably for us on Windows. > > ... > > pgstat.patch removes the delayed destroy code for backends, > databases, > > and tables. Database and table entries are cleaned up immediately > > upon receipt of the approp

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket error fix

2006-04-06 Thread Tom Lane
"Peter Brant" <[EMAIL PROTECTED]> writes: > Attached are two patches which in combination make pg_stat_activity > work reliably for us on Windows. > ... > pgstat.patch removes the delayed destroy code for backends, databases, > and tables. Database and table entries are cleaned up immediately upon

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket

2006-04-06 Thread Peter Brant
>>> "Magnus Hagander" <[EMAIL PROTECTED]> 04/06/06 7:26 pm >>> > BTW, what's with the change to all the error msgs? Ah, I'd assumed the %ui was a typo in the format string. If the intent was to print e.g. 10022i, I'll change it back. > And finally, the error handling looks a bit off? We specific

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket

2006-04-06 Thread Kevin Grittner
>>> On Thu, Apr 6, 2006 at 12:26 pm, in message <[EMAIL PROTECTED]>, "Magnus Hagander" <[EMAIL PROTECTED]> wrote: > And finally, the error handling looks a bit off? We specifically *don't* > want it to log an error for the WSAECONNRESET state - it's a normal > state. Or am I reading the patch wro

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket error fix

2006-04-06 Thread Magnus Hagander
> Oh, and checking the code go pgwin32_recv, I think I see > where this is coming from: pgwin32_recv calls > pgwin32_waitforsinglesocket(). If that one succeeds *and a > signal is delivered while it's waiting*, we'll get out og > pgwin32_waitforsinglesocket() without clearing the WSA code. > T

Re: [PATCHES] pgstat: remove delayed destroy / pipe: socket error fix

2006-04-06 Thread Magnus Hagander
> Hi all, > > Attached are two patches which in combination make > pg_stat_activity work reliably for us on Windows. > > The mysterious socket error turned out to be WSAEWOULDBLOCK. > Per > http://msdn.microsoft.com/library/default.asp?url=/library/en- > us/winsock/winsock/windows_sockets_err

[PATCHES] pgstat: remove delayed destroy / pipe: socket error fix

2006-04-06 Thread Peter Brant
Hi all, Attached are two patches which in combination make pg_stat_activity work reliably for us on Windows. The mysterious socket error turned out to be WSAEWOULDBLOCK. Per http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/winsock/windows_sockets_error_codes_2.asp , it se