Re: [PATCHES] seg regression failures

2007-03-23 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> Yup, that was indeed the problem. I assume you'll do the honors. > > Yeah, the comments need fixed too. I'll do it later today. Thanks. //Magnus ---(end of broadcast)--- TIP 6: expl

Re: [PATCHES] seg regression failures

2007-03-23 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > Yup, that was indeed the problem. I assume you'll do the honors. Yeah, the comments need fixed too. I'll do it later today. regards, tom lane ---(end of broadcast)--- TIP 4: Hav

Re: [PATCHES] seg regression failures

2007-03-23 Thread Magnus Hagander
Magnus Hagander wrote: > Tom Lane wrote: >> Magnus Hagander <[EMAIL PROTECTED]> writes: >>> The SEG parameters going into seg_overlap() look perfectly correct, and >>> seg_overlap() actually returns 0. But this is somehow later turned into >>> 't'. Any pointers for where to look for how that happen

Re: [PATCHES] seg regression failures

2007-03-23 Thread Magnus Hagander
Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: >> The SEG parameters going into seg_overlap() look perfectly correct, and >> seg_overlap() actually returns 0. But this is somehow later turned into >> 't'. Any pointers for where to look for how that happens? > > I'll betcha that MSVC

Re: [PATCHES] seg regression failures

2007-03-23 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > The SEG parameters going into seg_overlap() look perfectly correct, and > seg_overlap() actually returns 0. But this is somehow later turned into > 't'. Any pointers for where to look for how that happens? I'll betcha that MSVC is generating code that

Re: [PATCHES] seg regression failures

2007-03-23 Thread Magnus Hagander
Tom Lane wrote: > Andrew Dunstan <[EMAIL PROTECTED]> writes: >> Anyway, I think you probably need to load up the old debugger and put a >> break point in the overlap function ... surely the error can't be in >> float4in or else we'd have seen other regression problems. > > One of the failing te

Re: [PATCHES] seg regression failures

2007-03-23 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > Anyway, I think you probably need to load up the old debugger and put a > break point in the overlap function ... surely the error can't be in > float4in or else we'd have seen other regression problems. One of the failing test cases is for seg_over_

Re: [PATCHES] seg regression failures

2007-03-23 Thread Andrew Dunstan
Magnus Hagander wrote: contrib/seg fails regression tests on my msvc build (reason Ididn't notice earlier is probably that you couldn't run contribcheck on the vcbuild). regression.diff attached. Anybody see a smoking gun? I don't really know what seg is supposed to be doing, so I don't know whe

Re: [PATCHES] seg regression failures

2007-03-23 Thread Magnus Hagander
On Fri, Mar 23, 2007 at 01:15:10PM +0300, Teodor Sigaev wrote: > >Anybody see a smoking gun? I don't really know what seg is supposed to be > >doing, so I don't know where to start. > > As crazy idea only: try to modify seg_overlap to > bool > seg_overlap(SEG * a, SEG * b) > { > return ( >

Re: [PATCHES] seg regression failures

2007-03-23 Thread Teodor Sigaev
Anybody see a smoking gun? I don't really know what seg is supposed to be doing, so I don't know where to start. As crazy idea only: try to modify seg_overlap to bool seg_overlap(SEG * a, SEG * b) { return ( ((a->upper >= b->upper) && (a->lower <= b->upper)) ||

[PATCHES] seg regression failures

2007-03-23 Thread Magnus Hagander
contrib/seg fails regression tests on my msvc build (reason Ididn't notice earlier is probably that you couldn't run contribcheck on the vcbuild). regression.diff attached. Anybody see a smoking gun? I don't really know what seg is supposed to be doing, so I don't know where to start. (had to sen