Re: [PATCHES] Thread-safe PREPARE in ecpg

2007-09-26 Thread Michael Meskes
On Wed, Sep 26, 2007 at 01:43:34PM +0900, ITAGAKI Takahiro wrote: > Here is a revised patch against CVS HEAD. > I fixed a bug in ECPGdeallocate_all(). Applied to CVS HEAD. I also added your example to the regression tests. Michael -- Michael Meskes Email: Michael at Fam-Meskes dot De, Michael at

Re: [PATCHES] Thread-safe PREPARE in ecpg

2007-09-25 Thread ITAGAKI Takahiro
Here is a revised patch against CVS HEAD. I fixed a bug in ECPGdeallocate_all(). Michael Meskes <[EMAIL PROTECTED]> wrote: > Could you please create a small example that we could add to the > regression suite? The attached prep.pgc is an example for this fix, that repeats EXEC SQL PREPARE and EX

Re: [PATCHES] Thread-safe PREPARE in ecpg

2007-09-25 Thread Michael Meskes
On Tue, Sep 25, 2007 at 03:22:13PM +0900, ITAGAKI Takahiro wrote: > Here is a WIP patch to make prepared statements thread-safe in ecpg. > The variable prep_stmts was global but not protected by any locks. > I divided it into per-connection field so that we can access prepared > statements separate

[PATCHES] Thread-safe PREPARE in ecpg

2007-09-24 Thread ITAGAKI Takahiro
Here is a WIP patch to make prepared statements thread-safe in ecpg. The variable prep_stmts was global but not protected by any locks. I divided it into per-connection field so that we can access prepared statements separately in each thread. I needed to change the following exported functions, b

[PATCHES] Thread-safe snprintf() vsnprintf() and printf()

2005-02-28 Thread Nicolai Tufar
And while we are on it, I would like to submit minor changes to make snprintf() vsnprintf() and printf() functions in src/port/snprintf.c thread-safe. Best regards, Nicolai Tufar Index: src/port/snprintf.c === RCS file: /projects/cvsr

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Bruce Momjian
Tom Lane wrote: > Andreas Pflug <[EMAIL PROTECTED]> writes: > > When checking for thread safety with src/tools/thread/thread_test.c, the > > mktemp function wants an argument that contains 6 X, while the current > > version only supplies 5 X which will fail on my SuSE 8.1. > > Patch attached. >

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug <[EMAIL PROTECTED]> writes: When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Isn't this go

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Bruce Momjian
Thanks. Fixed. --- Andreas Pflug wrote: > When checking for thread safety with src/tools/thread/thread_test.c, the > mktemp function wants an argument that contains 6 X, while the current > version only supplies 5 X which

Re: [PATCHES] thread safety testing fix

2004-05-28 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > When checking for thread safety with src/tools/thread/thread_test.c, the > mktemp function wants an argument that contains 6 X, while the current > version only supplies 5 X which will fail on my SuSE 8.1. > Patch attached. Isn't this going to break pl

[PATCHES] thread safety testing fix

2004-05-28 Thread Andreas Pflug
When checking for thread safety with src/tools/thread/thread_test.c, the mktemp function wants an argument that contains 6 X, while the current version only supplies 5 X which will fail on my SuSE 8.1. Patch attached. Regards, Andreas Index: thread_test.c

[PATCHES] thread

2004-05-06 Thread Bruce Momjian
Here is the email I have. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 >From [EMAIL PR

Re: [PATCHES] thread

2004-05-06 Thread Bruce Momjian
Sorry I sent this email to the lists by accident. I meant to send it just to Magnus. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.

[PATCHES] Thread test improvement

2004-04-27 Thread Bruce Momjian
With Peter's help, I have changed the way I do thread testing from configure to be much cleaner. Patch attached and applied. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Rober

[PATCHES] Thread redesign

2004-02-11 Thread Bruce Momjian
The following patch creates a separate configuration variable for each function requiring thread safety. This allows better selection of *_r function names. It also removes thread locking around non-thread-safe function because the application could call those from its own code. Platforms will h

[PATCHES] thread patch

2003-09-13 Thread Bruce Momjian
Here is the thread patch. -- Bruce Momjian| http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup.| Newtown Square, Pennsylvania 19073 Index: configur

Re: [PATCHES] Thread configure flag

2003-06-21 Thread Larry Rosenman
--On Saturday, June 21, 2003 15:57:54 -0400 Bruce Momjian <[EMAIL PROTECTED]> wrote: \ Well, when the packagers wrap up 7.4 they're going to need to make a call. Either it's not going to be thread-safe, and the work was in vain, or it's thread-safe and the concerns about the supposed performanc

Re: [PATCHES] Thread configure flag

2003-06-21 Thread Bruce Momjian
Peter Eisentraut wrote: > Bruce Momjian writes: > > > First, ecpg has actual thead creation function calls, so I believe we > > will still need a --with-threads configure option, at least to control > > ecpg, unless we make threading some kind of ecpg runtime flag. > > This is not an issue becaus

Re: [PATCHES] Thread configure flag

2003-06-19 Thread Peter Eisentraut
Bruce Momjian writes: > First, ecpg has actual thead creation function calls, so I believe we > will still need a --with-threads configure option, at least to control > ecpg, unless we make threading some kind of ecpg runtime flag. This is not an issue because it only affects the libecpg library.