Mark Kirkwood wrote:
So, please ignore my previous patch to the header file, and consider
this one - which eliminates it completely.
Thanks, applied.
-Neil
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
Neil Conway wrote:
Mark Kirkwood wrote:
Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header
How is this tidier?
err... puts the macro in the header
(I don't see a reason for pg_buffercache_pages.h at all, actually.)
(chuckles) - well, that puts
Mark Kirkwood wrote:
Neil Conway wrote:
Andrew Dunstan wrote:
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
Applied, thanks.
Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header (probably after
Andrew Dunstan wrote:
I didn't see the original of the later patch, which is why I sent in
mine. I honestly don't care that much either way, although I'm inclined
to agree that the header file is just unnecessary noise.
Well, looks like a strong feeling for no header :-). I didn't really
think
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
cheers
andrew
Andrew Dunstan wrote:
It fixes the build error on Windows - haven't tried because i don't have
time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
defined on Cygwin - see
Neil Conway wrote:
Andrew Dunstan wrote:
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
Applied, thanks.
Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header (probably after asking Andrew to test the
Mark Kirkwood wrote:
Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header
How is this tidier?
(I don't see a reason for pg_buffercache_pages.h at all, actually.)
-Neil
---(end of broadcast)---
TIP 7:
Andrew Dunstan wrote:
I have confirmed that the attached patch works on Cygwin as well as
Windows. Please apply.
Applied, thanks.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
Andrew Dunstan wrote:
It fixes the build error on Windows - haven't tried because i don't have
time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
defined on Cygwin - see previous almost endless discussions.
Yes - I recall that discussion a while ago.
This patch should sort the
Mark Kirkwood wrote:
Andrew Dunstan wrote:
It fixes the build error on Windows - haven't tried because i don't have
time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
defined on Cygwin - see previous almost endless discussions.
Yes - I recall that discussion a while
10 matches
Mail list logo
