* Bruce Momjian (pgman@candle.pha.pa.us) wrote:
I am removing this patch from the queue because without the role
feature I don't think it makes sense to rename the grammer tokens.
Sure. I've rolled this patch into my role tree so these changes will be
included when the CREATE ROLE, etc is
This has been saved for the 8.1 release:
http:/momjian.postgresql.org/cgi-bin/pgpatches2
---
Stephen Frost wrote:
* Tom Lane ([EMAIL PROTECTED]) wrote:
Stephen Frost [EMAIL PROTECTED] writes:
Ok, should I
Stephen Frost [EMAIL PROTECTED] writes:
Small patch to clean up the grammer a bit by adding 'GroupId',
'SchemaName' and 'SavePointId'.
I don't particularly see the value of this --- especially since the
direction of future development is likely to be to remove the
distinction between user
* Tom Lane ([EMAIL PROTECTED]) wrote:
Stephen Frost [EMAIL PROTECTED] writes:
Small patch to clean up the grammer a bit by adding 'GroupId',
'SchemaName' and 'SavePointId'.
I don't particularly see the value of this --- especially since the
direction of future development is likely to
* Tom Lane ([EMAIL PROTECTED]) wrote:
Stephen Frost [EMAIL PROTECTED] writes:
Do you agree with the other changes (ColId - SchemaName, ColId -=20
SavePointId) ?
I don't really see the value of them. They add some marginal
documentation I suppose, but they also make the grammar bigger and
Stephen Frost [EMAIL PROTECTED] writes:
Personally, I'd just like it to be
consistent, when I was looking at how to add the grammar for group
ownership group names were identified in one place as 'ColId' and another
as 'UserId', iirc.
Oh, I had forgotten we already had a UserId production.
* Tom Lane ([EMAIL PROTECTED]) wrote:
Given other discussion, it might be best to rename it to RoleId and use
that for both users and groups.
Ok, should I change SchemaName SavePointId back to ColId, leave them
as in the patch, change them to RoleId, or something else? Neither
ColId nor
Stephen Frost [EMAIL PROTECTED] writes:
Ok, should I change SchemaName SavePointId back to ColId,
I'd just leave them as ColId. I don't think much would be gained by
introducing those productions.
regards, tom lane
---(end of
* Tom Lane ([EMAIL PROTECTED]) wrote:
Stephen Frost [EMAIL PROTECTED] writes:
Ok, should I change SchemaName SavePointId back to ColId,
I'd just leave them as ColId. I don't think much would be gained by
introducing those productions.
Done, here's the patch.
Thanks,
