Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-09 Thread Tom Lane
"Greg Sabino Mullane" <[EMAIL PROTECTED]> writes: > Would something like this be acceptable?: > (int) PQversionNumber > as a simple interface to the sversion variable? I think "version" is a little too nonspecific. We already have extern int PQprotocolVersion(const PGconn *conn); so consis

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-09 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Also, I see no need to write your own code to get the server version. > libpq already does this. It doesn't currently export an API to find it > out, but I'd rather add that than have psql duplicate the effort. Good point. I looked around, and

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-07 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > It's nice, but currently there are a lot of ways in which psql is broken > regarding older server versions. We should be caring about all of them > (ideal), or about none (the current situation). > There have been proposals in the past about making tha

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-07 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > It's nice, but currently there are a lot of ways in which psql is > broken regarding older server versions. We should be caring about > all of them (ideal), or about none (the current situation). > > There have been proposals in the past about m

Re: [PATCHES] Make psql version aware; hide tablespace from older versions

2004-08-07 Thread Alvaro Herrera
It's nice, but currently there are a lot of ways in which psql is broken regarding older server versions. We should be caring about all of them (ideal), or about none (the current situation). There have been proposals in the past about making that happen. You could investigate that (please do --