Re: [PATCHES] libpq.dll on win32

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I fixed a few merge conflicts. --- Magnus Hagander wrote: > >*** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 > >-1.54 > >--- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: >> Yes, but it's not in there by default. >> If we're going to require a third party tool to be installed, we'd >> probably be better off requiring a simple sed.exe which is a single >> binary instead of the whole perl package which is hundreds of files an

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Andrew Dunstan
Magnus Hagander wrote: The avaiable options to do it are just horrible. There is edlin, but it can't be used for anything serious. Or there is the wonderful concept of writing something in vbscript. But putting vbscript in there doesn't seem like a very good option.

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Magnus Hagander
>>The avaiable options to do it are just horrible. There is >edlin, but it >>can't be used for anything serious. Or there is the wonderful >concept of >>writing something in vbscript. But putting vbscript in there doesn't >>seem like a very good option. >> >> >> > >ActiveState Perl? It's very w

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Andrew Dunstan
Magnus Hagander wrote: (We really oughta figure a way to generate them all from a single list file... can we rely on sed(1) being available in all Windows build environments?) Unfortunatly, no, we can't. There are sed implementations available for win32, but they're not installed by default.

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Magnus Hagander
>*** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 >- 1.54 >--- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50:22 - >*** >*** 1201,1206 >--- 1201,1212 > return NULL; > return conn->ssl; > } >+ #else >+ void * >+ PQgetssl(PGconn *c

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Tom Lane
Reini Urban <[EMAIL PROTECTED]> writes: > Tom Lane schrieb: >> Also, I count 3 *.def files to be fixed, not two. (We really oughta >> figure a way to generate them all from a single list file... can we >> rely on sed(1) being available in all Windows build environments?) > for cygwin: yes. > the

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Reini Urban
Tom Lane schrieb: Also, I count 3 *.def files to be fixed, not two. (We really oughta figure a way to generate them all from a single list file... can we rely on sed(1) being available in all Windows build environments?) for cygwin: yes. the non-gcc builds would need the mingw or cygwin versions.

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane > Sent: 12 October 2004 01:38 > To: Magnus Hagander > Cc: pgsql-patches > Subject: Re: [PATCHES] libpq.dll on win32 > > Also, I count 3 *.def files to be

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Magnus Hagander > Sent: 11 October 2004 21:05 > To: pgsql-patches > Subject: [PATCHES] libpq.dll on win32 > > * Adds required functions to libpqdll.def and libpqddll.def. > This includes the fun

Re: [PATCHES] libpq.dll on win32

2004-10-11 Thread Tom Lane
"Magnus Hagander" <[EMAIL PROTECTED]> writes: *** src/interfaces/libpq/fe-secure.c28 Sep 2004 00:06:02 - 1.54 --- src/interfaces/libpq/fe-secure.c11 Oct 2004 19:50:22 - *** *** 1201,1206 --- 1201,1212 return NULL; return conn->ssl;